Skip to content

[CherryPick] Add missing files (#14854) #15036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
QilongTang merged 1 commit into from
Mar 20, 2024
Merged

[CherryPick] Add missing files (#14854) #15036

QilongTang merged 1 commit into from
Mar 20, 2024

Conversation

@QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Mar 20, 2024

Purpose

[CherryPick] Add missing files (#14854) to sign some binaries which should be ADSK signed

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

N/A

Reviewers

FYIs

@DynamoDS/dynamo

@QilongTang QilongTang added this to the 2.16.3 milestone Mar 20, 2024
@QilongTang QilongTang merged commit 42879d1 into RC2.16.3_master Mar 20, 2024
@QilongTang QilongTang deleted the CherryPick branch March 20, 2024 16:48
QilongTang added a commit that referenced this pull request Apr 9, 2024
@QilongTang @sm6srw
Add missing files (#14854) (#15036)
4b8b959 
Co-authored-by: Jorgen Dahl <sm6srw@users.noreply.github.com>
pinzart90 pushed a commit that referenced this pull request Apr 9, 2024
@QilongTang @sm6srw
Cherry pick (#15105)
91afd40 
* Add missing files (#14854) (#15036)

Co-authored-by: Jorgen Dahl <sm6srw@users.noreply.github.com>

* Update additional-files-to-sign.txt (#15040)

---------

Co-authored-by: Jorgen Dahl <sm6srw@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.16.3

Development

Successfully merging this pull request may close these issues.

3 participants

@QilongTang @sm6srw