Skip to content

DYN-6623: Add missing files #14854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sm6srw merged 1 commit into from
Jan 17, 2024
Merged

DYN-6623: Add missing files #14854

sm6srw merged 1 commit into from
Jan 17, 2024

Conversation

@sm6srw
Copy link
Contributor

@sm6srw sm6srw commented Jan 17, 2024

Purpose

DN-6623: [Security] Missing signature for Dynamo binaries

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

(FILL ME IN) Brief description of the fix / enhancement. Mandatory section

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@QilongTang QilongTang added this to the 3.0.2 milestone Jan 17, 2024
@github-actions
Copy link

github-actions bot commented Jan 17, 2024

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@sm6srw sm6srw merged commit 12c5026 into DynamoDS:master Jan 17, 2024
@sm6srw sm6srw deleted the DYN-6623 branch January 17, 2024 19:28
sm6srw added a commit to sm6srw/Dynamo that referenced this pull request Jan 17, 2024
@sm6srw
Add missing files (DynamoDS#14854)
1a2bf31
QilongTang pushed a commit that referenced this pull request Jan 17, 2024
@sm6srw
Add missing files (#14854) (#14859)
80395a9
QilongTang pushed a commit that referenced this pull request Mar 14, 2024
@sm6srw @QilongTang
Add missing files (#14854)
6296cfb
@QilongTang QilongTang mentioned this pull request Mar 14, 2024
Merged
9 tasks
QilongTang added a commit that referenced this pull request Mar 14, 2024
@QilongTang @sm6srw
Add missing files (#14854) (#15017)
8f43cf7 
Co-authored-by: Jorgen Dahl <sm6srw@users.noreply.github.com>
QilongTang pushed a commit that referenced this pull request Mar 20, 2024
@sm6srw @QilongTang
Add missing files (#14854)
65185bf
@QilongTang QilongTang mentioned this pull request Mar 20, 2024
Merged
9 tasks
QilongTang added a commit that referenced this pull request Mar 20, 2024
@QilongTang @sm6srw
Add missing files (#14854) (#15036)
42879d1 
Co-authored-by: Jorgen Dahl <sm6srw@users.noreply.github.com>
QilongTang added a commit that referenced this pull request Apr 9, 2024
@QilongTang @sm6srw
Add missing files (#14854) (#15036)
4b8b959 
Co-authored-by: Jorgen Dahl <sm6srw@users.noreply.github.com>
pinzart90 pushed a commit that referenced this pull request Apr 9, 2024
@QilongTang @sm6srw
Cherry pick (#15105)
91afd40 
* Add missing files (#14854) (#15036)

Co-authored-by: Jorgen Dahl <sm6srw@users.noreply.github.com>

* Update additional-files-to-sign.txt (#15040)

---------

Co-authored-by: Jorgen Dahl <sm6srw@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aparajit-pratap aparajit-pratap aparajit-pratap approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.0.2

Development

Successfully merging this pull request may close these issues.

3 participants

@sm6srw @aparajit-pratap @QilongTang