Skip to content

[CherryPick] Sign Python dlls by Dynamo Team #15105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pinzart90 merged 2 commits into from
Apr 9, 2024
Merged

[CherryPick] Sign Python dlls by Dynamo Team #15105

pinzart90 merged 2 commits into from
Apr 9, 2024

Conversation

@QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Apr 9, 2024

Purpose

Cherry-Pick the change to sign Python binaries by team. This change was also included in RC2.19.5 and RC2.16.4 but we could ship this security change a bit earlier.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Sign the following dlls:

  • Python.Included.dll
  • Python.Runtime.dll
  • Dynamo.Microsoft.Xaml.Behaviors.dll

Reviewers

@pinzart90

FYIs

QilongTang and others added 2 commits April 9, 2024 11:39
@QilongTang @sm6srw
Add missing files (#14854) (#15036)
4b8b959 
Co-authored-by: Jorgen Dahl <sm6srw@users.noreply.github.com>
@QilongTang
Update additional-files-to-sign.txt (#15040)
5914b96
@QilongTang QilongTang added this to the 2.16.3 milestone Apr 9, 2024
@pinzart90 pinzart90 merged commit 91afd40 into RC2.16.3_master Apr 9, 2024
@pinzart90 pinzart90 deleted the CherryPick branch April 9, 2024 15:43
@QilongTang QilongTang changed the title Cherry pick [CherryPick] Sign Python dlls by Dynamo Team Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.16.3

Development

Successfully merging this pull request may close these issues.

3 participants

@QilongTang @pinzart90