Skip to content

[recurly__recurly-js] Unmangle scoped package names#48237

Merged
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
jablko:unmangle/recurly__recurly-js
Sep 30, 2020
Merged

[recurly__recurly-js] Unmangle scoped package names#48237
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
jablko:unmangle/recurly__recurly-js

Conversation

@jablko
Copy link
Copy Markdown
Contributor

@jablko jablko commented Sep 26, 2020

@jablko jablko force-pushed the unmangle/recurly__recurly-js branch from 1a98132 to ad08719 Compare September 27, 2020 17:24
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Sep 27, 2020

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊
master #48237 diff
Batch compilation
Memory usage (MiB) 80.3 80.6 +0.4%
Type count 11976 11976 0%
Assignability cache size 3765 3765 0%
Language service
Samples taken 891 891 0%
Identifiers in tests 891 891 0%
getCompletionsAtPosition
    Mean duration (ms) 439.9 439.6 -0.1%
    Mean CV 7.8% 8.0%
    Worst duration (ms) 572.0 592.0 +3.5%
    Worst identifier next handleToken
getQuickInfoAtPosition
    Mean duration (ms) 457.7 457.8 0.0%
    Mean CV 8.6% 8.6% -0.5%
    Worst duration (ms) 567.8 571.7 +0.7%
    Worst identifier threeDSecure pricing

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@typescript-bot typescript-bot added the Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. label Sep 27, 2020
@jablko jablko marked this pull request as ready for review September 27, 2020 19:03
@typescript-bot typescript-bot added the Check Config Changes a module config files label Sep 27, 2020
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Sep 27, 2020 •
edited
Loading

@jablko Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ A DT maintainer needs to approve changes which affect module config files
    • recurly__recurly-js/tsconfig.json: changes outside of "files" list

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

Diagnostic Information: What the bot saw about this PR 
{
  "type": "info",
  "now": "-",
  "pr_number": 48237,
  "author": "jablko",
  "owners": [
    "dbrudner",
    "chrissrogers"
  ],
  "dangerLevel": "ScopedAndConfiguration",
  "headCommitAbbrOid": "ad08719",
  "headCommitOid": "ad08719e8ed30e2f01938065bc155e217a041ffe",
  "mergeIsRequested": true,
  "stalenessInDays": 0,
  "lastPushDate": "2020-09-27T17:24:54.000Z",
  "reopenedDate": "2020-09-27T19:03:41.000Z",
  "lastCommentDate": "2020-09-30T14:23:00.000Z",
  "maintainerBlessed": false,
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/48237/files",
  "hasMergeConflict": false,
  "authorIsOwner": false,
  "isFirstContribution": false,
  "popularityLevel": "Well-liked by everyone",
  "newPackages": [],
  "packages": [
    "recurly__recurly-js"
  ],
  "files": [
    {
      "path": "types/recurly__recurly-js/test/bank-account.ts",
      "kind": "test",
      "package": "recurly__recurly-js"
    },
    {
      "path": "types/recurly__recurly-js/test/recurly-error.ts",
      "kind": "test",
      "package": "recurly__recurly-js"
    },
    {
      "path": "types/recurly__recurly-js/tsconfig.json",
      "kind": "package-meta",
      "package": "recurly__recurly-js",
      "suspect": "changes outside of \"files\" list"
    }
  ],
  "hasDismissedReview": false,
  "ciResult": "pass",
  "lastReviewDate": "2020-09-30T00:07:42.000Z",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 5,
  "isChangesRequested": false
}

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Sep 27, 2020

🔔 @dbrudner @chrissrogers — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added the Other Approved This PR was reviewed and signed-off by a community member. label Sep 27, 2020
@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Sep 30, 2020
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Sep 30, 2020

@jablko Everything looks good here. Great job! I am ready to merge this PR on your behalf.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@dbrudner, @chrissrogers: you can do this too.)

@dbrudner
Copy link
Copy Markdown
Contributor

dbrudner commented Sep 30, 2020

Ready to merge

@typescript-bot typescript-bot merged commit 2b7a59f into DefinitelyTyped:master Sep 30, 2020
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Sep 30, 2020

I just published @types/recurly__recurly-js@4.14.2 to npm.

dbrudner added a commit to recurly/recurly-js that referenced this pull request Oct 5, 2020
@dbrudner
Backfilling updates to DefinitelyTyped types
fc56387 
- Unmangles scoped package name where appropriate.
- The only references to the mangled package name (recurly__recurly-js)
should be when referencing DefinitelyTyped's file structure, e.g. the DT
GitHub action
- Reference PRs includes
    - DefinitelyTyped/DefinitelyTyped#47115
    - DefinitelyTyped/DefinitelyTyped#48237
    - DefinitelyTyped/DefinitelyTyped#47173
dbrudner added a commit to recurly/recurly-js that referenced this pull request Oct 5, 2020
@dbrudner
Backfilling updates to DefinitelyTyped types
b451605 
- Unmangles scoped package name where appropriate.
- The only references to the mangled package name (recurly__recurly-js)
should be when referencing DefinitelyTyped's file structure, e.g. the DT
GitHub action
- Reference PRs includes
    - DefinitelyTyped/DefinitelyTyped#47115
    - DefinitelyTyped/DefinitelyTyped#48237
    - DefinitelyTyped/DefinitelyTyped#47173
dbrudner added a commit to recurly/recurly-js that referenced this pull request Oct 5, 2020
@dbrudner
Backfilling updates to DefinitelyTyped types
19c0e6a 
- Unmangles scoped package name where appropriate.
- The only references to the mangled package name (recurly__recurly-js)
should be when referencing DefinitelyTyped's file structure, e.g. the DT
GitHub action
- Reference PRs includes
    - DefinitelyTyped/DefinitelyTyped#47115
    - DefinitelyTyped/DefinitelyTyped#48237
    - DefinitelyTyped/DefinitelyTyped#47173
dbrudner added a commit to recurly/recurly-js that referenced this pull request Oct 5, 2020
@dbrudner
Backfilling updates to DefinitelyTyped types
2a89708 
- Unmangles scoped package name where appropriate.
- The only references to the mangled package name (recurly__recurly-js)
should be when referencing DefinitelyTyped's file structure, e.g. the DT
GitHub action
- Reference PRs includes
    - DefinitelyTyped/DefinitelyTyped#47115
    - DefinitelyTyped/DefinitelyTyped#48237
    - DefinitelyTyped/DefinitelyTyped#47173
dbrudner added a commit to recurly/recurly-js that referenced this pull request Oct 5, 2020
@dbrudner
Backfilling updates to DefinitelyTyped types
ba42c14 
- Unmangles scoped package name where appropriate.
- The only references to the mangled package name (recurly__recurly-js)
should be when referencing DefinitelyTyped's file structure, e.g. the DT
GitHub action
- Reference PRs includes
    - DefinitelyTyped/DefinitelyTyped#47115
    - DefinitelyTyped/DefinitelyTyped#48237
    - DefinitelyTyped/DefinitelyTyped#47173
dbrudner added a commit to recurly/recurly-js that referenced this pull request Oct 6, 2020
@dbrudner
Backfilling updates to DefinitelyTyped types
3a45e97 
- Unmangles scoped package name where appropriate.
- The only references to the mangled package name (recurly__recurly-js)
should be when referencing DefinitelyTyped's file structure, e.g. the DT
GitHub action
- Reference PRs includes
    - DefinitelyTyped/DefinitelyTyped#47115
    - DefinitelyTyped/DefinitelyTyped#48237
    - DefinitelyTyped/DefinitelyTyped#47173
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peterblazejewicz peterblazejewicz peterblazejewicz approved these changes

+1 more reviewer

@amcasey amcasey amcasey approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Check Config Changes a module config files Maintainer Approved Other Approved This PR was reviewed and signed-off by a community member. Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jablko @typescript-bot @dbrudner @peterblazejewicz @amcasey