Skip to content

[recurly__recurly-js] Unmangle scoped package names#47173

Merged
orta merged 1 commit intoDefinitelyTyped:masterfrom
jablko:unmangle/recurly__recurly-js
Aug 31, 2020
Merged

[recurly__recurly-js] Unmangle scoped package names#47173
orta merged 1 commit intoDefinitelyTyped:masterfrom
jablko:unmangle/recurly__recurly-js

Conversation

@jablko
Copy link
Copy Markdown
Contributor

@jablko jablko commented Aug 31, 2020

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Aug 31, 2020

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊
master #47173 diff
Batch compilation
Memory usage (MiB) 73.0 72.3 -0.9%
Type count 11898 11898 0%
Assignability cache size 3746 3746 0%
Language service
Samples taken 891 891 0%
Identifiers in tests 891 891 0%
getCompletionsAtPosition
    Mean duration (ms) 362.8 348.9 -3.8%
    Mean CV 8.7% 8.8%
    Worst duration (ms) 468.6 509.8 +8.8%
    Worst identifier document recurly
getQuickInfoAtPosition
    Mean duration (ms) 381.8 367.3 -3.8%
    Mean CV 9.7% 9.6% -1.5%
    Worst duration (ms) 518.1 466.8 -9.9%
    Worst identifier risk on

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@typescript-bot typescript-bot added the Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. label Aug 31, 2020
@jablko jablko marked this pull request as ready for review August 31, 2020 18:38
@typescript-bot typescript-bot added the Untested Change This PR does not touch tests label Aug 31, 2020
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Aug 31, 2020 •
edited
Loading

@jablko Thank you for submitting this PR!

This is a live comment which I will keep updated.

This PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Have you considered adding tests to cover the change you're making? Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you.

1 package in this PR

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ❌ Only a DT maintainer can approve changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Diagnostic Information: What the bot saw about this PR 
{
  "type": "info",
  "now": "-",
  "pr_number": 47173,
  "author": "jablko",
  "owners": [
    "dbrudner",
    "chrissrogers"
  ],
  "dangerLevel": "ScopedAndUntested",
  "headCommitAbbrOid": "3df3148",
  "headCommitOid": "3df3148c1f1d3e0451bc8d06b1ee395a0e04677d",
  "mergeIsRequested": false,
  "stalenessInDays": 0,
  "lastPushDate": "2020-08-31T16:52:48.000Z",
  "reopenedDate": "2020-08-31T18:38:25.000Z",
  "lastCommentDate": "2020-08-31T16:52:48.000Z",
  "maintainerBlessed": false,
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/47173/files",
  "hasMergeConflict": false,
  "authorIsOwner": false,
  "isFirstContribution": false,
  "popularityLevel": "Well-liked by everyone",
  "newPackages": [],
  "packages": [
    "recurly__recurly-js"
  ],
  "files": [
    {
      "path": "types/recurly__recurly-js/index.d.ts",
      "kind": "definition",
      "package": "recurly__recurly-js"
    }
  ],
  "hasDismissedReview": false,
  "ciResult": "pass",
  "lastReviewDate": "2020-08-31T18:47:47.000Z",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 2,
  "isChangesRequested": false
}

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Aug 31, 2020

🔔 @dbrudner @chrissrogers — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Aug 31, 2020
@orta orta merged commit fe6706d into DefinitelyTyped:master Aug 31, 2020
chivesrs pushed a commit to chivesrs/DefinitelyTyped that referenced this pull request Sep 2, 2020
@jablko @chivesrs
[recurly__recurly-js] Unmangle scoped package names (DefinitelyTyped#…
672f359 
…47173)
danielrearden pushed a commit to danielrearden/DefinitelyTyped that referenced this pull request Sep 22, 2020
@jablko @danielrearden
[recurly__recurly-js] Unmangle scoped package names (DefinitelyTyped#…
aff2467 
…47173)
dbrudner added a commit to recurly/recurly-js that referenced this pull request Oct 5, 2020
@dbrudner
Backfilling updates to DefinitelyTyped types
fc56387 
- Unmangles scoped package name where appropriate.
- The only references to the mangled package name (recurly__recurly-js)
should be when referencing DefinitelyTyped's file structure, e.g. the DT
GitHub action
- Reference PRs includes
    - DefinitelyTyped/DefinitelyTyped#47115
    - DefinitelyTyped/DefinitelyTyped#48237
    - DefinitelyTyped/DefinitelyTyped#47173
dbrudner added a commit to recurly/recurly-js that referenced this pull request Oct 5, 2020
@dbrudner
Backfilling updates to DefinitelyTyped types
b451605 
- Unmangles scoped package name where appropriate.
- The only references to the mangled package name (recurly__recurly-js)
should be when referencing DefinitelyTyped's file structure, e.g. the DT
GitHub action
- Reference PRs includes
    - DefinitelyTyped/DefinitelyTyped#47115
    - DefinitelyTyped/DefinitelyTyped#48237
    - DefinitelyTyped/DefinitelyTyped#47173
dbrudner added a commit to recurly/recurly-js that referenced this pull request Oct 5, 2020
@dbrudner
Backfilling updates to DefinitelyTyped types
19c0e6a 
- Unmangles scoped package name where appropriate.
- The only references to the mangled package name (recurly__recurly-js)
should be when referencing DefinitelyTyped's file structure, e.g. the DT
GitHub action
- Reference PRs includes
    - DefinitelyTyped/DefinitelyTyped#47115
    - DefinitelyTyped/DefinitelyTyped#48237
    - DefinitelyTyped/DefinitelyTyped#47173
dbrudner added a commit to recurly/recurly-js that referenced this pull request Oct 5, 2020
@dbrudner
Backfilling updates to DefinitelyTyped types
2a89708 
- Unmangles scoped package name where appropriate.
- The only references to the mangled package name (recurly__recurly-js)
should be when referencing DefinitelyTyped's file structure, e.g. the DT
GitHub action
- Reference PRs includes
    - DefinitelyTyped/DefinitelyTyped#47115
    - DefinitelyTyped/DefinitelyTyped#48237
    - DefinitelyTyped/DefinitelyTyped#47173
dbrudner added a commit to recurly/recurly-js that referenced this pull request Oct 5, 2020
@dbrudner
Backfilling updates to DefinitelyTyped types
ba42c14 
- Unmangles scoped package name where appropriate.
- The only references to the mangled package name (recurly__recurly-js)
should be when referencing DefinitelyTyped's file structure, e.g. the DT
GitHub action
- Reference PRs includes
    - DefinitelyTyped/DefinitelyTyped#47115
    - DefinitelyTyped/DefinitelyTyped#48237
    - DefinitelyTyped/DefinitelyTyped#47173
dbrudner added a commit to recurly/recurly-js that referenced this pull request Oct 6, 2020
@dbrudner
Backfilling updates to DefinitelyTyped types
3a45e97 
- Unmangles scoped package name where appropriate.
- The only references to the mangled package name (recurly__recurly-js)
should be when referencing DefinitelyTyped's file structure, e.g. the DT
GitHub action
- Reference PRs includes
    - DefinitelyTyped/DefinitelyTyped#47115
    - DefinitelyTyped/DefinitelyTyped#48237
    - DefinitelyTyped/DefinitelyTyped#47173
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@chrissrogers chrissrogers chrissrogers approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Owner Approved A listed owner of this package signed off on the pull request. Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. Untested Change This PR does not touch tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jablko @typescript-bot @chrissrogers @orta