Skip to content

Unmangle scoped package names#47115

Closed
jablko wants to merge 1 commit intoDefinitelyTyped:masterfrom
jablko:patch-17
Closed

Unmangle scoped package names#47115
jablko wants to merge 1 commit intoDefinitelyTyped:masterfrom
jablko:patch-17

Conversation

@jablko
Copy link
Copy Markdown
Contributor

@jablko jablko commented Aug 28, 2020

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

@danger-public
Copy link
Copy Markdown

danger-public commented Aug 28, 2020

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

entria__relay-experimental (unpkg)

was missing the following properties:

  1. MatchContainer
  2. ProfilerContext
  3. useBlockingPaginationFragment

solid__react (unpkg)

was missing the following properties:

  1. useLiveUpdate
  2. withWebId
  3. evaluateExpressions
  4. evaluateList
  5. UpdateContext
as well as these 5 other properties...

useLiveUpdate, withWebId, evaluateExpressions, evaluateList, UpdateContext

webscopeio__react-textarea-autocomplete (unpkg)

was missing the following properties:

  1. The declaration doesn't match the JavaScript module 'webscopeio__react-textarea-autocomplete'. Reason:
    The JavaScript module can be called or constructed, but the declaration module cannot.

The most common way to resolve this error is to use 'export =' syntax.
To learn more about 'export =' syntax, see https://www.typescriptlang.org/docs/handbook/modules.html#export--and-import--require.

  1. defaultProps

Generated by 🚫 dangerJS against bbe5088

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Aug 28, 2020

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

atlaskit__calendar/v*

Comparison details for atlaskit__calendar/* 📊
master #47115 diff
Batch compilation
Memory usage (MiB) 111.5 107.6 -3.5%
Type count 24457 24457 0%
Assignability cache size 6118 6118 0%
Language service
Samples taken 11 11 0%
Identifiers in tests 11 11 0%
getCompletionsAtPosition
    Mean duration (ms) 543.5 551.7 +1.5%
    Mean CV 9.7% 11.3%
    Worst duration (ms) 616.5 624.7 +1.3%
    Worst identifier year onChange
getQuickInfoAtPosition
    Mean duration (ms) 529.2 540.0 +2.0%
    Mean CV 11.5% 8.0% -30.4%
    Worst duration (ms) 588.9 600.4 +2.0%
    Worst identifier month onChange

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

atlaskit__feedback-collector/v*

Comparison details for atlaskit__feedback-collector/* 📊
master #47115 diff
Batch compilation
Memory usage (MiB) 109.7 108.9 -0.8%
Type count 24679 24679 0%
Assignability cache size 6199 6199 0%
Language service
Samples taken 64 64 0%
Identifiers in tests 64 64 0%
getCompletionsAtPosition
    Mean duration (ms) 536.5 535.0 -0.3%
    Mean CV 10.3% 9.9%
    Worst duration (ms) 605.5 627.3 +3.6%
    Worst identifier FeedbackForm render
getQuickInfoAtPosition
    Mean duration (ms) 529.5 532.1 +0.5%
    Mean CV 9.4% 10.0% +6.4%
    Worst duration (ms) 651.6 606.4 -6.9%
    Worst identifier typeQuestionDefaultValue typeSuggestionDefaultValue

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

blazor__javascript-interop/v*

Comparison details for blazor__javascript-interop/* 📊
master #47115 diff
Batch compilation
Memory usage (MiB) 70.3 71.0 +0.9%
Type count 10286 10286 0%
Assignability cache size 3461 3461 0%
Language service
Samples taken 79 79 0%
Identifiers in tests 79 79 0%
getCompletionsAtPosition
    Mean duration (ms) 351.1 351.6 +0.2%
    Mean CV 12.4% 12.4%
    Worst duration (ms) 456.1 418.5 -8.2%
    Worst identifier text ColorFlags
getQuickInfoAtPosition
    Mean duration (ms) 343.6 340.1 -1.0%
    Mean CV 11.7% 11.0% -5.2%
    Worst duration (ms) 414.6 398.4 -3.9%
    Worst identifier welcomeMessage displayWelcome

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

entria__relay-experimental/v*

Comparison details for entria__relay-experimental/* 📊
master #47115 diff
Batch compilation
Memory usage (MiB) 122.3 122.1 -0.2%
Type count 26013 26013 0%
Assignability cache size 6491 6491 0%
Language service
Samples taken 184 184 0%
Identifiers in tests 184 184 0%
getCompletionsAtPosition
    Mean duration (ms) 586.3 573.9 -2.1%
    Mean CV 7.9% 8.2%
    Worst duration (ms) 820.3 810.9 -1.1%
    Worst identifier div div
getQuickInfoAtPosition
    Mean duration (ms) 588.8 578.7 -1.7%
    Mean CV 8.2% 9.0% +10.1%
    Worst duration (ms) 714.4 710.3 -0.6%
    Worst identifier after network

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

google-cloud__text-to-speech/v*

Comparison details for google-cloud__text-to-speech/* 📊
master #47115 diff
Batch compilation
Memory usage (MiB) 69.9 60.4 -13.6%
Type count 9032 9032 0%
Assignability cache size 1621 1621 0%
Language service
Samples taken 72 72 0%
Identifiers in tests 72 72 0%
getCompletionsAtPosition
    Mean duration (ms) 355.1 358.8 +1.1%
    Mean CV 10.3% 10.9%
    Worst duration (ms) 439.3 480.5 +9.4%
    Worst identifier audioEncoding name
getQuickInfoAtPosition
    Mean duration (ms) 353.1 353.8 +0.2%
    Mean CV 10.7% 10.5% -2.1%
    Worst duration (ms) 429.8 417.2 -2.9%
    Worst identifier log res

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

hig__button/v*

Comparison details for hig__button/* 📊
master #47115 diff
Batch compilation
Memory usage (MiB) 71.5 71.8 +0.5%
Type count 16876 16876 0%
Assignability cache size 2803 2803 0%
Language service
Samples taken 120 120 0%
Identifiers in tests 120 120 0%
getCompletionsAtPosition
    Mean duration (ms) 249.2 249.9 +0.3%
    Mean CV 10.7% 9.8%
    Worst duration (ms) 311.7 340.4 +9.2%
    Worst identifier width div
getQuickInfoAtPosition
    Mean duration (ms) 242.1 246.2 +1.7%
    Mean CV 11.1% 11.6% +4.1%
    Worst duration (ms) 310.7 298.6 -3.9%
    Worst identifier width width

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

mapbox__polyline/v*

Comparison details for mapbox__polyline/* 📊
master #47115 diff
Batch compilation
Memory usage (MiB) 36.3 36.4 +0.2%
Type count 2206 2206 0%
Assignability cache size 119 119 0%
Language service
Samples taken 38 38 0%
Identifiers in tests 38 38 0%
getCompletionsAtPosition
    Mean duration (ms) 85.6 86.9 +1.5%
    Mean CV 26.9% 25.9%
    Worst duration (ms) 108.1 111.6 +3.2%
    Worst identifier GeoJSON GeoJSON
getQuickInfoAtPosition
    Mean duration (ms) 84.5 85.5 +1.2%
    Mean CV 24.4% 24.4% 0.0%
    Worst duration (ms) 117.0 113.3 -3.1%
    Worst identifier polyline polyline

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

mapbox__s3urls/v*

Comparison details for mapbox__s3urls/* 📊
master #47115 diff
Batch compilation
Memory usage (MiB) 36.2 36.0 -0.4%
Type count 2125 2125 0%
Assignability cache size 95 95 0%
Language service
Samples taken 21 21 0%
Identifiers in tests 21 21 0%
getCompletionsAtPosition
    Mean duration (ms) 77.8 80.4 +3.4%
    Mean CV 16.0% 17.1%
    Worst duration (ms) 108.3 112.9 +4.3%
    Worst identifier s3urls fromUrl
getQuickInfoAtPosition
    Mean duration (ms) 77.9 80.0 +2.8%
    Mean CV 17.1% 16.0% -6.5%
    Worst duration (ms) 90.9 91.1 +0.2%
    Worst identifier convert convert

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

pusher__chatkit-client/v*

Comparison details for pusher__chatkit-client/* 📊
master #47115 diff
Batch compilation
Memory usage (MiB) 72.0 72.0 0.0%
Type count 10387 10387 0%
Assignability cache size 3504 3504 0%
Language service
Samples taken 206 206 0%
Identifiers in tests 206 206 0%
getCompletionsAtPosition
    Mean duration (ms) 343.5 343.9 +0.1%
    Mean CV 10.4% 10.2%
    Worst duration (ms) 419.2 433.1 +3.3%
    Worst identifier room UserPresenceState
getQuickInfoAtPosition
    Mean duration (ms) 346.0 343.7 -0.7%
    Mean CV 10.5% 10.5% +0.8%
    Worst duration (ms) 430.8 412.8 -4.2%
    Worst identifier currentUser updateRoom

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

recurly__recurly-js/v*

Comparison details for recurly__recurly-js/* 📊
master #47115 diff
Batch compilation
Memory usage (MiB) 73.6 73.7 +0.1%
Type count 11898 11898 0%
Assignability cache size 3746 3746 0%
Language service
Samples taken 891 891 0%
Identifiers in tests 891 891 0%
getCompletionsAtPosition
    Mean duration (ms) 351.4 356.6 +1.5%
    Mean CV 8.6% 8.2%
    Worst duration (ms) 450.0 474.1 +5.4%
    Worst identifier countryCode document
getQuickInfoAtPosition
    Mean duration (ms) 369.8 374.3 +1.2%
    Mean CV 9.5% 9.1% -4.8%
    Worst duration (ms) 469.1 486.3 +3.7%
    Worst identifier err err

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

solid__react/v*

Comparison details for solid__react/* 📊
master #47115 diff
Batch compilation
Memory usage (MiB) 73.5 76.3 +3.9%
Type count 17539 17539 0%
Assignability cache size 2993 2993 0%
Language service
Samples taken 49 49 0%
Identifiers in tests 49 49 0%
getCompletionsAtPosition
    Mean duration (ms) 263.4 265.1 +0.7%
    Mean CV 12.6% 14.2%
    Worst duration (ms) 419.6 392.0 -6.6%
    Worst identifier undefined undefined
getQuickInfoAtPosition
    Mean duration (ms) 254.7 253.4 -0.5%
    Mean CV 15.3% 13.2% -13.9%
    Worst duration (ms) 349.7 371.5 +6.2%
    Worst identifier onSubmit onSubmit

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

svg-maps__usa/v*

Comparison details for svg-maps__usa/* 📊
master #47115 diff
Batch compilation
Memory usage (MiB) 36.2 36.1 -0.2%
Type count 2124 2124 0%
Assignability cache size 101 101 0%
Language service
Samples taken 19 19 0%
Identifiers in tests 19 19 0%
getCompletionsAtPosition
    Mean duration (ms) 78.5 78.5 -0.1%
    Mean CV 14.1% 14.6%
    Worst duration (ms) 103.3 110.4 +6.9%
    Worst identifier id path
getQuickInfoAtPosition
    Mean duration (ms) 79.8 79.5 -0.4%
    Mean CV 14.3% 15.0% +4.6%
    Worst duration (ms) 89.6 96.0 +7.1%
    Worst identifier label label

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

typeform__embed/v*

Comparison details for typeform__embed/* 📊
master #47115 diff
Batch compilation
Memory usage (MiB) 68.5 69.8 +1.9%
Type count 10265 10265 0%
Assignability cache size 3461 3461 0%
Language service
Samples taken 51 51 0%
Identifiers in tests 51 51 0%
getCompletionsAtPosition
    Mean duration (ms) 354.9 357.7 +0.8%
    Mean CV 14.0% 13.9%
    Worst duration (ms) 406.9 444.9 +9.3%
    Worst identifier stubContainerEl typeformEmbed
getQuickInfoAtPosition
    Mean duration (ms) 353.2 351.7 -0.4%
    Mean CV 13.7% 12.9% -5.7%
    Worst duration (ms) 425.2 409.9 -3.6%
    Worst identifier makeWidget onReady

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

webscopeio__react-textarea-autocomplete/v*

Comparison details for webscopeio__react-textarea-autocomplete/* 📊
master #47115 diff
Batch compilation
Memory usage (MiB) 116.8 116.8 0.0%
Type count 25033 25033 0%
Assignability cache size 6191 6191 0%
Language service
Samples taken 120 120 0%
Identifiers in tests 120 120 0%
getCompletionsAtPosition
    Mean duration (ms) 557.0 557.7 +0.1%
    Mean CV 8.8% 9.6%
    Worst duration (ms) 741.0 764.3 +3.1%
    Worst identifier onChange onChange
getQuickInfoAtPosition
    Mean duration (ms) 544.0 542.9 -0.2%
    Mean CV 8.7% 8.7% -0.4%
    Worst duration (ms) 677.3 706.3 +4.3%
    Worst identifier closeOnClickOutside margin

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@typescript-bot typescript-bot added the Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. label Aug 28, 2020
This was referenced Aug 29, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@peterblazejewicz
Copy link
Copy Markdown
Member

peterblazejewicz commented Aug 30, 2020 •
edited
Loading

~~@jablko Jack, should I take changes for a relevant package (blazor/interop) into separate PR? thx!~~~
scratch the question, just noticed the PR, thanks!

@jablko
Copy link
Copy Markdown
Contributor Author

jablko commented Aug 30, 2020

@peterblazejewicz 👍 Thank you!

This was referenced Aug 31, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@orta
Copy link
Copy Markdown
Collaborator

orta commented Sep 2, 2020

OK, that's all of them - thanks for the individual PRs @jablko

@orta orta closed this Sep 2, 2020
This was referenced Sep 26, 2020
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Sep 26, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
dbrudner added a commit to recurly/recurly-js that referenced this pull request Oct 5, 2020
@dbrudner
Backfilling updates to DefinitelyTyped types
fc56387 
- Unmangles scoped package name where appropriate.
- The only references to the mangled package name (recurly__recurly-js)
should be when referencing DefinitelyTyped's file structure, e.g. the DT
GitHub action
- Reference PRs includes
    - DefinitelyTyped/DefinitelyTyped#47115
    - DefinitelyTyped/DefinitelyTyped#48237
    - DefinitelyTyped/DefinitelyTyped#47173
dbrudner added a commit to recurly/recurly-js that referenced this pull request Oct 5, 2020
@dbrudner
Backfilling updates to DefinitelyTyped types
b451605 
- Unmangles scoped package name where appropriate.
- The only references to the mangled package name (recurly__recurly-js)
should be when referencing DefinitelyTyped's file structure, e.g. the DT
GitHub action
- Reference PRs includes
    - DefinitelyTyped/DefinitelyTyped#47115
    - DefinitelyTyped/DefinitelyTyped#48237
    - DefinitelyTyped/DefinitelyTyped#47173
dbrudner added a commit to recurly/recurly-js that referenced this pull request Oct 5, 2020
@dbrudner
Backfilling updates to DefinitelyTyped types
19c0e6a 
- Unmangles scoped package name where appropriate.
- The only references to the mangled package name (recurly__recurly-js)
should be when referencing DefinitelyTyped's file structure, e.g. the DT
GitHub action
- Reference PRs includes
    - DefinitelyTyped/DefinitelyTyped#47115
    - DefinitelyTyped/DefinitelyTyped#48237
    - DefinitelyTyped/DefinitelyTyped#47173
dbrudner added a commit to recurly/recurly-js that referenced this pull request Oct 5, 2020
@dbrudner
Backfilling updates to DefinitelyTyped types
2a89708 
- Unmangles scoped package name where appropriate.
- The only references to the mangled package name (recurly__recurly-js)
should be when referencing DefinitelyTyped's file structure, e.g. the DT
GitHub action
- Reference PRs includes
    - DefinitelyTyped/DefinitelyTyped#47115
    - DefinitelyTyped/DefinitelyTyped#48237
    - DefinitelyTyped/DefinitelyTyped#47173
dbrudner added a commit to recurly/recurly-js that referenced this pull request Oct 5, 2020
@dbrudner
Backfilling updates to DefinitelyTyped types
ba42c14 
- Unmangles scoped package name where appropriate.
- The only references to the mangled package name (recurly__recurly-js)
should be when referencing DefinitelyTyped's file structure, e.g. the DT
GitHub action
- Reference PRs includes
    - DefinitelyTyped/DefinitelyTyped#47115
    - DefinitelyTyped/DefinitelyTyped#48237
    - DefinitelyTyped/DefinitelyTyped#47173
dbrudner added a commit to recurly/recurly-js that referenced this pull request Oct 6, 2020
@dbrudner
Backfilling updates to DefinitelyTyped types
3a45e97 
- Unmangles scoped package name where appropriate.
- The only references to the mangled package name (recurly__recurly-js)
should be when referencing DefinitelyTyped's file structure, e.g. the DT
GitHub action
- Reference PRs includes
    - DefinitelyTyped/DefinitelyTyped#47115
    - DefinitelyTyped/DefinitelyTyped#48237
    - DefinitelyTyped/DefinitelyTyped#47173
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peterblazejewicz peterblazejewicz Awaiting requested review from peterblazejewicz peterblazejewicz will be requested when the pull request is marked ready for review peterblazejewicz is a code owner

Assignees

No one assigned

Labels

Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jablko @danger-public @typescript-bot @peterblazejewicz @orta