[react] RE: Add unstable_Profiler#34253
Conversation
|
@eps1lon Thank you for submitting this PR! 🔔 @johnnyreilly @bbenezech @pzavolinsky @digiguru @ericanderson @tkrotoff @DovydasNavickas @onigoetz @theruther4d @guilhermehubner @ferdaber @jrakotoharisoa @pascaloliv @Hotell @franklixuefei @Jessidhia @pshrmn @saranshkataria @lukyth - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
|
@eps1lon The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
5ca62dd to
95a25e0
Compare
|
@eps1lon The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
|
@eps1lon I haven't seen anything from you in a while and this PR currently has problems that prevent it from being merged. The PR will be closed tomorrow if there aren't new commits to fix the issues. |
OnRenderCallback is to generic
It's actually part of scheduler/tracing
95a25e0 to
3b92e92
Compare
|
/cc @sandersn @Jessidhia CI failure is unrelated. Could any human stop the bot please? |
|
@eps1lon The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
|
I just published |
* feat(react): Add unstable_Profiler * OnRenderCallback -> ProfilerOnRenderCallback OnRenderCallback is to generic * Interaction -> SchedulerInteraction It's actually part of scheduler/tracing
|
@eps1lon @Jessidhia is there any workaround for typing how to reproduce: then run |
|
my workaround in the end was adding this because
|
|
@cscleison Be aware that you always have to polyfill |
| const version: string; | ||
|
|
||
| /** | ||
| * {@link https://github.com/bvaughn/rfcs/blob/profiler/text/0000-profiler.md#detailed-design | API} |
Copy of #33996
Any issue I can track about the state of this repo? Most of my PRs are now handled by a bot only and humans can only give advise that's essentially ignored. I do not understand how it is acceptable that the bot can close a PR that is accepted by an owner.