Skip to content

[react] RE: Add unstable_Profiler#34253

Merged
sandersn merged 3 commits intoDefinitelyTyped:masterfrom
eps1lon:feat/react/profiler-2
Apr 3, 2019
Merged

[react] RE: Add unstable_Profiler#34253
sandersn merged 3 commits intoDefinitelyTyped:masterfrom
eps1lon:feat/react/profiler-2

Conversation

@eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Mar 27, 2019

Copy of #33996

Any issue I can track about the state of this repo? Most of my PRs are now handled by a bot only and humans can only give advise that's essentially ignored. I do not understand how it is acceptable that the bot can close a PR that is accepted by an owner.

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Awaiting reviewer feedback labels Mar 27, 2019
@typescript-bot
Copy link
Contributor

typescript-bot commented Mar 27, 2019

@eps1lon Thank you for submitting this PR!

🔔 @johnnyreilly @bbenezech @pzavolinsky @digiguru @ericanderson @tkrotoff @DovydasNavickas @onigoetz @theruther4d @guilhermehubner @ferdaber @jrakotoharisoa @pascaloliv @Hotell @franklixuefei @Jessidhia @pshrmn @saranshkataria @lukyth - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot
Copy link
Contributor

typescript-bot commented Mar 27, 2019

@eps1lon The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@typescript-bot typescript-bot added the Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. label Mar 27, 2019
@eps1lon eps1lon force-pushed the feat/react/profiler-2 branch from 5ca62dd to 95a25e0 Compare March 27, 2019 15:03
@typescript-bot typescript-bot added Awaiting reviewer feedback and removed The Travis CI build failed Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. labels Mar 27, 2019
@typescript-bot
Copy link
Contributor

typescript-bot commented Mar 27, 2019

@eps1lon The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@ferdaber
Copy link
Contributor

@eps1lon if local tests pass just cc @sandersn so he can merge manually.

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Mar 27, 2019
@typescript-bot
Copy link
Contributor

@eps1lon I haven't seen anything from you in a while and this PR currently has problems that prevent it from being merged. The PR will be closed tomorrow if there aren't new commits to fix the issues.

@eps1lon eps1lon force-pushed the feat/react/profiler-2 branch from 95a25e0 to 3b92e92 Compare April 2, 2019 15:33
@eps1lon
Copy link
Collaborator Author

eps1lon commented Apr 2, 2019

/cc @sandersn @Jessidhia

CI failure is unrelated. Could any human stop the bot please?

@typescript-bot
Copy link
Contributor

typescript-bot commented Apr 2, 2019

@eps1lon The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@sandersn sandersn merged commit 7d483f0 into DefinitelyTyped:master Apr 3, 2019
@typescript-bot
Copy link
Contributor

I just published @types/react@16.8.12 to npm.

@eps1lon eps1lon deleted the feat/react/profiler-2 branch April 3, 2019 22:11
alesn pushed a commit to alesn/DefinitelyTyped that referenced this pull request Apr 23, 2019
* feat(react): Add unstable_Profiler

* OnRenderCallback -> ProfilerOnRenderCallback

OnRenderCallback is to generic

* Interaction -> SchedulerInteraction

It's actually part of scheduler/tracing
@cscleison
Copy link
Contributor

cscleison commented Aug 12, 2019

@eps1lon @Jessidhia is there any workaround for typing Set? I need to target es5 and as Set is es6 it does not compile. I know I can just do "lib": ["es6"] but that implies the es6 apis are available at runtime (ts would not complain if I use any es6 api like array find, but for ie11 I would have to add polyfills myself because lib it's just to tell typescript to not complain).

how to reproduce:

{
  "name": "test",
  "devDependencies": {
    "@types/react": "^16.9.1",
    "typescript": "^3.5.3"
  },
  "dependencies": {
    "react": "^16.9.0"
  }
}
{
  "compilerOptions": {
    "target": "es5",
    "strict": true,
    "jsx": "react",
    "outDir": "dist"
  },
  "include": ["./*.tsx"]
}

import * as React from "react";

const Foo = () => <div>bar</div>;

export { Foo };

then run npx tsc

@cscleison
Copy link
Contributor

cscleison commented Aug 12, 2019

my workaround in the end was adding this because Map and Set is partially supported by IE

"lib": ["es5", "dom", "es2015.promise", "es2015.collection"]

@eps1lon
Copy link
Collaborator Author

eps1lon commented Aug 12, 2019

@cscleison Be aware that you always have to polyfill Map and Set when using react. IE11 does not support all methods properly so you still need add polyfills for those missing methods.

const version: string;

/**
* {@link https://github.com/bvaughn/rfcs/blob/profiler/text/0000-profiler.md#detailed-design | API}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI this is a broken link.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened a new PR #52735

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Owner Approved A listed owner of this package signed off on the pull request. Popular package This PR affects a popular package (as counted by NPM download counts).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants