[react] Add unstable_Profiler#33996
Conversation
types/react/index.d.ts
Outdated
| baseDuration: number, | ||
| startTime: number, | ||
| commitTime: number, | ||
| interactions: Set<Interaction>, |
There was a problem hiding this comment.
Current implementation does not match proposal:
- https://github.com/facebook/react/blob/f0621fe232f31cb0fcd63992c3440ec1b4ce5813/packages/react-reconciler/src/ReactFiberCommitWork.js#L574
- https://github.com/facebook/react/blob/4a1072194fcef2da1aae2510886c274736017fbd/packages/react-reconciler/src/ReactFiberRoot.js#L94
- https://github.com/facebook/react/blob/7ea3ca1d13b1b609678fa1369f8a1020c3ecb976/packages/scheduler/src/Tracing.js#L12
__count looks like its private (dangling underscore).
|
@eps1lon Thank you for submitting this PR! 🔔 @johnnyreilly @bbenezech @pzavolinsky @digiguru @ericanderson @tkrotoff @DovydasNavickas @onigoetz @theruther4d @guilhermehubner @ferdaber @jrakotoharisoa @pascaloliv @Hotell @franklixuefei @Jessidhia @pshrmn @saranshkataria - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
|
@eps1lon The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
18f92f6 to
fa49814
Compare
|
CI is timing out. Any issue I can track for progress on this? |
|
@eps1lon The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
OnRenderCallback is to generic
It's actually part of scheduler/tracing
|
@eps1lon The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
|
@eps1lon I haven't seen anything from you in a while and this PR currently has problems that prevent it from being merged. The PR will be closed tomorrow if there aren't new commits to fix the issues. |
|
@Jessidhia Any chance you could take a look? |
|
@eps1lon To keep things tidy, we have to close PRs that aren't mergeable but don't have activity from their author. No worries, though - please open a new PR if you'd like to continue with this change. Thank you! |
Please fill in this template.
npm test.)npm run lint package-name(ortscif notslint.jsonis present).If changing an existing definition:
tslint.jsoncontaining{ "extends": "dtslint/dt.json" }.