Node 9.3 #22593

OwnageIsMagic · 2017-12-31T06:50:49Z

Please fill in this template.

Use a meaningful title for the pull request. Include the name of the package modified.
Test the change in your own code. (Compile and run.)
Follow the advice from the readme.
Run npm run lint package-name (or tsc if no tslint.json is present).
Avoid common mistakes.

If changing an existing definition:

Provide a URL to documentation or source code which provides context for the suggested changes: process: Send signal name to signal handlers nodejs/node#15606
Increase the version number in the header if appropriate.
If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

typescript-bot · 2017-12-31T08:35:07Z

@OwnageIsMagic The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks!

OwnageIsMagic · 2017-12-31T13:06:12Z

Unrelated build error #22569

	Error: /home/travis/build/DefinitelyTyped/DefinitelyTyped/types/koa-webpack/koa-webpack-tests.ts
ERROR: 15:9  expect  TypeScript@next compile error: 
Argument of type '{ compiler: Compiler; config: Configuration; dev: { noInfo: boolean; quiet: boolean; lazy: boolea...' is not assignable to parameter of type 'Options | undefined'.
  Type '{ compiler: Compiler; config: Configuration; dev: { noInfo: boolean; quiet: boolean; lazy: boolea...' is not assignable to type 'Options'.
    Types of property 'dev' are incompatible.
      Type '{ noInfo: boolean; quiet: boolean; lazy: boolean; watchOptions: { aggregateTimeout: number; poll:...' is not assignable to type 'Options | undefined'.
        Object literal may only specify known properties, and 'noInfo' does not exist in type 'Options | undefined'.
    at /home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/dtslint/bin/index.js:74:19
    at Generator.next (<anonymous>)
    at fulfilled (/home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/dtslint/bin/index.js:5:58)
    at <anonymous>

And others.
Also The job exceeded the maximum time limit for jobs, and has been terminated.

Flarna · 2018-01-02T18:53:44Z

The change itself looks fine but this is not part of NodeJs 8. Seems it's time to move current typings to v8 folder and increase version to v9.

OwnageIsMagic · 2018-01-02T20:40:58Z

So, just wait?

Flarna · 2018-01-02T21:12:10Z

I have just seen that the change in NodeJS is already included in 9.3.0 so no need to wait.

As far as I know the creation of v8 folder and increase the version to 9 to allow typings specific for NodeJS 9 is usually done once needed so you could do it in your PR. At least this is my understanding from the history (see #17027).

See also https://github.com/DefinitelyTyped/DefinitelyTyped#i-want-to-update-a-package-to-a-new-major-version

@Andy-MS any objections regarding creation of NodeJs 8 version folder?

ghost · 2018-01-02T21:23:29Z

@Flarna No objections.

OwnageIsMagic · 2018-01-02T22:09:56Z

OwnageIsMagic · 2018-01-03T03:42:31Z

I don't want to checkout repo to my pc to do this

OwnageIsMagic · 2018-01-03T04:34:49Z

@types/node/index.d.ts(1732,12): error TS1024: 'readonly' modifier can only appear on a property declaration or index signature.

OwnageIsMagic · 2018-01-03T04:36:55Z

types/node/index.d.ts

    Console: NodeJS.ConsoleConstructor;
    assert(value: any, message?: string, ...optionalParams: any[]): void;
    dir(obj: any, options?: NodeJS.InspectOptions): void;
+	debug(message?: any, ...optionalParams: any[]): void;


GH inserts tabs instead of spaces :(

OwnageIsMagic · 2018-01-03T04:38:26Z

Error: The latest major version is 8, but a directory v8 exists.

ghost · 2018-01-03T15:21:26Z

Need to update the header in node/index.d.ts to be for version 9.

OwnageIsMagic · 2018-01-03T16:18:52Z

types/node/index.d.ts

 /************************************************
 *                                               *
-*               Node.js v8.5.x API              *
+*               Node.js v9.x.x API              *


@Andy-MS already done that

The actual header is on the first line -- don't know if this box is really necessary.

OwnageIsMagic · 2018-01-03T16:21:09Z

there are two more things to update #22593 (comment)
I have no time today for this, maybe tomorrow if nobody wants to do this

OwnageIsMagic · 2018-01-03T20:42:13Z

Now it says Error: The latest major version is 0, but a directory v0 exists.
Also ci uses
$ node --version
v8.9.4

ghost · 2018-01-03T20:48:53Z

types/node/index.d.ts

@@ -1,4 +1,4 @@
-// Type definitions for Node.js 8.5.x
+// Type definitions for Node.js 9.x.x


// Type definitions for Node.js 9.0

Flarna · 2018-01-03T22:26:27Z

types/node/index.d.ts

        setegid(id: number | string): void;
        getgroups(): number[];
        setgroups(groups: Array<string | number>): void;
+        setUncaughtExceptionCaptureCallback((err: Error) => void | null): void


The name of the parameter is missing.
Additionally I think that this specifies a function which returns void | null and not a Function (err: Error) => void or null.

Flarna · 2018-01-03T22:33:38Z

@types/node/index.d.ts(1732,12): error TS1024: 'readonly' modifier can only appear on a property declaration or index signature.

I think var ==> const should be the way to go here.

Add writableHighWaterMark/readableHighWaterMark to WriteStream/ReadStream fixed setUncaughtExceptionCaptureCallback() Add module.builtinModules change os.EOL to const add writableHighWaterMark to Duplex writableHighWaterMark and readableHighWaterMark are readonly

Flarna · 2018-01-04T00:53:04Z

@OwnageIsMagic I did some changes in this in my fork: https://github.com/Flarna/DefinitelyTyped/tree/patch-2 but somehow I'm not able to create a PR to your branch. Feel free to merge from there.
Still some points open but I have to stop for now.

Patch 2 from Flarna

OwnageIsMagic · 2018-01-05T04:39:37Z

Now it looks good
Do you want I squash it?

OwnageIsMagic · 2018-01-05T04:59:49Z

Why tests not failing on 1860557 18a98ab?
but CI outputs error

Error: /home/travis/build/DefinitelyTyped/DefinitelyTyped/types/node/index.d.ts
ERROR: 3483:5   adjacent-overload-signatures  All 'realpath' signatures should be adjacent
ERROR: 3499:22  no-mergeable-namespace        Mergeable namespace 'realpath' found. Merge its contents with the namespace on line 3474.

ghost · 2018-01-05T16:16:03Z

@OwnageIsMagic types-publisher bug, fixed
Ignore the react errors as they are due to microsoft/TypeScript#21028. And massive, v8-profiler, and webpack-dev-middleware already have fixes out. So just the node errors are relevant.

OwnageIsMagic · 2018-01-05T17:22:20Z

ready to merge!

Flarna · 2018-01-05T20:25:58Z

.travis.yml

 language: node_js
 node_js:
-  - 8
+  - 9


This is the nodejs version used to execute tests so not related to the typings version. Not sure if this is really intended to step to NodeJs 9 here. fyi @Andy-MS

Yeah, this should be done in a separate PR if it is done. I brought it down to 8 when the new release started causing trouble, though it may be fixed now. (#21156)

build was executing fine with node 9

Flarna

Looks fine, just undo the change in .travis.yml

OwnageIsMagic · 2018-01-05T23:23:51Z

Done

* SignalsListener signal name nodejs/node#15606 * created Node 8 folder * Create tsconfig.json * Create tslint.json * Create node-tests.ts * Node 9 * update node header * Tabs to spaces * copy inspector.d.ts to v8 folder * correct path mapping for v8 * disable no-declare-current-package for v8 module * Correct version to 9.3.x Add writableHighWaterMark/readableHighWaterMark to WriteStream/ReadStream fixed setUncaughtExceptionCaptureCallback() Add module.builtinModules change os.EOL to const add writableHighWaterMark to Duplex writableHighWaterMark and readableHighWaterMark are readonly * fs.realpathSync.native and fs.realpath.native * fs.realpath.native tests

SignalsListener signal name

d78a401

nodejs/node#15606

typescript-bot added the Popular package This PR affects a popular package (as counted by NPM download counts). label Dec 31, 2017

typescript-bot added the The Travis CI build failed label Dec 31, 2017

OwnageIsMagic added 5 commits January 3, 2018 06:46

created Node 8 folder

a326f44

Create tsconfig.json

ab0faa7

Create tslint.json

916147e

Create node-tests.ts

c94db46

Node 9

8519db5

OwnageIsMagic changed the title ~~SignalsListener signal name~~ Node 9 Jan 3, 2018

OwnageIsMagic commented Jan 3, 2018

View reviewed changes

typescript-bot added the New Definition This PR creates a new definition package. label Jan 3, 2018

OwnageIsMagic commented Jan 3, 2018

View reviewed changes

update node header

68c3ec4

ghost reviewed Jan 3, 2018

View reviewed changes

Flarna reviewed Jan 3, 2018

View reviewed changes

Tabs to spaces

26effbf

Flarna added 5 commits January 3, 2018 23:42

Merge remote-tracking branch 'upstream/master' into patch-2

7e8069a

copy inspector.d.ts to v8 folder

6b52ae2

correct path mapping for v8

1fceb36

disable no-declare-current-package for v8 module

b4590ba

OwnageIsMagic added 3 commits January 5, 2018 06:58

Merge pull request #1 from Flarna/patch-2

8e2367a

Patch 2 from Flarna

fs.realpathSync.native and fs.realpath.native

9a08c32

Merge branch 'master' into patch-1

2415634

OwnageIsMagic changed the title ~~Node 9~~ Node 9.3 Jan 5, 2018

Flarna reviewed Jan 5, 2018

View reviewed changes

Flarna suggested changes Jan 5, 2018

View reviewed changes

fs.realpath.native tests

5272d01

OwnageIsMagic force-pushed the patch-1 branch from 11e209d to 5272d01 Compare January 5, 2018 23:21

Flarna approved these changes Jan 6, 2018

View reviewed changes

ghost merged commit ea2dc4d into DefinitelyTyped:master Jan 8, 2018

OwnageIsMagic deleted the patch-1 branch February 1, 2018 13:30

This pull request was closed.

		@@ -1,4 +1,4 @@
		// Type definitions for Node.js 8.5.x
		// Type definitions for Node.js 9.x.x

Node 9.3 #22593

Node 9.3 #22593

Uh oh!

Conversation

OwnageIsMagic commented Dec 31, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Dec 31, 2017

Uh oh!

OwnageIsMagic commented Dec 31, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Flarna commented Jan 2, 2018

Uh oh!

OwnageIsMagic commented Jan 2, 2018

Uh oh!

Flarna commented Jan 2, 2018

Uh oh!

ghost commented Jan 2, 2018

Uh oh!

OwnageIsMagic commented Jan 2, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

9.0.0

9.2.0

9.3.0

Uh oh!

OwnageIsMagic commented Jan 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OwnageIsMagic commented Jan 3, 2018

Uh oh!

OwnageIsMagic Jan 3, 2018

Choose a reason for hiding this comment

Uh oh!

OwnageIsMagic commented Jan 3, 2018

Uh oh!

ghost commented Jan 3, 2018

Uh oh!

OwnageIsMagic Jan 3, 2018

Choose a reason for hiding this comment

Uh oh!

ghost Jan 3, 2018

Choose a reason for hiding this comment

Uh oh!

OwnageIsMagic commented Jan 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OwnageIsMagic commented Jan 3, 2018

Uh oh!

ghost Jan 3, 2018 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Flarna Jan 3, 2018

Choose a reason for hiding this comment

Uh oh!

Flarna commented Jan 3, 2018

Uh oh!

Flarna commented Jan 4, 2018

Uh oh!

OwnageIsMagic commented Jan 5, 2018

Uh oh!

OwnageIsMagic commented Jan 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Jan 5, 2018 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OwnageIsMagic commented Jan 5, 2018

Uh oh!

Flarna Jan 5, 2018

Choose a reason for hiding this comment

Uh oh!

ghost Jan 5, 2018

Choose a reason for hiding this comment

Uh oh!

OwnageIsMagic Jan 5, 2018

Choose a reason for hiding this comment

Uh oh!

Flarna left a comment

OwnageIsMagic commented Dec 31, 2017 •

edited

Loading

OwnageIsMagic commented Dec 31, 2017 •

edited

Loading

OwnageIsMagic commented Jan 2, 2018 •

edited

Loading

OwnageIsMagic commented Jan 3, 2018 •

edited

Loading

OwnageIsMagic commented Jan 3, 2018 •

edited

Loading

ghost Jan 3, 2018 •

edited by ghost

Loading

OwnageIsMagic commented Jan 5, 2018 •

edited

Loading

ghost commented Jan 5, 2018 •

edited by ghost

Loading