Skip to content

[adone] fix builderror because of incompatible definition of duplex.end() #22569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mhegazy merged 3 commits into from
Jan 2, 2018
Merged

[adone] fix builderror because of incompatible definition of duplex.end() #22569

mhegazy merged 3 commits into from
Jan 2, 2018

Conversation

@Flarna
Copy link
Contributor

@Flarna Flarna commented Dec 29, 2017 •
edited
Loading

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).
  • Provide a URL to documentation or source code which provides context for the suggested changes: https://nodejs.org/dist/latest-v9.x/docs/api/stream.html#stream_writable_end_chunk_encoding_callback
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

I got a build error in another PR because end() defined in adone doesn't match to end() defined in nodejs duplex stream which is used as base class:

Error: /home/travis/build/DefinitelyTyped/DefinitelyTyped/types/adone/glosses/collections.d.ts
ERROR: 1630:15  expect  TypeScript@next compile error: 
Class 'BufferList' incorrectly extends base class 'Duplex'.
  Types of property 'end' are incompatible.
    Type '(chunk?: Buffer | undefined) => void' is not assignable to type '{ (cb?: Function | undefined): void; (chunk: any, cb?: Function | undefined): void; (chunk: any, ...'.
      Types of parameters 'chunk' and 'cb' are incompatible.
        Type 'Function | undefined' is not assignable to type 'Buffer | undefined'.
          Type 'Function' is not assignable to type 'Buffer | undefined'.
            Type 'Function' is not assignable to type 'Buffer'.
              Property 'write' is missing in type 'Function'.

Most likely caused by #22077.

@typescript-bot
Copy link
Contributor

typescript-bot commented Dec 29, 2017

@Flarna The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks!

@OwnageIsMagic OwnageIsMagic mentioned this pull request Dec 31, 2017
Merged
8 tasks
@Flarna
Copy link
Contributor Author

Flarna commented Jan 2, 2018

ping @s0m3on3 @maxveres

@typescript-bot
Copy link
Contributor

typescript-bot commented Jan 2, 2018

A definition author has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@mhegazy mhegazy merged commit 1d1c42f into DefinitelyTyped:master Jan 2, 2018
@Flarna Flarna deleted the adone_fix_end branch January 2, 2018 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@s0m3on3 s0m3on3 s0m3on3 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Flarna @typescript-bot @s0m3on3 @mhegazy