Skip to content

[node] Support passing callback-only in writable.end() #22077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aozgaa merged 1 commit into from
Dec 19, 2017
Merged

[node] Support passing callback-only in writable.end() #22077

aozgaa merged 1 commit into from
Dec 19, 2017

Conversation

@Zarel
Copy link
Contributor

@Zarel Zarel commented Dec 10, 2017 •
edited
Loading

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

In case it's unclear, this is intended to support code of the form

writable.end(callback);

This API supports leaving off the chunk argument in every version of the API I've looked at that supports the callback function at all, from

https://nodejs.org/docs/latest-v0.10.x/api/stream.html#stream_writable_end_chunk_encoding_callback

to

https://nodejs.org/dist/latest-v9.x/docs/api/stream.html#stream_writable_end_chunk_encoding_callback

@dt-bot
Copy link
Member

dt-bot commented Dec 10, 2017

types/node/index.d.ts

to authors (@DefinitelyTyped/DefinitelyTyped @parambirs @tellnes @WilcoBakker @octo-sniffle @smac89 @Flarna @mwiktorczyk @wwwy3y3 @DeividasBakanas @kjin @alvis @OliverJAsh @eps1lon @Hannes-Magnusson-CK Microsoft TypeScript (account can't be detected)). Could you review this PR?
👍 or 👎?

types/node/v0/index.d.ts

to authors (@DefinitelyTyped/DefinitelyTyped Microsoft TypeScript (account can't be detected)). Could you review this PR?
👍 or 👎?

types/node/v4/index.d.ts

to authors (@DefinitelyTyped/DefinitelyTyped @eps1lon Microsoft TypeScript (account can't be detected)). Could you review this PR?
👍 or 👎?

types/node/v6/index.d.ts

to authors (@DefinitelyTyped/DefinitelyTyped @WilcoBakker @inlined @eps1lon Microsoft TypeScript (account can't be detected)). Could you review this PR?
👍 or 👎?

types/node/v7/index.d.ts

to authors (@DefinitelyTyped/DefinitelyTyped @parambirs @tellnes @WilcoBakker @eps1lon Microsoft TypeScript (account can't be detected)). Could you review this PR?
👍 or 👎?

@typescript-bot typescript-bot added the Popular package This PR affects a popular package (as counted by NPM download counts). label Dec 10, 2017
@Flarna
Copy link
Contributor

Flarna commented Dec 10, 2017

Shouldn't the class Writable and class Duplex in stream:internal adapted also?

@typescript-bot
Copy link
Contributor

typescript-bot commented Dec 15, 2017 •
edited
Loading

A definition author has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@typescript-bot typescript-bot added the Unmerged The author did not merge the PR when it was ready. label Dec 15, 2017
@Zarel
Copy link
Contributor Author

Zarel commented Dec 15, 2017

@Flarna Done.

@typescript-bot typescript-bot removed the Unmerged The author did not merge the PR when it was ready. label Dec 15, 2017
@typescript-bot typescript-bot added Author Approved Other Approved This PR was reviewed and signed-off by a community member. and removed Other Approved This PR was reviewed and signed-off by a community member. labels Dec 15, 2017
@aozgaa aozgaa merged commit b6b7d53 into DefinitelyTyped:master Dec 19, 2017
This was referenced Dec 29, 2017
Closed
Merged
KSXGitHub pushed a commit to KSXGitHub/DefinitelyTyped that referenced this pull request May 12, 2018
@aozgaa
Merge pull request DefinitelyTyped#22077 from Zarel/writable-end
abc333f 
[node] Support passing callback-only in writable.end()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Flarna Flarna Flarna approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Popular package This PR affects a popular package (as counted by NPM download counts).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Zarel @dt-bot @Flarna @typescript-bot @aozgaa