Skip to content

Fix RMV tryEnqueueReplicatedDDL shutdown crash again#78873

Merged
al13n321 merged 3 commits intomasterfrom
rmvs
Sep 27, 2025
Merged

Fix RMV tryEnqueueReplicatedDDL shutdown crash again#78873
al13n321 merged 3 commits intomasterfrom
rmvs

Conversation

@al13n321
Copy link
Copy Markdown
Member

@al13n321 al13n321 commented Apr 9, 2025

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

#73323 made server shutdown wait for refreshable MVs to stop before destroying databases. But if RMVs failed to stop within a timeout, it would say "oh well" and proceed to destroying databases anyway. Then it sometimes crashed because of that. This PR makes the server forcefully shut down in this case, just like when it fails to close client connections within the same timeout.

(Not sure what I was thinking - maybe that it's better to proceed with shutdown and risk crashing than to forcefully shutdown immediately. But it's probably not better, we get alerts.)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Apr 9, 2025

Workflow [PR], commit [eb5c812]

@clickhouse-gh clickhouse-gh bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label Apr 9, 2025
@al13n321 al13n321 added pr-must-backport Pull request should be backported intentionally. Use this label with great care! and removed pr-not-for-changelog This PR should not be mentioned in the changelog labels Apr 9, 2025
@antonio2368 antonio2368 self-assigned this Apr 9, 2025
@al13n321
Copy link
Copy Markdown
Member Author

al13n321 commented Apr 16, 2025

The remaining test failures are unrelated.

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented May 20, 2025

Dear @antonio2368, this PR hasn't been updated for a while. You will be unassigned. Will you continue working on it? If so, please feel free to reassign yourself.

@Algunenano
Copy link
Copy Markdown
Member

Algunenano commented Jul 10, 2025

Do we need this @al13n321 ?

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Jul 10, 2025 •
edited
Loading

Workflow [PR], commit [6c07474]

@clickhouse-gh clickhouse-gh bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jul 10, 2025
@al13n321 al13n321 enabled auto-merge September 27, 2025 01:28
@al13n321 al13n321 added this pull request to the merge queue Sep 27, 2025
Merged via the queue into master with commit a7af407 Sep 27, 2025
118 of 123 checks passed
@al13n321 al13n321 deleted the rmvs branch September 27, 2025 08:00
@robot-ch-test-poll robot-ch-test-poll added pr-backports-created-cloud deprecated label, NOOP pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR labels Sep 27, 2025
@robot-ch-test-poll robot-ch-test-poll mentioned this pull request Sep 27, 2025
Merged
robot-ch-test-poll added a commit that referenced this pull request Sep 27, 2025
@robot-ch-test-poll
Merge pull request #87746 from ClickHouse/cherrypick/25.3/78873
6a3c099 
Cherry pick #78873 to 25.3: Fix RMV tryEnqueueReplicatedDDL shutdown crash again
robot-clickhouse added a commit that referenced this pull request Sep 27, 2025
@robot-clickhouse
Backport #78873 to 25.3: Fix RMV tryEnqueueReplicatedDDL shutdown cra…
adc28cf 
…sh again
This was referenced Sep 27, 2025
Merged
Merged
robot-ch-test-poll added a commit that referenced this pull request Sep 27, 2025
@robot-ch-test-poll
Merge pull request #87748 from ClickHouse/cherrypick/25.7/78873
91c6ce6 
Cherry pick #78873 to 25.7: Fix RMV tryEnqueueReplicatedDDL shutdown crash again
robot-clickhouse added a commit that referenced this pull request Sep 27, 2025
@robot-clickhouse
Backport #78873 to 25.7: Fix RMV tryEnqueueReplicatedDDL shutdown cra…
7d91b9e 
…sh again
@robot-ch-test-poll robot-ch-test-poll mentioned this pull request Sep 27, 2025
Merged
@robot-ch-test-poll robot-ch-test-poll mentioned this pull request Sep 27, 2025
Merged
robot-ch-test-poll added a commit that referenced this pull request Sep 27, 2025
@robot-ch-test-poll
Merge pull request #87750 from ClickHouse/cherrypick/25.8/78873
b96ba10 
Cherry pick #78873 to 25.8: Fix RMV tryEnqueueReplicatedDDL shutdown crash again
robot-clickhouse added a commit that referenced this pull request Sep 27, 2025
@robot-clickhouse
Backport #78873 to 25.8: Fix RMV tryEnqueueReplicatedDDL shutdown cra…
7e68db4 
…sh again
This was referenced Sep 27, 2025
Merged
Merged
robot-ch-test-poll added a commit that referenced this pull request Sep 27, 2025
@robot-ch-test-poll
Merge pull request #87752 from ClickHouse/cherrypick/25.9/78873
e9806df 
Cherry pick #78873 to 25.9: Fix RMV tryEnqueueReplicatedDDL shutdown crash again
robot-clickhouse added a commit that referenced this pull request Sep 27, 2025
@robot-clickhouse
Backport #78873 to 25.9: Fix RMV tryEnqueueReplicatedDDL shutdown cra…
65043b6 
…sh again
@robot-ch-test-poll robot-ch-test-poll mentioned this pull request Sep 27, 2025
Merged
@robot-ch-test-poll4 robot-ch-test-poll4 added pr-synced-to-cloud The PR is synced to the cloud repo pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore labels Sep 27, 2025
clickhouse-gh bot added a commit that referenced this pull request Sep 27, 2025
@clickhouse-gh
Merge pull request #87749 from ClickHouse/backport/25.7/78873
f095d71 
Backport #78873 to 25.7: Fix RMV tryEnqueueReplicatedDDL shutdown crash again
clickhouse-gh bot added a commit that referenced this pull request Sep 27, 2025
@clickhouse-gh
Merge pull request #87751 from ClickHouse/backport/25.8/78873
b91dbd1 
Backport #78873 to 25.8: Fix RMV tryEnqueueReplicatedDDL shutdown crash again
al13n321 pushed a commit that referenced this pull request Sep 27, 2025
@robot-ch-test-poll @robot-clickhouse
Backport #78873 to 25.9: Fix RMV tryEnqueueReplicatedDDL shutdown cra…
fa7e81a 
…sh again (#87753)

Co-authored-by: robot-clickhouse <robot-clickhouse@users.noreply.github.com>
al13n321 pushed a commit that referenced this pull request Sep 27, 2025
@robot-ch-test-poll @robot-clickhouse
Backport #78873 to 25.3: Fix RMV tryEnqueueReplicatedDDL shutdown cra…
5b1d500 
…sh again (#87747)

Co-authored-by: robot-clickhouse <robot-clickhouse@users.noreply.github.com>
azat added a commit that referenced this pull request Sep 29, 2025
@azat
Merge remote-tracking branch 'u/25.9' into backport/25.9/87584
91b3e43 
* u/25.9:
  Backport #87614 to 25.9: Small fixes for jemalloc profiler
  Backport #84020 to 25.9: Fix geoparquet types breaking client-server protocol (#87744)
  Backport #78873 to 25.9: Fix RMV tryEnqueueReplicatedDDL shutdown crash again (#87753)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonio2368 antonio2368 antonio2368 approved these changes

Assignees

No one assigned

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@al13n321 @Algunenano @antonio2368 @robot-ch-test-poll @robot-ch-test-poll4