Conversation
1 task
Contributor
scanhex12
approved these changes
Sep 23, 2025
robot-clickhouse-ci-2
added a commit
that referenced
this pull request
Sep 27, 2025
Cherry pick #84020 to 25.7: Fix geoparquet types breaking client-server protocol
robot-clickhouse
added a commit
that referenced
this pull request
Sep 27, 2025
This was referenced Sep 27, 2025
robot-clickhouse-ci-2
added a commit
that referenced
this pull request
Sep 27, 2025
Cherry pick #84020 to 25.8: Fix geoparquet types breaking client-server protocol
robot-clickhouse
added a commit
that referenced
this pull request
Sep 27, 2025
This was referenced Sep 27, 2025
robot-clickhouse-ci-2
added a commit
that referenced
this pull request
Sep 27, 2025
Cherry pick #84020 to 25.9: Fix geoparquet types breaking client-server protocol
robot-clickhouse
added a commit
that referenced
this pull request
Sep 27, 2025
clickhouse-gh bot
added a commit
that referenced
this pull request
Sep 27, 2025
Backport #84020 to 25.7: Fix geoparquet types breaking client-server protocol
clickhouse-gh bot
added a commit
that referenced
this pull request
Sep 27, 2025
Backport #84020 to 25.8: Fix geoparquet types breaking client-server protocol
al13n321
pushed a commit
that referenced
this pull request
Sep 27, 2025
…protocol (#87744) Co-authored-by: robot-clickhouse <robot-clickhouse@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Fixed GeoParquet causing client protocol errors.
getNamesAndRecursivelyNullableTypestook typePoint, akaTuple(Float64, Float64), turned it intoTuple(Nullable(Float64), Nullable(Float64)), and named the resulting type "Point" again (!).Tuple(Nullable(Float64), Nullable(Float64))).DataTypeFactory::get("Point")to learn that "Point" meansTuple(Float64, Float64), and proceeds to deserialize column data as non-nullable. So it outputs garbage data and some error like "Unknown packet 0 from server".This PR removes the code that reassigns custom name to a different type, and adds code to avoid making parts of named types nullable. So
getNamesAndRecursivelyNullableTypesleavesPointunchanged, non-nullable.(Same for the other geo types: LineString, Polygon, MultiLineString, MultiPolygon.)