Skip to content

Fix refreshable MV crash on shutdown#73323

Merged
alesapin merged 9 commits intomasterfrom
rmvjoin
Jan 20, 2025
Merged

Fix refreshable MV crash on shutdown#73323
alesapin merged 9 commits intomasterfrom
rmvjoin

Conversation

@al13n321
Copy link
Copy Markdown
Member

@al13n321 al13n321 commented Dec 14, 2024

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix rare crash in refreshable materialized view during server shutdown.

If a refresh tries to rename a table after DatabaseCatalog was shut down, InterpreterRenameQuery segfaults. For regular queries this is avoided by stopping TCP/HTTP/etc servers and waiting/killing all running queries before the DatabaseCatalog shutdown. This PR does the ~same for MV refreshes.

@al13n321 al13n321 marked this pull request as ready for review December 14, 2024 02:47
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-bugfix Pull request with bugfix, not backported by default label Dec 14, 2024
@robot-clickhouse-ci-1
Copy link
Copy Markdown
Contributor

robot-clickhouse-ci-1 commented Dec 14, 2024 •
edited by robot-clickhouse-ci-2
Loading

This is an automated comment for commit df02925 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
Bugfix validationChecks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
BuzzHouse (asan)There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
BuzzHouse (debug)There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
BuzzHouse (msan)There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
BuzzHouse (tsan)There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
BuzzHouse (ubsan)There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns ClickBench with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@antonio2368 antonio2368 self-assigned this Dec 16, 2024
@Algunenano Algunenano added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Dec 16, 2024
antonio2368
antonio2368 reviewed Dec 17, 2024
View reviewed changes
@al13n321
Copy link
Copy Markdown
Member Author

al13n321 commented Dec 20, 2024

The tests had RMT tables stuck with errors Not found address of host: ip-172-31-91-226.ec2.internal. Test infra problem?

@alexey-milovidov
Copy link
Copy Markdown
Member

alexey-milovidov commented Dec 31, 2024

@al13n321, tests have failed.

@alesapin alesapin added this pull request to the merge queue Jan 20, 2025
Merged via the queue into master with commit b6cc1c0 Jan 20, 2025
@alesapin alesapin deleted the rmvjoin branch January 20, 2025 17:36
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jan 20, 2025
This was referenced Jan 20, 2025
Closed
Closed
Merged
Merged
robot-clickhouse-ci-1 added a commit that referenced this pull request Jan 20, 2025
@robot-clickhouse-ci-1
Merge pull request #74820 from ClickHouse/cherrypick/24.11/73323
584ab8d 
Cherry pick #73323 to 24.11: Fix refreshable MV crash on shutdown
robot-clickhouse added a commit that referenced this pull request Jan 20, 2025
@robot-clickhouse
Backport #73323 to 24.11: Fix refreshable MV crash on shutdown
78eb7e2
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 mentioned this pull request Jan 20, 2025
Merged
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 mentioned this pull request Jan 20, 2025
Merged
robot-clickhouse-ci-1 added a commit that referenced this pull request Jan 20, 2025
@robot-clickhouse-ci-1
Merge pull request #74822 from ClickHouse/cherrypick/24.12/73323
b15192d 
Cherry pick #73323 to 24.12: Fix refreshable MV crash on shutdown
robot-clickhouse added a commit that referenced this pull request Jan 20, 2025
@robot-clickhouse
Backport #73323 to 24.12: Fix refreshable MV crash on shutdown
a7790a8
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 mentioned this pull request Jan 20, 2025
Merged
al13n321 added a commit that referenced this pull request Jan 21, 2025
@robot-clickhouse-ci-1 @al13n321
@robot-clickhouse @alesapin
Cherry pick #73323 to 24.10: Fix refreshable MV crash on shutdown (#7…
0468928 
…4819)

* Fix refreshable MV crash on shutdown

* Automatic style fix

* Fix mutex order

* Probably fix the flaky test

* style

---------

Co-authored-by: Michael Kolupaev <michael.kolupaev@clickhouse.com>
Co-authored-by: robot-clickhouse <robot-clickhouse@users.noreply.github.com>
Co-authored-by: alesapin <alesapin@gmail.com>
al13n321 pushed a commit that referenced this pull request Jan 21, 2025
@robot-clickhouse-ci-1 @robot-clickhouse
Backport #73323 to 24.12: Fix refreshable MV crash on shutdown (#74823)
0385be1 
Co-authored-by: robot-clickhouse <robot-clickhouse@users.noreply.github.com>
al13n321 pushed a commit that referenced this pull request Jan 21, 2025
@robot-clickhouse-ci-1 @robot-clickhouse
Backport #73323 to 24.11: Fix refreshable MV crash on shutdown (#74821)
c7443eb 
Co-authored-by: robot-clickhouse <robot-clickhouse@users.noreply.github.com>
robot-clickhouse added a commit that referenced this pull request Jan 21, 2025
@robot-clickhouse
Backport #73323 to 24.10: Fix refreshable MV crash on shutdown
5c8021d
@robot-ch-test-poll1 robot-ch-test-poll1 mentioned this pull request Jan 21, 2025
Merged
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jan 21, 2025
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-backports-created-cloud deprecated label, NOOP label Jan 21, 2025
robot-clickhouse-ci-1 added a commit that referenced this pull request Jan 28, 2025
@robot-clickhouse-ci-1
Merge pull request #74881 from ClickHouse/backport/24.10/73323
8bc6c4b 
Backport #73323 to 24.10: Fix refreshable MV crash on shutdown
@al13n321 al13n321 mentioned this pull request Apr 9, 2025
Merged
@robot-clickhouse robot-clickhouse added the pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR label Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonio2368 antonio2368 antonio2368 approved these changes

Assignees

@antonio2368 antonio2368

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.