Skip to content

Revert "Revert "Revert "Revert "make d-tor Finalizer more obvious""""#72898

Merged
CheSema merged 7 commits intomasterfrom
revert-72882-revert-72654-revert-72642-revert-72395-chesema-dtor-Finalizer
Dec 12, 2024
Merged

Revert "Revert "Revert "Revert "make d-tor Finalizer more obvious""""#72898
CheSema merged 7 commits intomasterfrom
revert-72882-revert-72654-revert-72642-revert-72395-chesema-dtor-Finalizer

Conversation

@CheSema
Copy link
Copy Markdown
Member

@CheSema CheSema commented Dec 6, 2024 •
edited
Loading

Reverts #72882
It just 3 attempt. The first is #72395

Fixes #73015

@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Dec 6, 2024
@robot-ch-test-poll1
Copy link
Copy Markdown
Contributor

robot-ch-test-poll1 commented Dec 6, 2024 •
edited by robot-clickhouse
Loading

This is an automated comment for commit 673276a with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure
Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@CheSema CheSema mentioned this pull request Dec 10, 2024
Closed
@CheSema CheSema marked this pull request as ready for review December 10, 2024 15:26
@CheSema CheSema mentioned this pull request Dec 10, 2024
Closed
19 tasks
@Michicosun Michicosun self-assigned this Dec 10, 2024
Michicosun
Michicosun requested changes Dec 11, 2024
View reviewed changes
Michicosun
Michicosun approved these changes Dec 12, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Michicosun Michicosun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

test_storage_s3_queue/test.py::test_alter_settings - seems to be flaky in master.
Stress test (msan) - looks like #72557

@CheSema CheSema added this pull request to the merge queue Dec 12, 2024
Merged via the queue into master with commit 8fd1571 Dec 12, 2024
@CheSema CheSema deleted the revert-72882-revert-72654-revert-72642-revert-72395-chesema-dtor-Finalizer branch December 12, 2024 15:34
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Dec 12, 2024
@CheSema CheSema added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Dec 12, 2024
This was referenced Dec 12, 2024
Closed
Closed
Closed
Closed
Merged
robot-clickhouse added a commit that referenced this pull request Dec 12, 2024
@robot-clickhouse
Merge pull request #73236 from ClickHouse/cherrypick/24.11/72898
169ec9d 
Cherry pick #72898 to 24.11: Revert "Revert "Revert "Revert "make d-tor Finalizer more obvious""""
robot-clickhouse added a commit that referenced this pull request Dec 12, 2024
@robot-clickhouse
Backport #72898 to 24.11: Revert "Revert "Revert "Revert "make d-tor …
eddcede 
…Finalizer more obvious""""
This was referenced Dec 12, 2024
Merged
Merged
robot-clickhouse added a commit that referenced this pull request Dec 12, 2024
@robot-clickhouse
Merge pull request #73238 from ClickHouse/cherrypick/24.12/72898
8ed4ddb 
Cherry pick #72898 to 24.12: Revert "Revert "Revert "Revert "make d-tor Finalizer more obvious""""
robot-clickhouse added a commit that referenced this pull request Dec 12, 2024
@robot-clickhouse
Backport #72898 to 24.12: Revert "Revert "Revert "Revert "make d-tor …
a4fa4ff 
…Finalizer more obvious""""
@robot-clickhouse robot-clickhouse mentioned this pull request Dec 12, 2024
Merged
robot-ch-test-poll3 added a commit that referenced this pull request Dec 12, 2024
@robot-ch-test-poll3
Merge pull request #73239 from ClickHouse/backport/24.12/72898
1a23aad 
Backport #72898 to 24.12: Revert "Revert "Revert "Revert "make d-tor Finalizer more obvious""""
robot-clickhouse-ci-2 added a commit that referenced this pull request Dec 12, 2024
@robot-clickhouse-ci-2
Merge pull request #73237 from ClickHouse/backport/24.11/72898
6964bcf 
Backport #72898 to 24.11: Revert "Revert "Revert "Revert "make d-tor Finalizer more obvious""""
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-backports-created-cloud deprecated label, NOOP label Dec 13, 2024
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Dec 13, 2024
@robot-clickhouse robot-clickhouse added the pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR label Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Michicosun Michicosun Michicosun approved these changes

Assignees

@Michicosun Michicosun

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

materialized_views_ignore_errors does the wrong thing

7 participants

@CheSema @robot-ch-test-poll1 @Michicosun @robot-clickhouse @robot-ch-test-poll2 @robot-ch-test-poll3 @robot-clickhouse-ci-2