Skip to content

make d-tor Finalizer more obvious#72395

Merged
CheSema merged 2 commits intomasterfrom
chesema-dtor-Finalizer
Nov 29, 2024
Merged

make d-tor Finalizer more obvious#72395
CheSema merged 2 commits intomasterfrom
chesema-dtor-Finalizer

Conversation

@CheSema
Copy link
Copy Markdown
Member

@CheSema CheSema commented Nov 25, 2024

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

...

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug
  • Run only fuzzers related jobs (libFuzzer fuzzers, AST fuzzers, etc.)
  • Exclude: AST fuzzers
  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Nov 25, 2024
@robot-ch-test-poll3
Copy link
Copy Markdown
Contributor

robot-ch-test-poll3 commented Nov 25, 2024 •
edited
Loading

This is an automated comment for commit a6cf336 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@SmitaRKulkarni SmitaRKulkarni self-assigned this Nov 26, 2024
@CheSema
Copy link
Copy Markdown
Member Author

CheSema commented Nov 26, 2024 •
edited
Loading

data race in Stateless tests (tsan, s3 storage) [3/3]
#72442
#72392

@CheSema CheSema added this pull request to the merge queue Nov 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 27, 2024
@CheSema CheSema added this pull request to the merge queue Nov 29, 2024
Merged via the queue into master with commit 54424ad Nov 29, 2024
@CheSema CheSema deleted the chesema-dtor-Finalizer branch November 29, 2024 08:36
@robot-clickhouse robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label Nov 29, 2024
@antonio2368
Copy link
Copy Markdown
Member

antonio2368 commented Nov 29, 2024

I got couple of failures because of the check added here
https://s3.amazonaws.com/clickhouse-test-reports/72584/88db1fe07fb56c0ade5a8cbfad246e8ac791f9bb/stateless_tests__tsan__s3_storage__[3_3]/run.log
I have a feeling it fails too often.

@CheSema CheSema mentioned this pull request Nov 29, 2024
Merged
@CheSema
Copy link
Copy Markdown
Member Author

CheSema commented Nov 29, 2024 •
edited
Loading

I got couple of failures because of the check added here https://s3.amazonaws.com/clickhouse-test-reports/72584/88db1fe07fb56c0ade5a8cbfad246e8ac791f9bb/stateless_tests__tsan__s3_storage__[3_3]/run.log I have a feeling it fails too often.

You are right here!
#72642

I have made a mistake. We could destroy pipeline when we unwind the stack. It happens without calling cancel method on pipeline.
I will make a new PR with this change.

The fixed PR #72654

@CheSema CheSema mentioned this pull request Dec 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SmitaRKulkarni SmitaRKulkarni SmitaRKulkarni approved these changes

Assignees

@SmitaRKulkarni SmitaRKulkarni

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@CheSema @robot-ch-test-poll3 @antonio2368 @SmitaRKulkarni @robot-clickhouse @robot-clickhouse-ci-2