Skip to content

fix data race#72442

Closed
CheSema wants to merge 1 commit intomasterfrom
chesema-fix-data-race
Closed

fix data race#72442
CheSema wants to merge 1 commit intomasterfrom
chesema-fix-data-race

Conversation

@CheSema
Copy link
Copy Markdown
Member

@CheSema CheSema commented Nov 26, 2024

Here is a bug
5abca62#diff-3e3e5e7efdaacec3b27fd37625680ac5cffcbddd204fb52c85304c052829d463L155

Data race
https://s3.amazonaws.com/clickhouse-test-reports/72395/5cbc711ff40e47507b8a2ee78a6be3eba12d63f9/stateless_tests__tsan__s3_storage__[3_3]/stderr.log

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

...

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs

  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug

  • Run only fuzzers related jobs (libFuzzer fuzzers, AST fuzzers, etc.)
  • Exclude: AST fuzzers

  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@CheSema CheSema mentioned this pull request Nov 26, 2024
21 tasks
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Nov 26, 2024
@Michicosun Michicosun self-assigned this Nov 26, 2024
@robot-ch-test-poll4
Copy link
Copy Markdown
Contributor

robot-ch-test-poll4 commented Nov 26, 2024

This is an automated comment for commit b7bd996 with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success

@CheSema
Copy link
Copy Markdown
Member Author

CheSema commented Nov 26, 2024

I'm wrong here

using RecursiveMutableColumnCallback = std::function<void(IColumn &)>;
virtual void forEachSubcolumnRecursively(RecursiveMutableColumnCallback) {}
/// Default implementation calls the mutable overload using const_cast.
using RecursiveColumnCallback = std::function<void(const IColumn &)>;
virtual void forEachSubcolumnRecursively(RecursiveColumnCallback) const;
/// Columns have equal structure.

We choose between IColumn & and const IColumn &. It is safe to always choose const IColumn &,

@CheSema CheSema closed this Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants