Skip to content

Fix ListObjects in azure blob storage#65691

Merged
CurtizJ merged 14 commits intoClickHouse:masterfrom
CurtizJ:fix-azure-list
Dec 3, 2024
Merged

Fix ListObjects in azure blob storage#65691
CurtizJ merged 14 commits intoClickHouse:masterfrom
CurtizJ:fix-azure-list

Conversation

@CurtizJ
Copy link
Copy Markdown
Member

@CurtizJ CurtizJ commented Jun 25, 2024 •
edited by maxknv
Loading

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Depends on #63636.

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: Azure
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug
  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@robot-ch-test-poll robot-ch-test-poll added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jun 25, 2024
@robot-ch-test-poll
Copy link
Copy Markdown
Contributor

robot-ch-test-poll commented Jun 25, 2024 •
edited by robot-ch-test-poll3
Loading

This is an automated comment for commit 5ad8c8b with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure
Successful checks
Check nameDescriptionStatus
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success

@kssenii kssenii self-assigned this Jun 26, 2024
@CurtizJ CurtizJ marked this pull request as ready for review July 9, 2024 10:17
@alexey-milovidov
Copy link
Copy Markdown
Member

alexey-milovidov commented Jul 17, 2024

@CurtizJ, tests for Azure have failed.

@CurtizJ CurtizJ marked this pull request as draft August 8, 2024 01:50
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Oct 8, 2024

Dear @CurtizJ, this PR hasn't been updated for a while. Will you continue working on it? If not, please close it. Otherwise, ignore this message.

@nikitamikhaylov nikitamikhaylov marked this pull request as ready for review November 25, 2024 22:18
@CurtizJ
Copy link
Copy Markdown
Member Author

CurtizJ commented Dec 3, 2024

It looks like stress tests with azure are broken in master.

@CurtizJ CurtizJ added this pull request to the merge queue Dec 3, 2024
Merged via the queue into ClickHouse:master with commit 82a80db Dec 3, 2024
@CurtizJ CurtizJ deleted the fix-azure-list branch December 3, 2024 11:25
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Dec 3, 2024
primeroz
primeroz reviewed Dec 3, 2024
View reviewed changes
tests/queries/0_stateless/03008_azure_plain_rewritable.sh
name = '${container}',
path='/var/lib/clickhouse/disks/${container}/tables',
container_name = '${container}',
endpoint = 'http://localhost:10000/devstoreaccount1/${container}/plain-tables',
Copy link
Copy Markdown
Member

@primeroz primeroz Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in production cloud we define the endpoint with a / at the end, this is i think causing an exception

https://clickhouse-inc.slack.com/archives/C02F2LML5UG/p1733233064721519?thread_ts=1719249147.971119&cid=C02F2LML5UG

baibaichen added a commit to Kyligence/gluten that referenced this pull request Dec 4, 2024
@baibaichen
Fix Build due to ClickHouse/ClickHouse#65691
4941541
baibaichen added a commit to apache/gluten that referenced this pull request Dec 4, 2024
@kyligence-git @baibaichen
[GLUTEN-1632][CH]Daily Update Clickhouse Version (20241204) (#8135)
6dd65c0 
* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20241204)

* Fix Build due to ClickHouse/ClickHouse#72715

* Fix Build due to ClickHouse/ClickHouse#65691

* Fix Build due to ClickHouse/ClickHouse#72722

* Fix gtest due to #8052

* Fix benchmark due to ClickHouse/ClickHouse#72460

* Add SPARK_DIR_NAME for fixing unstable ut

---------

Co-authored-by: kyligence-git <gluten@kyligence.io>
Co-authored-by: Chang Chen <baibaichen@gmail.com>
@jkartseva jkartseva mentioned this pull request Dec 5, 2024
Merged
21 tasks
@davenger davenger mentioned this pull request Feb 25, 2026
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kssenii kssenii kssenii approved these changes

+1 more reviewer

@primeroz primeroz primeroz left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@kssenii kssenii

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@CurtizJ @robot-ch-test-poll @alexey-milovidov @primeroz @kssenii @robot-clickhouse-ci-1 @nikitamikhaylov @Felixoid