Skip to content

Resubmit #68682, att2#72460

Merged
vdimir merged 9 commits intomasterfrom
vdimir/join_select_inner_table
Nov 30, 2024
Merged

Resubmit #68682, att2#72460
vdimir merged 9 commits intomasterfrom
vdimir/join_select_inner_table

Conversation

@vdimir
Copy link
Copy Markdown
Member

@vdimir vdimir commented Nov 26, 2024

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

...

@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Nov 26, 2024
@robot-ch-test-poll2
Copy link
Copy Markdown
Contributor

robot-ch-test-poll2 commented Nov 26, 2024 •
edited by robot-ch-test-poll4
Loading

This is an automated comment for commit 0a5bc24 with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@vdimir
Copy link
Copy Markdown
Member Author

vdimir commented Nov 27, 2024

Integration tests (aarch64) [4/6] — fail: 1, passed: 472 Details

#72536

Integration tests (tsan) [2/6] — fail: 2, passed: 537 Details

#71533

Stateless tests (aarch64, asan) [1/2] — fail: 1, passed: 3572, skipped: 67 Details

#72535

Stress test (debug) — Killed by signal (in clickhouse-server.log) Details

#67184

@vdimir
Copy link
Copy Markdown
Member Author

vdimir commented Nov 28, 2024

Stateless tests (tsan, s3 storage) [3/3] — Server died, fail: 11, passed: 2024, skipped: 55 Details

Fixing in #72586

@vdimir vdimir enabled auto-merge November 28, 2024 16:48
@vdimir vdimir force-pushed the vdimir/join_select_inner_table branch from 9beece5 to 0a5bc24 Compare November 29, 2024 15:50
@vdimir vdimir added this pull request to the merge queue Nov 30, 2024
Merged via the queue into master with commit 0589253 Nov 30, 2024
@vdimir vdimir deleted the vdimir/join_select_inner_table branch November 30, 2024 01:32
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Nov 30, 2024
baibaichen added a commit to Kyligence/gluten that referenced this pull request Nov 30, 2024
@baibaichen
Fix build due to ClickHouse/ClickHouse#72460
cb81a9a
baibaichen added a commit to Kyligence/gluten that referenced this pull request Nov 30, 2024
@baibaichen
Fix build due to ClickHouse/ClickHouse#72460
ec0f8ed
baibaichen added a commit to apache/gluten that referenced this pull request Nov 30, 2024
@kyligence-git @baibaichen
[GLUTEN-1632][CH]Daily Update Clickhouse Version (20241130) (#8112)
31e1b74 
* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20241130)

* Fix Build due to ClickHouse/ClickHouse#71406

* Fix build due to ClickHouse/ClickHouse#72460

---------

Co-authored-by: kyligence-git <gluten@kyligence.io>
Co-authored-by: Chang Chen <baibaichen@gmail.com>
@vdimir vdimir restored the vdimir/join_select_inner_table branch December 2, 2024 13:12
@vdimir vdimir deleted the vdimir/join_select_inner_table branch December 3, 2024 11:11
baibaichen added a commit to Kyligence/gluten that referenced this pull request Dec 4, 2024
@baibaichen
Fix benchmark due to ClickHouse/ClickHouse#72460
1a3a3bc
baibaichen added a commit to apache/gluten that referenced this pull request Dec 4, 2024
@kyligence-git @baibaichen
[GLUTEN-1632][CH]Daily Update Clickhouse Version (20241204) (#8135)
6dd65c0 
* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20241204)

* Fix Build due to ClickHouse/ClickHouse#72715

* Fix Build due to ClickHouse/ClickHouse#65691

* Fix Build due to ClickHouse/ClickHouse#72722

* Fix gtest due to #8052

* Fix benchmark due to ClickHouse/ClickHouse#72460

* Add SPARK_DIR_NAME for fixing unstable ut

---------

Co-authored-by: kyligence-git <gluten@kyligence.io>
Co-authored-by: Chang Chen <baibaichen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vdimir @robot-ch-test-poll2 @robot-ch-test-poll1 @robot-clickhouse-ci-1