Skip to content

Refactoring near azure blob storage#63636

Merged
CurtizJ merged 15 commits intoClickHouse:masterfrom
CurtizJ:azure-refactoring
Jul 5, 2024
Merged

Refactoring near azure blob storage#63636
CurtizJ merged 15 commits intoClickHouse:masterfrom
CurtizJ:azure-refactoring

Conversation

@CurtizJ
Copy link
Copy Markdown
Member

@CurtizJ CurtizJ commented May 10, 2024 •
edited
Loading

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)
Modify your CI run

NOTE: If your merge the PR with modified CI you MUST KNOW what you are doing
NOTE: Checked options will be applied if set before CI RunConfig/PrepareRunConfig step

Include tests (required builds will be added automatically):

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Unit tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with Analyzer
  • All with Azure
  • Add your option here

Exclude tests:

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with MSAN
  • All with UBSAN
  • All with Coverage
  • All with Aarch64
  • Add your option here

Extra options:

  • do not test (only style check)
  • disable merge-commit (no merge from master before tests)
  • disable CI cache (job reuse)

Only specified batches in multi-batch jobs:

  • 1
  • 2
  • 3
  • 4
Details

@kssenii kssenii self-assigned this May 10, 2024
@CurtizJ
Copy link
Copy Markdown
Member Author

CurtizJ commented May 11, 2024

The idea of refactoring is to unify creation of client in azure disk and in azure storage.

@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-not-for-changelog This PR should not be mentioned in the changelog label May 11, 2024
@robot-clickhouse-ci-1
Copy link
Copy Markdown
Contributor

robot-clickhouse-ci-1 commented May 11, 2024 •
edited by robot-ch-test-poll
Loading

This is an automated comment for commit 7f2bfc5 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Successful checks
Check nameDescriptionStatus
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success

@CurtizJ CurtizJ marked this pull request as ready for review May 13, 2024 16:08
kssenii
kssenii approved these changes May 17, 2024
View reviewed changes
@CurtizJ
Copy link
Copy Markdown
Member Author

CurtizJ commented Jun 24, 2024 •
edited
Loading

The PR has failed: too many conflicts. Basically it's required to reimplement it from scratch.

@CurtizJ CurtizJ closed this Jun 24, 2024
kssenii
kssenii approved these changes Jun 25, 2024
View reviewed changes
@CurtizJ CurtizJ mentioned this pull request Jun 25, 2024
Merged
19 tasks
@CurtizJ CurtizJ added this pull request to the merge queue Jun 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 28, 2024
@CurtizJ CurtizJ mentioned this pull request Jun 28, 2024
Merged
@CurtizJ
Copy link
Copy Markdown
Member Author

CurtizJ commented Jul 5, 2024

Test 00002_log_and_exception_messages_formatting is failed in master with azure.

@CurtizJ CurtizJ added this pull request to the merge queue Jul 5, 2024
Merged via the queue into ClickHouse:master with commit 7fbe5a7 Jul 5, 2024
@CurtizJ CurtizJ deleted the azure-refactoring branch July 5, 2024 01:21
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 5, 2024
baibaichen added a commit to Kyligence/gluten that referenced this pull request Jul 6, 2024
@baibaichen
Fix build due to ClickHouse/ClickHouse#63636
79ac580
baibaichen added a commit to apache/gluten that referenced this pull request Jul 6, 2024
@kyligence-git @baibaichen
[GLUTEN-1632][CH]Daily Update Clickhouse Version (20240706) (#6359)
0cb2db3 
* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240706)

* Fix build due to ClickHouse/ClickHouse#63636

* Revert "[GLUTEN-1632][CH]Daily Update Clickhouse Version (20240705) (#6338)"

This reverts commit 4a674e5.

* exclude"shift left", "shift right","shift right unsigned" due to ClickHouse/ClickHouse#65838

---------

Co-authored-by: kyligence-git <gluten@kyligence.io>
Co-authored-by: Chang Chen <baibaichen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kssenii kssenii kssenii approved these changes

Assignees

@kssenii kssenii

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@CurtizJ @robot-clickhouse-ci-1 @kssenii @nikitamikhaylov @robot-ch-test-poll2