feat: add EIP-7917 deterministic proposer lookahead#7902
Merged
Conversation
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #7902 +/- ##
============================================
- Coverage 55.77% 55.73% -0.04%
============================================
Files 830 832 +2
Lines 59228 59332 +104
Branches 4562 4571 +9
============================================
+ Hits 33033 33070 +37
- Misses 26128 26195 +67
Partials 67 67 🚀 New features to boost your workflow:
|
Closed
nflaig
approved these changes
Jun 9, 2025
twoeths
reviewed
Jun 10, 2025
| {}, | ||
| e as Error | ||
| ); | ||
| state.commit(); |
Contributor
There was a problem hiding this comment.
no need state.commit() here
twoeths
reviewed
Jun 10, 2025
| e as Error | ||
| ); | ||
| state.commit(); | ||
| shuffling = computeEpochShuffling(state, getActiveValidatorIndices(state, epoch), epoch); |
Contributor
twoeths
reviewed
Jun 10, 2025
| // EpochCache needs to cache shuffling for nextEpoch + 1 too. | ||
| let shuffling: EpochShuffling; | ||
| try { | ||
| shuffling = state.epochCtx.getShufflingAtEpoch(epoch); |
Contributor
There was a problem hiding this comment.
this is not correct because shuffling of epoch + 2 is not available at this time so this line will always fail
we should do the query from shufflingCache similar to https://github.com/ChainSafe/lodestar/blob/v1.31.0/packages/state-transition/src/cache/epochCache.ts#L656
need to add a metric of number of times of hit/miss or see if it's available in the shuffling cache
hopefully most of the time shuffling of epoch + 2 is ready
Contributor
There was a problem hiding this comment.
lodestar_shuffling_cache_miss_count shows that most of the time we don't miss shuffling of epoch + 2, this is on one of lido node
I think there is a tiny difference querying shuffling at this place (the end of processEpoch) vs afterProcessEpoch so expect it's not an issue most of the time
KatyaRyazantseva
pushed a commit
to KatyaRyazantseva/lodestar
that referenced
this pull request
Jun 19, 2025
This is the first implementation of EIP-7917. We will want to have a plan deprecate proposer caches in `EpochCache` since Fulu beacon state will carry those information. This will be addressed in a later PR. Pending spec release for spec test Spec PR ethereum/consensus-specs#4190 --------- Co-authored-by: Nico Flaig <nflaig@protonmail.com>
KatyaRyazantseva
pushed a commit
to KatyaRyazantseva/lodestar
that referenced
this pull request
Jun 19, 2025
**Motivation** Bring proposer lookahead fixes to unstable branch, does not include shuffling calculation changes from ChainSafe#7945 yet. **Description** - only use proposer lookahead from state if epoch is post fulu - track epoch transition step time for proposer lookahead Related ChainSafe#7902
Member
|
🎉 This PR is included in v1.32.0 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first implementation of EIP-7917.
We will want to have a plan deprecate proposer caches in
EpochCachesince Fulu beacon state will carry those information. This will be addressed in a later PR.Pending spec release for spec test
Spec PR ethereum/consensus-specs#4190