fix: query shuffling from cache to compute proposer lookahead#7945
fix: query shuffling from cache to compute proposer lookahead#7945nflaig wants to merge 2 commits into
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## peerDAS #7945 +/- ##
===========================================
- Coverage 54.37% 54.33% -0.05%
===========================================
Files 840 842 +2
Lines 61989 62077 +88
Branches 4654 4668 +14
===========================================
+ Hits 33707 33727 +20
- Misses 28214 28278 +64
- Partials 68 72 +4 🚀 New features to boost your workflow:
|
|
Lgtm, at least the metric usage bugfix |
Should bring the minimal fixes to unstable branch #7948, this change needs more testing and is not critical for devnets as shuffling calculation is pretty cheap due to low validator count |
| const epoch = state.epochCtx.epoch + MIN_SEED_LOOKAHEAD + 1; | ||
|
|
||
| const shuffling = | ||
| state.epochCtx.shufflingCache?.getSync(epoch, cache.nextShufflingDecisionRoot, { |
There was a problem hiding this comment.
don't need the last param because we handled computeEpochShuffling() below
There was a problem hiding this comment.
so should we track metric separately? if we pass buildProps we get the metrics from shuffling cache
lodestar/packages/beacon-node/src/chain/shufflingCache.ts
Lines 156 to 158 in 6fa9960
There was a problem hiding this comment.
let's discuss here #7988 (comment), closing this PR
**Motivation** Bring proposer lookahead fixes to unstable branch, does not include shuffling calculation changes from ChainSafe#7945 yet. **Description** - only use proposer lookahead from state if epoch is post fulu - track epoch transition step time for proposer lookahead Related ChainSafe#7902
|
@twoeths should we just bring these changes to unstable and revisit metrics once we have a larger network (hoodi) with fulu enabled? |
|
this branch was just for testing, closing it now |
No description provided.