Skip to content

fix: try re-enable buildjet for RPC checks #6201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
LesnyRumcajs merged 2 commits into from
Oct 29, 2025
Merged

fix: try re-enable buildjet for RPC checks #6201

LesnyRumcajs merged 2 commits into from
Oct 29, 2025

Conversation

@LesnyRumcajs
Copy link
Member

@LesnyRumcajs LesnyRumcajs commented Oct 28, 2025 •
edited by coderabbitai bot
Loading

Summary of changes

Changes introduced in this pull request:

  • in the past it was failing but now it seems fine. Not sure what happened, but this should resolve issues around Lotus OOM in the RPC checks. If not, we can always revert.

Reference issue to close (if applicable)

Closes #6029

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Summary by CodeRabbit

  • Chores
    • Updated CI/CD infrastructure configuration to use an alternate build environment for testing workflows.

@LesnyRumcajs LesnyRumcajs added the RPC requires calibnet RPC checks to run on CI label Oct 28, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 28, 2025 •
edited
Loading

Walkthrough

The rpc-parity GitHub Actions workflow runner environment was updated from ubuntu-24.04 to buildjet-8vcpu-ubuntu-2204. This changes the underlying OS image and compute resources used to execute the workflow steps.

Changes

Cohort / File(s) Summary
CI workflow runner update
.github/workflows/rpc-parity.yml		 Modified job runner from ubuntu-24.04 to buildjet-8vcpu-ubuntu-2204 for the rpc-parity job

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related issues

Possibly related PRs

Suggested reviewers

  • akaladarshi
  • hanabi1224
  • elmattic

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The pull request title "fix: try re-enable buildjet for RPC checks" directly and accurately describes the main change in the changeset, which modifies the .github/workflows/rpc-parity.yml workflow to switch the job runner from ubuntu-24.04 to buildjet-8vcpu-ubuntu-2204. The title is clear, specific, and uses descriptive language (mentioning both the action "re-enable buildjet" and the scope "for RPC checks") rather than vague terms. A teammate scanning the repository history would clearly understand that this PR changes the infrastructure used for RPC checks, and the use of "try" reflects the PR's intent to be reversible if needed.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch try--buildjet-rpc

Comment @coderabbitai help to get the list of available commands and usage tips.

@LesnyRumcajs LesnyRumcajs marked this pull request as ready for review October 29, 2025 09:59
@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner October 29, 2025 09:59
@LesnyRumcajs LesnyRumcajs requested review from hanabi1224 and sudo-shashank and removed request for a team October 29, 2025 09:59
coderabbitai[bot]
coderabbitai bot reviewed Oct 29, 2025
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
.github/workflows/rpc-parity.yml (2)

9-9: Add inline documentation explaining the BuildJet migration.

The PR description mentions this resolves Lotus OOM issues, but this context is not captured in code. Add a comment above the runs-on field to document the rationale, making future maintainers aware of the decision and its trade-offs.

Apply this diff to add context:

  rpc-parity:
    name: RPC parity tests
+   # Using BuildJet (third-party runner) to mitigate Lotus OOM issues
+   # observed with ubuntu-24.04. If OOM issues persist, consider reverting
+   # to ubuntu-24.04 or investigating heap limits.
    runs-on: buildjet-8vcpu-ubuntu-2204

9-9: Add actionlint configuration to suppress custom runner warning.

BuildJet is confirmed as a legitimate third-party GitHub Actions runner service (Y Combinator startup). The workflow is already properly configured to mitigate OOM issues by relocating Docker volumes to /mnt (60GB+ available space).

However, actionlint will flag buildjet-8vcpu-ubuntu-2204 as an unknown runner label. Add .github/actionlint.yml to suppress this:

self-hosted-runner:
  labels:
    - buildjet-8vcpu-ubuntu-2204

Optionally, add an inline comment in the workflow explaining the OOM mitigation rationale for future reference.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c9f7fe8 and b758b4d.

📒 Files selected for processing (1)
  • .github/workflows/rpc-parity.yml (1 hunks)
🧰 Additional context used
🪛 actionlint (1.7.8)
.github/workflows/rpc-parity.yml

9-9: label "buildjet-8vcpu-ubuntu-2204" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-11-arm", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-26-xlarge", "macos-26", "macos-15-intel", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file

(runner-label)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Build forest binaries on Linux AMD64
  • GitHub Check: tests-release
  • GitHub Check: tests

@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Oct 29, 2025
Merged via the queue into main with commit 317dff6 Oct 29, 2025
45 checks passed
@LesnyRumcajs LesnyRumcajs deleted the try--buildjet-rpc branch October 29, 2025 10:42
@coderabbitai coderabbitai bot mentioned this pull request Jan 12, 2026
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@hanabi1224 hanabi1224 hanabi1224 approved these changes

@sudo-shashank sudo-shashank Awaiting requested review from sudo-shashank sudo-shashank is a code owner automatically assigned from ChainSafe/forest

Assignees

No one assigned

Labels

RPC requires calibnet RPC checks to run on CI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Move RPC checks to buildjet

3 participants

@LesnyRumcajs @hanabi1224