Revert to ubuntu-24.04 from `buildjet` in rpc parity workflow #5902

akaladarshi · 2025-08-05T16:51:01Z

Summary of changes

Changes introduced in this pull request:

The automatic RPC parity check keeps failing occasionally after updating to buildjet so reverting it.

Reference issue to close (if applicable)

Closes: #5905

Change checklist

I have performed a self-review of my own code,
I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
I have added tests that prove my fix is effective or that my feature works (if possible),
I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Summary by CodeRabbit

Chores
- Updated the GitHub Actions workflow for RPC parity tests to use the standard GitHub-hosted runner environment.

coderabbitai · 2025-08-05T16:51:10Z

Walkthrough

The GitHub Actions workflow for RPC parity tests was updated to run on the standard GitHub-hosted runner "ubuntu-24.04" instead of the custom runner "buildjet-8vcpu-ubuntu-2204". Additionally, a new step was added to relocate the Docker volumes directory to a location with more free space, involving moving the directory, creating a symbolic link, and verifying the move.

Changes

Cohort / File(s)	Change Summary
Workflow Runner and Docker Volumes Management `.github/workflows/rpc-parity.yml`	Changed the runner from a custom "buildjet-8vcpu-ubuntu-2204" to "ubuntu-24.04". Added steps to move Docker volumes from `/var/lib/docker/volumes` to `/mnt/docker-volumes`, create a symlink, and verify disk usage.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Assessment against linked issues

Objective	Addressed	Explanation
Use a runner environment that avoids RPC parity check failures and OOM issues (#5905)	✅
Add Docker volumes relocation to a path with sufficient free space to prevent failures (#5905)	✅

Assessment against linked issues: Out-of-scope changes

No out-of-scope changes detected.

Possibly related PRs

chore: use buildjet ubuntu in calibnet rpc check ci #5878: Reverses the runner environment change in the same .github/workflows/rpc-parity.yml workflow, directly affecting the same configuration.
chore: remove disk usage tricks for buildjet #5892: Adds a Docker volumes relocation step to the rpc-parity workflow, related to Docker volume management in the same workflow.

Suggested labels

RPC

Suggested reviewers

LesnyRumcajs
hanabi1224

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6bfa964 and 71b5879.

📒 Files selected for processing (1)

.github/workflows/rpc-parity.yml (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

.github/workflows/rpc-parity.yml

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)

GitHub Check: tests
GitHub Check: Build forest binaries on Linux AMD64
GitHub Check: Build Ubuntu
GitHub Check: cargo-publish-dry-run
GitHub Check: Build MacOS
GitHub Check: All lint checks
GitHub Check: Analyze (rust)
GitHub Check: Analyze (ruby)
GitHub Check: Analyze (go)

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch akaladarshi/revert-buildjet-rpc-parity

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

.github/workflows/rpc-parity.yml (1)

9-22: Watch for a possible runtime regression (8 vCPU → 2 vCPU)
The prior buildjet-8vcpu-ubuntu-2204 runner provided 8 vCPUs; GitHub-hosted ubuntu-24.04 offers 2 vCPUs by default. The API-compare script (Lines 15-22) plus Docker pulls/builds may now take longer and hit the 30-minute timeout (Line 22).

Suggestion: raise timeout-minutes or run the job once on the default branch to measure wall-clock time before merging to avoid flaky midnight failures.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 905a93e and 6bfa964.

📒 Files selected for processing (1)

.github/workflows/rpc-parity.yml (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)

GitHub Check: Build forest binaries on Linux AMD64
GitHub Check: cargo-publish-dry-run
GitHub Check: Build Ubuntu
GitHub Check: Build MacOS
GitHub Check: tests
GitHub Check: tests-release
GitHub Check: All lint checks
GitHub Check: Analyze (go)
GitHub Check: Analyze (rust)

🔇 Additional comments (1)

.github/workflows/rpc-parity.yml (1)

9-9: Confirm ubuntu-24.04 is GA and supports Docker-in-Docker
ubuntu-24.04 runners have only recently been made available and, at times, lacked full parity with the long-standing ubuntu-22.04 images (e.g., kernel modules, Docker engine versions). Given this job relies heavily on Docker (Lines 20-32), please verify that:

The image is out of preview/β and receives security updates.

Docker commands (docker system df, volume mounting, etc.) behave identically to 22.04.

If either point is uncertain, consider sticking with ubuntu-latest until 24.04 is fully GA.

LesnyRumcajs · 2025-08-05T17:50:50Z

.github/workflows/rpc-parity.yml

  rpc-parity:
    name: RPC parity tests
-    runs-on: buildjet-8vcpu-ubuntu-2204
+    runs-on: ubuntu-24.04


You need to revive some parts of #5892 as well.

Additionally, we need to understand why this is happening in the first place. It's not very logical. Could you please create a tracking issue?

Right now, we are just checking if this really resolves the issue.

But I will create a detailed issue for this to👍

akaladarshi requested a review from elmattic August 5, 2025 16:51

akaladarshi requested a review from a team as a code owner August 5, 2025 16:51

akaladarshi requested review from hanabi1224 and removed request for a team August 5, 2025 16:51

akaladarshi removed the request for review from hanabi1224 August 5, 2025 16:51

coderabbitai bot reviewed Aug 5, 2025

View reviewed changes

LesnyRumcajs reviewed Aug 5, 2025

View reviewed changes

akaladarshi marked this pull request as draft August 5, 2025 18:07

revert to ubuntu-24.04 from buildjet in rpc parity workflow

71b5879

akaladarshi force-pushed the akaladarshi/revert-buildjet-rpc-parity branch from 6bfa964 to 71b5879 Compare August 7, 2025 16:10

akaladarshi marked this pull request as ready for review August 7, 2025 16:10

akaladarshi requested a review from LesnyRumcajs August 7, 2025 16:10

hanabi1224 approved these changes Aug 7, 2025

View reviewed changes

elmattic approved these changes Aug 7, 2025

View reviewed changes

elmattic added this pull request to the merge queue Aug 7, 2025

Merged via the queue into main with commit 163eeb4 Aug 7, 2025
48 checks passed

elmattic deleted the akaladarshi/revert-buildjet-rpc-parity branch August 7, 2025 21:25

sudo-shashank pushed a commit that referenced this pull request Aug 11, 2025

Revert to ubuntu-24.04 from buildjet in rpc parity workflow (#5902)

7ba9744

coderabbitai bot mentioned this pull request Oct 29, 2025

fix: try re-enable buildjet for RPC checks #6201

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Revert to ubuntu-24.04 from `buildjet` in rpc parity workflow #5902

Revert to ubuntu-24.04 from `buildjet` in rpc parity workflow #5902

Uh oh!

akaladarshi commented Aug 5, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Aug 5, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

LesnyRumcajs Aug 5, 2025

Uh oh!

akaladarshi Aug 5, 2025

Uh oh!

akaladarshi Aug 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Revert to ubuntu-24.04 from buildjet in rpc parity workflow #5902

Revert to ubuntu-24.04 from buildjet in rpc parity workflow #5902

Uh oh!

Conversation

akaladarshi commented Aug 5, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of changes

Reference issue to close (if applicable)

Other information and links

Change checklist

Summary by CodeRabbit

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Aug 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Assessment against linked issues

Assessment against linked issues: Out-of-scope changes

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

LesnyRumcajs Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

akaladarshi Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

akaladarshi Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Revert to ubuntu-24.04 from `buildjet` in rpc parity workflow #5902

Revert to ubuntu-24.04 from `buildjet` in rpc parity workflow #5902

akaladarshi commented Aug 5, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Aug 5, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)