Skip to content

Conversation

@akaladarshi
Copy link
Collaborator

@akaladarshi akaladarshi commented Jul 30, 2025

Summary of changes

Changes introduced in this pull request:

  • replaced ubuntu-24.04 with buildjet-8vcpu-ubuntu-2204

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Summary by CodeRabbit

  • Chores
    • Updated the environment for automated checks to use a new runner. No impact on app features or user experience.

@akaladarshi akaladarshi requested a review from a team as a code owner July 30, 2025 13:53
@akaladarshi akaladarshi requested review from LesnyRumcajs and hanabi1224 and removed request for a team July 30, 2025 13:53
@akaladarshi akaladarshi added the RPC requires calibnet RPC checks to run on CI label Jul 30, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 30, 2025

Walkthrough

The GitHub Actions workflows for the "Calibnet RPC checks" and "RPC parity tests" jobs were updated to use a custom runner labeled buildjet-8vcpu-ubuntu-2204 instead of the default ubuntu-24.04 runner. No other workflow steps or configurations were changed.

Changes

Cohort / File(s) Change Summary
Workflow Runner Updates
.github/workflows/forest.yml, .github/workflows/rpc-parity.yml
Changed the runner environment from ubuntu-24.04 to buildjet-8vcpu-ubuntu-2204 for the "Calibnet RPC checks" and "RPC parity tests" jobs respectively.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch akaladarshi/buildjet-rpc-check-ci

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@LesnyRumcajs
Copy link
Member

@akaladarshi
Copy link
Collaborator Author

akaladarshi commented Jul 30, 2025

what about the daily RPC checks? https://github.com/ChainSafe/forest/blob/main/.github/workflows/rpc-parity.yml

Will be pushing that for as well, just wanted to see how it works in CI first.

Just a thought, I haven't seen daily RPC check failed at all (should we still change it?)

@LesnyRumcajs
Copy link
Member

what about the daily RPC checks? https://github.com/ChainSafe/forest/blob/main/.github/workflows/rpc-parity.yml

Will be pushing that for as well, just wanted to see how it works in CI first.

Just a thought, I haven't seen daily RPC check failed at all (should we still change it?)

If it works in one workflow and doesn't in another we should understand it. They are mostly the same; the only difference is that one takes the compiled binary and another extracts the binary from docker image. Lotus tag is the same.

But maybe it's just bad luck for PRs.

@akaladarshi akaladarshi marked this pull request as draft July 30, 2025 15:29
@akaladarshi akaladarshi force-pushed the akaladarshi/buildjet-rpc-check-ci branch 2 times, most recently from aeae7d4 to 4bbd4fc Compare July 30, 2025 16:22
@akaladarshi akaladarshi force-pushed the akaladarshi/buildjet-rpc-check-ci branch from 4bbd4fc to 7e5d247 Compare July 30, 2025 16:31
@akaladarshi akaladarshi marked this pull request as ready for review July 30, 2025 16:50
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e05d94b and 7e5d247.

📒 Files selected for processing (2)
  • .github/workflows/forest.yml (1 hunks)
  • .github/workflows/rpc-parity.yml (1 hunks)
🧰 Additional context used
🪛 actionlint (1.7.7)
.github/workflows/forest.yml

522-522: label "buildjet-8vcpu-ubuntu-2204" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file

(runner-label)

.github/workflows/rpc-parity.yml

9-9: label "buildjet-8vcpu-ubuntu-2204" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file

(runner-label)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: tests-release
  • GitHub Check: tests
  • GitHub Check: Build forest binaries on Linux AMD64
  • GitHub Check: Snapshot export checks
  • GitHub Check: Forest CLI checks
  • GitHub Check: Analyze (go)
🔇 Additional comments (1)
.github/workflows/rpc-parity.yml (1)

9-9: Verify Actionlint Usage and Runner Label Configuration

I didn’t find any actionlint.yaml or references to actionlint in the repo—please confirm whether you run Actionlint on your workflows. If you do, ensure the custom runner label is recognized to prevent lint failures:

• Add a generic fallback to your runs-on in .github/workflows/rpc-parity.yml:

-    runs-on: buildjet-8vcpu-ubuntu-2204
+    runs-on: [self-hosted, buildjet-8vcpu-ubuntu-2204]

• Or create/update .github/actionlint.yaml to whitelist buildjet-8vcpu-ubuntu-2204.

Then run:

actionlint -shellcheck=0 .github/workflows/rpc-parity.yml

to confirm the warning goes away.

- build-ubuntu
name: Calibnet RPC checks
runs-on: ubuntu-24.04
runs-on: buildjet-8vcpu-ubuntu-2204
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Same runner-label issue as above—keep the workflows consistent.

Replicate the fix (either self-hosted prefix or actionlint.yaml entry) here to prevent linter noise and accidental runner mismatch:

-    runs-on: buildjet-8vcpu-ubuntu-2204
+    runs-on: [self-hosted, buildjet-8vcpu-ubuntu-2204]

While you are touching this, ensure the BuildJet runner pool has Docker privileged mode enabled—steps 527-534 rely on root access to /var/lib/docker.


🏁 Script executed:

#!/bin/bash
# Show context around the specific runs-on entry in forest.yml
grep -n "runs-on:.*buildjet-8vcpu-ubuntu-2204" .github/workflows/forest.yml | while IFS=: read -r file line _; do
  echo "$file:$line"
  sed -n "$((line-2)),$((line+2))p" "$file"
done

# List all runs-on usages across workflows to verify consistency
echo
echo "=== All runs-on labels in .github/workflows ==="
rg "runs-on:" -n .github/workflows

# Check for an actionlint.yaml to see if the runner-label mapping is configured there
echo
echo "=== Searching for actionlint.yaml ==="
fd actionlint.yaml

Length of output: 6275


🏁 Script executed:

#!/bin/bash
# Correctly extract lines 520-550 around the runs-on entry and subsequent steps
sed -n '520,550p' .github/workflows/forest.yml

# Search for references to /var/lib/docker to confirm Docker dind usage
grep -n '/var/lib/docker' .github/workflows/forest.yml || true

Length of output: 1553


Add self-hosted prefix to the BuildJet runner and verify Docker privileged mode

Please update your Calibnet RPC checks in .github/workflows/forest.yml to explicitly mark it as a self-hosted runner and ensure the pool is running with Docker privileged mode enabled (since you’re relocating /var/lib/docker in steps 528–533).

• File: .github/workflows/forest.yml line 522
• Replace:

-    runs-on: buildjet-8vcpu-ubuntu-2204
+    runs-on: [self-hosted, buildjet-8vcpu-ubuntu-2204]

• Confirm with your infra team that the BuildJet runner pool has privileged: true (or equivalent) so that sudo mv /var/lib/docker/… and related commands succeed.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
runs-on: buildjet-8vcpu-ubuntu-2204
runs-on: [self-hosted, buildjet-8vcpu-ubuntu-2204]
🧰 Tools
🪛 actionlint (1.7.7)

522-522: label "buildjet-8vcpu-ubuntu-2204" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file

(runner-label)

🤖 Prompt for AI Agents
In .github/workflows/forest.yml at line 522, update the runner label to include
the 'self-hosted' prefix by changing 'runs-on: buildjet-8vcpu-ubuntu-2204' to
'runs-on: [self-hosted, buildjet-8vcpu-ubuntu-2204]'. Additionally, confirm with
the infrastructure team that the runner pool is configured with Docker
privileged mode enabled (e.g., 'privileged: true') to allow commands like 'sudo
mv /var/lib/docker/…' to execute successfully.

@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Jul 31, 2025
Merged via the queue into main with commit 166cf80 Jul 31, 2025
48 checks passed
@LesnyRumcajs LesnyRumcajs deleted the akaladarshi/buildjet-rpc-check-ci branch July 31, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RPC requires calibnet RPC checks to run on CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants