-
Notifications
You must be signed in to change notification settings - Fork 182
chore: use buildjet ubuntu in calibnet rpc check ci #5878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe GitHub Actions workflows for the "Calibnet RPC checks" and "RPC parity tests" jobs were updated to use a custom runner labeled Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
what about the daily RPC checks? https://github.com/ChainSafe/forest/blob/main/.github/workflows/rpc-parity.yml |
Will be pushing that for as well, just wanted to see how it works in CI first. Just a thought, I haven't seen daily RPC check failed at all (should we still change it?) |
If it works in one workflow and doesn't in another we should understand it. They are mostly the same; the only difference is that one takes the compiled binary and another extracts the binary from docker image. Lotus tag is the same. But maybe it's just bad luck for PRs. |
aeae7d4 to
4bbd4fc
Compare
4bbd4fc to
7e5d247
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/forest.yml(1 hunks).github/workflows/rpc-parity.yml(1 hunks)
🧰 Additional context used
🪛 actionlint (1.7.7)
.github/workflows/forest.yml
522-522: label "buildjet-8vcpu-ubuntu-2204" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/rpc-parity.yml
9-9: label "buildjet-8vcpu-ubuntu-2204" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: tests-release
- GitHub Check: tests
- GitHub Check: Build forest binaries on Linux AMD64
- GitHub Check: Snapshot export checks
- GitHub Check: Forest CLI checks
- GitHub Check: Analyze (go)
🔇 Additional comments (1)
.github/workflows/rpc-parity.yml (1)
9-9: Verify Actionlint Usage and Runner Label ConfigurationI didn’t find any
actionlint.yamlor references toactionlintin the repo—please confirm whether you run Actionlint on your workflows. If you do, ensure the custom runner label is recognized to prevent lint failures:• Add a generic fallback to your
runs-onin.github/workflows/rpc-parity.yml:- runs-on: buildjet-8vcpu-ubuntu-2204 + runs-on: [self-hosted, buildjet-8vcpu-ubuntu-2204]• Or create/update
.github/actionlint.yamlto whitelistbuildjet-8vcpu-ubuntu-2204.Then run:
actionlint -shellcheck=0 .github/workflows/rpc-parity.ymlto confirm the warning goes away.
| - build-ubuntu | ||
| name: Calibnet RPC checks | ||
| runs-on: ubuntu-24.04 | ||
| runs-on: buildjet-8vcpu-ubuntu-2204 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Same runner-label issue as above—keep the workflows consistent.
Replicate the fix (either self-hosted prefix or actionlint.yaml entry) here to prevent linter noise and accidental runner mismatch:
- runs-on: buildjet-8vcpu-ubuntu-2204
+ runs-on: [self-hosted, buildjet-8vcpu-ubuntu-2204]While you are touching this, ensure the BuildJet runner pool has Docker privileged mode enabled—steps 527-534 rely on root access to /var/lib/docker.
🏁 Script executed:
#!/bin/bash
# Show context around the specific runs-on entry in forest.yml
grep -n "runs-on:.*buildjet-8vcpu-ubuntu-2204" .github/workflows/forest.yml | while IFS=: read -r file line _; do
echo "⮑ $file:$line"
sed -n "$((line-2)),$((line+2))p" "$file"
done
# List all runs-on usages across workflows to verify consistency
echo
echo "=== All runs-on labels in .github/workflows ==="
rg "runs-on:" -n .github/workflows
# Check for an actionlint.yaml to see if the runner-label mapping is configured there
echo
echo "=== Searching for actionlint.yaml ==="
fd actionlint.yamlLength of output: 6275
🏁 Script executed:
#!/bin/bash
# Correctly extract lines 520-550 around the runs-on entry and subsequent steps
sed -n '520,550p' .github/workflows/forest.yml
# Search for references to /var/lib/docker to confirm Docker dind usage
grep -n '/var/lib/docker' .github/workflows/forest.yml || trueLength of output: 1553
Add self-hosted prefix to the BuildJet runner and verify Docker privileged mode
Please update your Calibnet RPC checks in .github/workflows/forest.yml to explicitly mark it as a self-hosted runner and ensure the pool is running with Docker privileged mode enabled (since you’re relocating /var/lib/docker in steps 528–533).
• File: .github/workflows/forest.yml line 522
• Replace:
- runs-on: buildjet-8vcpu-ubuntu-2204
+ runs-on: [self-hosted, buildjet-8vcpu-ubuntu-2204]• Confirm with your infra team that the BuildJet runner pool has privileged: true (or equivalent) so that sudo mv /var/lib/docker/… and related commands succeed.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| runs-on: buildjet-8vcpu-ubuntu-2204 | |
| runs-on: [self-hosted, buildjet-8vcpu-ubuntu-2204] |
🧰 Tools
🪛 actionlint (1.7.7)
522-522: label "buildjet-8vcpu-ubuntu-2204" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
🤖 Prompt for AI Agents
In .github/workflows/forest.yml at line 522, update the runner label to include
the 'self-hosted' prefix by changing 'runs-on: buildjet-8vcpu-ubuntu-2204' to
'runs-on: [self-hosted, buildjet-8vcpu-ubuntu-2204]'. Additionally, confirm with
the infrastructure team that the runner pool is configured with Docker
privileged mode enabled (e.g., 'privileged: true') to allow commands like 'sudo
mv /var/lib/docker/…' to execute successfully.
Summary of changes
Changes introduced in this pull request:
ubuntu-24.04withbuildjet-8vcpu-ubuntu-2204Reference issue to close (if applicable)
Closes
Other information and links
Change checklist
Summary by CodeRabbit