Skip to content

Fix a bug that event client was created with wrong user agent#1120

Merged
centaurus-cloud-bot merged 1 commit intoCentaurusInfra:masterfrom
Sindica:fix-event-client-user-agent
Jul 17, 2021
Merged

Fix a bug that event client was created with wrong user agent#1120
centaurus-cloud-bot merged 1 commit intoCentaurusInfra:masterfrom
Sindica:fix-event-client-user-agent

Conversation

@Sindica
Copy link
Collaborator

@Sindica Sindica commented Jul 16, 2021

Before fix, debug log:

I0716 19:08:32.737344   31665 options.go:383] === kubeConfigs address 0xc000401dc0, user agent []
I0716 19:08:32.738162   31665 options.go:385] === kubeConfigs user agent [hyperkube/v0.7.0 (linux/amd64) kubernetes/$Format/scheduler]
I0716 19:08:32.738180   31665 options.go:392] === restConfigs address 0xc0009ab8c0, user agent [hyperkube/v0.7.0 (linux/amd64) kubernetes/$Format/scheduler]
I0716 19:08:32.738519   31665 options.go:397] === restConfigs user agent [hyperkube/v0.7.0 (linux/amd64) kubernetes/$Format/leader-election]
I0716 19:08:32.738538   31665 options.go:402] === kubeConfigs address 0xc000401dc0, user agent [hyperkube/v0.7.0 (linux/amd64) kubernetes/$Format/leader-election]

After fix, debug log:

I0716 21:01:36.171693   18541 options.go:383] === kubeConfigs address 0xc000a77480, user agent []
I0716 21:01:36.172744   18541 options.go:385] === kubeConfigs user agent [hyperkube/v0.8.0 (linux/amd64) kubernetes/$Format/scheduler]
I0716 21:01:36.172964   18541 options.go:392] === restConfigs address 0xc000011cf0, user agent [hyperkube/v0.8.0 (linux/amd64) kubernetes/$Format/scheduler]
I0716 21:01:36.173798   18541 options.go:397] === restConfigs user agent [hyperkube/v0.8.0 (linux/amd64) kubernetes/$Format/leader-election]
I0716 21:01:36.173819   18541 options.go:402] === kubeConfigs address 0xc000a77480, user agent [hyperkube/v0.8.0 (linux/amd64) kubernetes/$Format/scheduler]

@Sindica Sindica requested review from h-w-chen, q131172019 and yb01 July 16, 2021 21:09
@Sindica Sindica added the bug Something isn't working label Jul 16, 2021
yb01
yb01 approved these changes Jul 16, 2021
View reviewed changes
Copy link
Collaborator

@yb01 yb01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@zmn223
Copy link
Collaborator

zmn223 commented Jul 17, 2021

/approve

@centaurus-cloud-bot
Copy link
Collaborator

centaurus-cloud-bot commented Jul 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yb01, zmn223

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@centaurus-cloud-bot centaurus-cloud-bot merged commit 459fc85 into CentaurusInfra:master Jul 17, 2021
Sindica added a commit that referenced this pull request Jul 17, 2021
@Sindica
Merge master into POC 930 (#1121)
18f188e 
* design doc: DaemonSet support in scale-out Arktos (#1109)

* doc: DaemonSet support in scale-out Arktos

* minor: rephrased daemonset managability of failed TP

* added notes of scale-up arktos supporting system tenanted DS

* put daemonset design doc in separate file

* trivial: resource manager reworded as resource partition

* added design alternatives based on peer feedback

* emphasized on DS and supporting resources in unit of TP; put more detail of kubelet secret/configmap local store changes

* added clarifications based on peer feedback

* minor: revised based on peer review

* kubemark cluster starts partition servers in parallel (#1113)

* multiple partitions of same kind (tp/rp) able to start in parallel

* eliminates /tmp/saved_tenant_ips.txt and TP_IP_CONCAT var from kubemark setup scripts

* minor: todo comments for dedicated log stream of parallel calls

* Bump Arktos to v0.8.0 (#1116)

* Fix a bug that event client was created with wrong user agent (#1120)

Co-authored-by: hwchen <hong.chen@futurewei.com>
@Sindica Sindica added this to the v0.9 milestone Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yb01 yb01 yb01 approved these changes

@h-w-chen h-w-chen Awaiting requested review from h-w-chen

@q131172019 q131172019 Awaiting requested review from q131172019

Assignees

@yb01 yb01

Labels

approved bug Something isn't working lgtm size/XS

Projects

None yet

Milestone

v0.9

Development

Successfully merging this pull request may close these issues.

4 participants

@Sindica @zmn223 @centaurus-cloud-bot @yb01