design doc: DaemonSet support in scale-out Arktos#1109
Merged
centaurus-cloud-bot merged 9 commits intoCentaurusInfra:masterfrom Jul 6, 2021
Merged
design doc: DaemonSet support in scale-out Arktos#1109centaurus-cloud-bot merged 9 commits intoCentaurusInfra:masterfrom
centaurus-cloud-bot merged 9 commits intoCentaurusInfra:masterfrom
Conversation
fed6066 to
1f9147c
Compare
yb01
reviewed
Jun 22, 2021
ebc64b7 to
7ec0387
Compare
yb01
reviewed
Jun 24, 2021
yb01
reviewed
Jun 24, 2021
Sindica
reviewed
Jun 25, 2021
Sindica
reviewed
Jun 25, 2021
Sindica
reviewed
Jun 29, 2021
Collaborator
Sindica
left a comment
There was a problem hiding this comment.
We need more discussion on this design. I am worried this would affect the design of system pod and makes it much more complicated
added 2 commits
June 29, 2021 15:26
…ail of kubelet secret/configmap local store changes
Sindica
approved these changes
Jul 2, 2021
Collaborator
Sindica
left a comment
There was a problem hiding this comment.
Generally it looks good. Minor comments below.
Collaborator
|
/lgtm |
Collaborator
|
/approve |
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Sindica, yb01, zmn223 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sindica
added a commit
that referenced
this pull request
Jul 17, 2021
* design doc: DaemonSet support in scale-out Arktos (#1109) * doc: DaemonSet support in scale-out Arktos * minor: rephrased daemonset managability of failed TP * added notes of scale-up arktos supporting system tenanted DS * put daemonset design doc in separate file * trivial: resource manager reworded as resource partition * added design alternatives based on peer feedback * emphasized on DS and supporting resources in unit of TP; put more detail of kubelet secret/configmap local store changes * added clarifications based on peer feedback * minor: revised based on peer review * kubemark cluster starts partition servers in parallel (#1113) * multiple partitions of same kind (tp/rp) able to start in parallel * eliminates /tmp/saved_tenant_ips.txt and TP_IP_CONCAT var from kubemark setup scripts * minor: todo comments for dedicated log stream of parallel calls * Bump Arktos to v0.8.0 (#1116) * Fix a bug that event client was created with wrong user agent (#1120) Co-authored-by: hwchen <hong.chen@futurewei.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind design
/kind documentation
What this PR does / why we need it:
It states the supported DaemonSet resource be of syatem tenant only, clarifies TP be its control plane, depicts the necessary changes that should be made to Arktos components.
Does this PR introduce a user-facing change?:
NONE (design doc only)