Skip to content
This repository was archived by the owner on Jan 27, 2023. It is now read-only.

Conversation

@zlshames
Copy link
Member

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

skia-flutter-autoroll and others added 30 commits November 18, 2021 13:13
…r#29801)

* [web] move browser installation to BrowserEnvironment.prepare

* reject attempts to install Chromium on LUCI
…tter#29768)

This PR fixes an assertion error when the physical-logical map changes during key synthesization. This error will lead to irregular key sequences, and might occur during an extremely rare edge case described in the unit test in this PR.
 This PR changes how embedder API's SendKeyData sends ui.KeyData to the framework. The packets are now sent over the existing platform messenger, reusing the entirety of its code path and functionalities while keeping the embedder API unchanged
Update license script for new expat

Fixes flutter/flutter#91384
…9823)

https://skia.googlesource.com/skia.git/+log/a5261995416e..62392f624f39

2021-11-18 brianosman@google.com Remove old (unused) values from LayoutToken enum
2021-11-18 johnstiles@google.com Improve redundant trace_var elimination.
2021-11-18 bsalomon@google.com Remove drawPatch/Vertices helpers that don't take SkBlendMode
2021-11-18 robertphillips@google.com Improve handling of degenerate paths in AAHairLinePathRenderer::bloat_quad
2021-11-18 drott@chromium.org Fall back to type 3 embedding for fonts with COLR table
2021-11-18 johnstiles@google.com Optimize commutative operations in SkVM.
2021-11-18 johnstiles@google.com Add test for commutative operations in SkVM.
2021-11-18 herb@google.com make drawMatrix use more explicit
2021-11-18 robertphillips@google.com Allow the Triangulator to fail
2021-11-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 8e6bab5320de to 4f4d765e4e51
2021-11-18 brianosman@google.com Reland "Remove layer-coverage-tracking experiment"
2021-11-18 kjlubick@google.com [infra] Use Bazel transitions to allow cc_binary to set their own flags

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jlavrova@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…#29727)

Fixes flutter/flutter#93352

Improves Android benchmarks on both Pixel 4 and a lower end Android Go device for 99th percentile and average raster times.

This works by telling the system compositor what timestamp we intended to show this frame for. This way, if we end up with a frame that gets submitted right at the beginning of a vsync and then a second frame submitted on the same vsync, the compositor will only try to show the second frame on the screen and save the GPU some work.

Without this, a situation like that results in an "avalanche" of calls where the GPU is behind the CPU and keeps delaying CPU work until we finally stop submitting frames. This can be observed as a lengthy dequeuBuffer in a systrace enabled trace, as shown in the linked issue. This avalanche is often triggered by a frame that does a shader compile through a couple vsyncs and then is followed by a bunch of very fast frames that take less than a vsync to render - the first of those fast frames gets delivered before the end of the vsync that the slow frame ended in.

We cannot implement this ourselves because we don't know how long the swap buffers call will take on the system side, and if we try to guess we can very well get it wrong.

I've filed issues to look into adding this for Vulkan and Metal, although we should also first take traces there to make sure it's warranted.

See also: https://android-developers.googleblog.com/2020/04/high-refresh-rate-rendering-on-android.html
)

https://skia.googlesource.com/skia.git/+log/62392f624f39..940086c81587

2021-11-19 michaelludwig@google.com [graphite] Include offset in Writers returned by DrawBufferManager
2021-11-19 herb@google.com refactor checking for direct glyph situations
2021-11-19 jvanverth@google.com Add SkSL::ShaderCaps and use as base class for GrShaderCaps
2021-11-19 scroggo@google.com Add minimal GL support for protected backend textures
2021-11-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 4c687cc2f8ea to f5cf2d08ff9c (2 revisions)
2021-11-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from ca9862fcfe55 to e7ac7694e638 (463 revisions)
2021-11-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 67e1e9c199cc to 53db01bf1e64 (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jlavrova@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
)

https://skia.googlesource.com/skia.git/+log/9b35cd642f98..37940afc0caf

2021-11-20 csmartdalton@google.com Remove remaining "Gr" references outside of #ifdefs from tessellators
2021-11-20 csmartdalton@google.com Move GrVertexColor to skgpu::VertexColor
2021-11-20 csmartdalton@google.com Move tessellation-specific functions out of GrPathUtils
2021-11-20 csmartdalton@google.com Move Ganesh-specific bits of StrokeTessellator into an #ifdef
2021-11-20 csmartdalton@google.com Convert StrokeTessellators to use PatchWriter
2021-11-20 johnstiles@google.com Remove VarType from trace_var opcode.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jlavrova@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
skia-flutter-autoroll and others added 29 commits December 7, 2021 12:59
…utter#30189)

The shell tests are failing on Windows against the latest VS2019 headers due to a new safety assert.
Dart VM flags are passed to Flutter via an fml::CommandLine::Option that
looks something like:

   {"dart-flags, "--max_profile_depth 1,--trace_service"}

We perform a prefix match to handle cases where Dart VM options take
arguments.

Adding the comment since in a recent review I found myself wondering why
we're using a prefix match to begin with. While the original author had
forgotten, the good news is, he wrote a test that covers this exact
case. This comment just removes one level of indirection for future
readers.
…tter#28415)

* 'Update Dart SDK to aa7d19d'

* [web] Don't reset history on hot restart (flutter#27872)

* Makes scrollable to use main screen if the flutter view is not attached to a screen (flutter#28110)

* Fix regression in system UI colors (flutter#28206)

* update licenses golden

Co-authored-by: Mouad Debbar <mouad.debbar@gmail.com>
Co-authored-by: chunhtai <47866232+chunhtai@users.noreply.github.com>
Co-authored-by: Kate Lovett <katelovett@google.com>
@zlshames zlshames merged commit 76f5faf into tanay/gif-insertion-pr Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.