This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Makes scrollable to use main screen if the flutter view is not attached #28110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This sounds plausible. I'd add comments to the early outs in those methods. Also, it seems like you have an internal partner that is able to test fixes for you and has reproduction steps. I didn't see where they said this will fix there issues, did you have them try it out? |
e106bb6 to
b0023c3
Compare
Contributor
Author
|
@gaaclarke The root cause the the screen scale, I update this pr to include the real fix, I keep the hidden logic here as well because i think it is probably the right thing to do anyway |
gaaclarke
reviewed
Aug 18, 2021
Comment on lines
57
to
59
| UIScreen* screen = [[[reference bridge]->view() window] screen]; | ||
| // Screen can be nil if the FlutterView is covered by another native view. | ||
| CGFloat scale = screen == nil ? 1 : screen.scale; |
Member
There was a problem hiding this comment.
Nice catch! I'd say if you can't get the screen I'd use [UIScreen mainScreen] instead of using 1.
Comment on lines
281
to
283
| if ([_semanticsObject node].HasFlag(flutter::SemanticsFlags::kIsHidden)) { | ||
| return CGSizeZero; | ||
| } |
Member
There was a problem hiding this comment.
Do we still want to do this then if we don't think this was the actual problem?
| CGPointMake(0, scrollPosition * effectivelyScale))); | ||
| } | ||
|
|
||
| - (void)testVerticalFlutterScrollableSemanticsObjectNoWindow { |
4de4a26 to
022e216
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 19, 2021
…t attached to a screen (flutter/engine#28110)
fluttergithubbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 19, 2021
…t attached to a screen (flutter/engine#28110) (#88488)
blasten
pushed a commit
to blasten/flutter
that referenced
this pull request
Aug 19, 2021
…t attached to a screen (flutter/engine#28110) (flutter#88488)
chriscraws
pushed a commit
to chriscraws/engine
that referenced
this pull request
Aug 23, 2021
christopherfujino
added a commit
that referenced
this pull request
Sep 2, 2021
) * 'Update Dart SDK to aa7d19d' * [web] Don't reset history on hot restart (#27872) * Makes scrollable to use main screen if the flutter view is not attached to a screen (#28110) * Fix regression in system UI colors (#28206) * update licenses golden Co-authored-by: Mouad Debbar <mouad.debbar@gmail.com> Co-authored-by: chunhtai <47866232+chunhtai@users.noreply.github.com> Co-authored-by: Kate Lovett <katelovett@google.com>
tneotia
pushed a commit
to BlueBubblesApp/engine
that referenced
this pull request
Dec 9, 2021
…tter#28415) * 'Update Dart SDK to aa7d19d' * [web] Don't reset history on hot restart (flutter#27872) * Makes scrollable to use main screen if the flutter view is not attached to a screen (flutter#28110) * Fix regression in system UI colors (flutter#28206) * update licenses golden Co-authored-by: Mouad Debbar <mouad.debbar@gmail.com> Co-authored-by: chunhtai <47866232+chunhtai@users.noreply.github.com> Co-authored-by: Kate Lovett <katelovett@google.com>
filmil
pushed a commit
to filmil/engine
that referenced
this pull request
Apr 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix b/194026347
The screen can be nil if the flutterview is covered by another view which causes the scale to be 0. This pr fixes it
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.