Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Add 'explicit' to Android embedder constructors #29830

Merged
jmagman merged 1 commit into from
Nov 19, 2021
Merged

Add 'explicit' to Android embedder constructors #29830

jmagman merged 1 commit into from
Nov 19, 2021

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Nov 19, 2021

Add explicit to constructor declarations in android_debug.

Include headers using header filter regex:

Checks: '-*,google-explicit-constructor'
WarningsAsErrors: '-*,google-explicit-constructor'
HeaderFilterRegex: '.*/flutter/.*h$'

https://clang.llvm.org/extra/clang-tidy/checks/google-explicit-constructor.html

Android version of #29741
For flutter/flutter#93576

@jmagman jmagman self-assigned this Nov 19, 2021
@flutter-dashboard
Copy link

flutter-dashboard bot commented Nov 19, 2021

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Nov 19, 2021
@jmagman
Copy link
Member Author

jmagman commented Nov 19, 2021 •
edited
Loading

Once the Android warning is fixed I will turn on the android_debug linter in the recipe:
https://ci.chromium.org/raw/build/logs.chromium.org/flutter/led/magder_google.com/a607d51368817f8141be366e4a2e08f563fc08ba866a6241b2d0890c2292a8e0/+/build.proto?server=chromium-swarm.appspot.com

https://flutter-review.googlesource.com/c/recipes/+/22160

@jmagman jmagman requested review from blasten and zanderso November 19, 2021 03:30
@jmagman jmagman added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Nov 19, 2021
@jmagman
Copy link
Member Author

jmagman commented Nov 19, 2021

Tree is actually green, the status isn't updating. Merging.

@jmagman jmagman merged commit d581efc into flutter:main Nov 19, 2021
@jmagman jmagman deleted the explicit-android branch November 19, 2021 05:06
zanderso
zanderso reviewed Nov 19, 2021
View reviewed changes
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 19, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 19, 2021
@engine-flutter-autoroll
d581efc Add 'explicit' to Android embedder constructors (flutter/engi…
fed1290 
…ne#29830)
@jmagman jmagman mentioned this pull request Nov 23, 2021
Open
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@zanderso zanderso zanderso left review comments

@blasten blasten blasten approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

cla: yes needs tests platform-android waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jmagman @blasten @zanderso