This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Make it less likely to GC during application startup on Android #29825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Nov 18, 2021
rmacnak-google
approved these changes
Nov 18, 2021
blasten
approved these changes
Nov 19, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing a GC during application startup can be seen on lower end devices due to low memory warnings. These GCs tend to not recover much memory (because we're busy working towards the first frame).
This is a more aggressive attempt compared with the last patch that changed this (#28891). However, even with that patch internal traces show applications on lower end devices doing inappropriate GCs.
The GC can still run before rendering a frame based on the allocation policy and/or the old gen heap size limit, which is defaulted to half of physical memory. So it is not as if the GC will just accumulate in an unbounded fashion here.
/cc @a-siva @rmacnak-google
/cc @akbiggs @arbreng in case this might help Fuchsia