This repository was archived by the owner on Feb 26, 2025. It is now read-only.
[Core]NEURON 8.2.2#1802
Merged
Merged
Conversation
Collaborator
|
Thank you for your pull request! Should you want to clear the PR build directory after failures, please use this pipeline. Before running the cleanup pipeline, please ensure that any PR building pipelines have been cancelled or finished running. |
Collaborator
|
To test your PR, use the following on BlueBrain5: unset MODULEPATH
. /gpfs/bbp.cscs.ch/ssd/apps/bsd/pulls/1802/config/modules.sh
module load unstable |
iomaganaris
approved these changes
Jan 4, 2023
iomaganaris
left a comment
There was a problem hiding this comment.
I'm okay with merging this however note that since NEURON version 9.0+ the neuron spack package doesn't depend on the CoreNEURON package. Instead it's using the CoreNEURON version which is merged to NEURON so this won't change anything in the deployed modules.
alexsavulescu
commented
Jan 4, 2023
heerener
pushed a commit
that referenced
this pull request
Jan 17, 2023
heerener
pushed a commit
that referenced
this pull request
Jan 23, 2023
CoreNEURON: reduce memory usage in report initialization (#1776) Recipe changes to combine coreneuron into NEURON (#1777) * Bring coreneuron recipe options into neuron for coreneuron merge * remove dependency with coreneuron when neuron>=9.0 or develop * coreneuron variant is on by default in neuron * coreneuron mechanism library should always have different name than libcorenrnmech.so as it's now part of NEURON installation * do not add arch specific opt flags with +debug * Automatically bring coreneuron build_type=Debug when neuron+debug is used. This will simplify logic in blueconfig CI where we don't have to explicitly specify coreneuron dependency (especially as we have merged neuron and coreneuron) * Find "right" nrnivmodl-core binary for neurodamus building See relevant PR: neuronsimulator/nrn#2055 Deploy NEURON's upcoming 9.0a release (#1781) * Updated model-neocortex packages with latest 1.10 tag * add nmodl 0.5.a * remove coreneuron packages Co-authored-by: Ioannis Magkanaris <iomagkanaris@gmail.com> Co-authored-by: Matthias Wolf <matthias.wolf@epfl.ch> Update NEURON version (#1792) - Create NEURON version 9.0.a2 that includes bug fixes [Core]NEURON 8.2.2 (#1802) coreneuron: so long, and thanks for the fish. Coreneuron has been folded into neuRon and should not be referred to as a standalone package any more. Add py-sympy dependency at neuron package level newer spack doesn't seem to propogate python package dependencies (as PYTHONPATH) during build phase. neuron: omitted link flag for Caliper
heerener
pushed a commit
that referenced
this pull request
Jan 23, 2023
CoreNEURON: reduce memory usage in report initialization (#1776) Recipe changes to combine coreneuron into NEURON (#1777) * Bring coreneuron recipe options into neuron for coreneuron merge * remove dependency with coreneuron when neuron>=9.0 or develop * coreneuron variant is on by default in neuron * coreneuron mechanism library should always have different name than libcorenrnmech.so as it's now part of NEURON installation * do not add arch specific opt flags with +debug * Automatically bring coreneuron build_type=Debug when neuron+debug is used. This will simplify logic in blueconfig CI where we don't have to explicitly specify coreneuron dependency (especially as we have merged neuron and coreneuron) * Find "right" nrnivmodl-core binary for neurodamus building See relevant PR: neuronsimulator/nrn#2055 Deploy NEURON's upcoming 9.0a release (#1781) * Updated model-neocortex packages with latest 1.10 tag * add nmodl 0.5.a * remove coreneuron packages Co-authored-by: Ioannis Magkanaris <iomagkanaris@gmail.com> Co-authored-by: Matthias Wolf <matthias.wolf@epfl.ch> Update NEURON version (#1792) - Create NEURON version 9.0.a2 that includes bug fixes [Core]NEURON 8.2.2 (#1802) coreneuron: so long, and thanks for the fish. Coreneuron has been folded into neuRon and should not be referred to as a standalone package any more. Add py-sympy dependency at neuron package level newer spack doesn't seem to propogate python package dependencies (as PYTHONPATH) during build phase. neuron: omitted link flag for Caliper
matz-e
pushed a commit
that referenced
this pull request
Jan 25, 2023
CoreNEURON: reduce memory usage in report initialization (#1776) Recipe changes to combine coreneuron into NEURON (#1777) * Bring coreneuron recipe options into neuron for coreneuron merge * remove dependency with coreneuron when neuron>=9.0 or develop * coreneuron variant is on by default in neuron * coreneuron mechanism library should always have different name than libcorenrnmech.so as it's now part of NEURON installation * do not add arch specific opt flags with +debug * Automatically bring coreneuron build_type=Debug when neuron+debug is used. This will simplify logic in blueconfig CI where we don't have to explicitly specify coreneuron dependency (especially as we have merged neuron and coreneuron) * Find "right" nrnivmodl-core binary for neurodamus building See relevant PR: neuronsimulator/nrn#2055 Deploy NEURON's upcoming 9.0a release (#1781) * Updated model-neocortex packages with latest 1.10 tag * add nmodl 0.5.a * remove coreneuron packages Co-authored-by: Ioannis Magkanaris <iomagkanaris@gmail.com> Co-authored-by: Matthias Wolf <matthias.wolf@epfl.ch> Update NEURON version (#1792) - Create NEURON version 9.0.a2 that includes bug fixes [Core]NEURON 8.2.2 (#1802) coreneuron: so long, and thanks for the fish. Coreneuron has been folded into neuRon and should not be referred to as a standalone package any more. Add py-sympy dependency at neuron package level newer spack doesn't seem to propogate python package dependencies (as PYTHONPATH) during build phase. neuron: omitted link flag for Caliper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.