This repository was archived by the owner on Feb 26, 2025. It is now read-only.
Deploy upcoming 9.0a release#1781
Merged
Merged
Conversation
Collaborator
|
Thank you for your pull request! Should you want to clear the PR build directory after failures, please use this pipeline. Before running the cleanup pipeline, please ensure that any PR building pipelines have been cancelled or finished running. |
Collaborator
|
The following build jobs of the deployment for this PR failed: |
065b1a0 to
2f653f4
Compare
Collaborator
|
The following build jobs of the deployment for this PR failed: |
Collaborator
|
The following build jobs of the deployment for this PR failed: |
2f653f4 to
0f7b5e6
Compare
Also add knl variant in order to enable deployment of KNL modules. We will remove this variant when CMake of NEURON handles cross-compiling aspects where nocmodl should be compiled without ARCH specific optimization flags.
0f7b5e6 to
b9b1467
Compare
Collaborator
|
The following build jobs of the deployment for this PR failed: Please fix the following packages that failed to build: |
Collaborator
|
The following build jobs of the deployment for this PR failed: Please fix the following packages that failed to build: |
Collaborator
|
The following build jobs of the deployment for this PR failed: Please fix the following packages that failed to build: |
06b0540 to
6e9e869
Compare
6e9e869 to
8b57a57
Compare
Collaborator
|
The following build jobs of the deployment for this PR failed: Please fix the following packages that failed to build: |
Collaborator
|
The following build jobs of the deployment for this PR failed: Please fix the following packages that failed to build: |
of the external spack package - `nrnivmodl -coreneuron mod` with neuron/8.2.2a currently deployed isn't working because of that
Collaborator
|
The following build jobs of the deployment for this PR failed: Please fix the following packages that failed to build: |
Collaborator
|
The following build jobs of the deployment for this PR failed: |
Collaborator
|
To test your PR, use the following on BlueBrain5: unset MODULEPATH
. /gpfs/bbp.cscs.ch/ssd/apps/bsd/pulls/1781/config/modules.sh
module load unstablePlease test the following updated modules:
The following module tests failed: |
Collaborator
|
To test your PR, use the following on BlueBrain5: unset MODULEPATH
. /gpfs/bbp.cscs.ch/ssd/apps/bsd/pulls/1781/config/modules.sh
module load unstablePlease test the following updated modules:
|
matz-e
reviewed
Dec 6, 2022
iomaganaris
reviewed
Dec 13, 2022
pramodk
added a commit
that referenced
this pull request
Dec 14, 2022
* In #1777 we have made coreneuron optional for upcoming neuron > 8 releases: ``` depends_on("coreneuron+legacy-unit~caliper", when="@:8.99+coreneuron+legacy-unit~caliper") ... ``` * Because of this change, spack is now preferring develop version of neuron when we mix gcc with intel: ``` $ spack spec -I py-bluepyopt%gcc ^neuron%intel Input spec -------------------------------- - py-bluepyopt%gcc - ^neuron%intel Concretized -------------------------------- - py-bluepyopt@1.10.38%gcc@11.2.0+neuron patches=dc37639246b3a3320c840f1c4f635940b8510a896a667d4707c3d355d9c6fb81 arch=linux-rhel7-skylake - ^neuron@develop%intel@2021.4.0+binary~caliper~codegenopt+coreneuron~debug~gpu~interviews~ipo+legacy-fr+legacy-unit+memacs+mod-compatibility+mpi~nmodl~openmp+python+report+rx3d+shared~sympy~sympyopt~tests~unified build_type=RelWithDebInfo model_tests=None patches=708cb04826b394a858069d93e8c08e1e81e914c23e1ef3da0486e8233834ff6c sanitizers=None arch=linux-rhel7-skylake ``` but with single compiler, it uses last release correctly ``` $ spack spec -I py-bluepyopt ^neuron%intel Input spec -------------------------------- - py-bluepyopt - ^neuron%intel Concretized -------------------------------- - py-bluepyopt@1.10.38%intel@2021.4.0+neuron patches=dc37639246b3a3320c840f1c4f635940b8510a896a667d4707c3d355d9c6fb81 arch=linux-rhel7-skylake - ^neuron@8.2.1%intel@2021.4.0+binary~caliper~codegenopt+coreneuron~debug~gpu~interviews~ipo+legacy-fr+legacy-unit+memacs+mod-compatibility+mpi~nmodl~openmp+python+report+rx3d+shared~sympy~sympyopt~tests~unified build_type=RelWithDebInfo model_tests=None patches=708cb04826b394a858069d93e8c08e1e81e914c23e1ef3da0486e8233834ff6c sanitizers=None arch=linux-rhel7-skylake - ^bison@3.8.2%intel@2021.4.0 arch=linux-rhel7-skylake ``` * I tried various spec changes in neuron and coreneuron but don't see any satisfactory change to force spack to use last release than develop. So as part of this commit, pin the last release whenever we are mixing compilers. ANYWAY, this will be removed with #1781.
pramodk
added a commit
that referenced
this pull request
Dec 14, 2022
* In #1777 we have made coreneuron optional for upcoming neuron > 8 releases: ``` depends_on("coreneuron+legacy-unit~caliper", when="@:8.99+coreneuron+legacy-unit~caliper") ... ``` * Because of this change, spack is now preferring develop version of neuron when we mix gcc with intel: ``` $ spack spec -I py-bluepyopt%gcc ^neuron%intel Input spec -------------------------------- - py-bluepyopt%gcc - ^neuron%intel Concretized -------------------------------- - py-bluepyopt@1.10.38%gcc@11.2.0+neuron patches=dc37639246b3a3320c840f1c4f635940b8510a896a667d4707c3d355d9c6fb81 arch=linux-rhel7-skylake - ^neuron@develop%intel@2021.4.0+binary~caliper~codegenopt+coreneuron~debug~gpu~interviews~ipo+legacy-fr+legacy-unit+memacs+mod-compatibility+mpi~nmodl~openmp+python+report+rx3d+shared~sympy~sympyopt~tests~unified build_type=RelWithDebInfo model_tests=None patches=708cb04826b394a858069d93e8c08e1e81e914c23e1ef3da0486e8233834ff6c sanitizers=None arch=linux-rhel7-skylake ``` but with single compiler, it uses last release correctly ``` $ spack spec -I py-bluepyopt ^neuron%intel Input spec -------------------------------- - py-bluepyopt - ^neuron%intel Concretized -------------------------------- - py-bluepyopt@1.10.38%intel@2021.4.0+neuron patches=dc37639246b3a3320c840f1c4f635940b8510a896a667d4707c3d355d9c6fb81 arch=linux-rhel7-skylake - ^neuron@8.2.1%intel@2021.4.0+binary~caliper~codegenopt+coreneuron~debug~gpu~interviews~ipo+legacy-fr+legacy-unit+memacs+mod-compatibility+mpi~nmodl~openmp+python+report+rx3d+shared~sympy~sympyopt~tests~unified build_type=RelWithDebInfo model_tests=None patches=708cb04826b394a858069d93e8c08e1e81e914c23e1ef3da0486e8233834ff6c sanitizers=None arch=linux-rhel7-skylake - ^bison@3.8.2%intel@2021.4.0 arch=linux-rhel7-skylake ``` * I tried various spec changes in neuron and coreneuron but don't see any satisfactory change to force spack to use last release than develop. So as part of this commit, pin the last release whenever we are mixing compilers. ANYWAY, this will be removed with #1781.
1 task
Author
|
I verified that |
iomaganaris
previously approved these changes
Dec 14, 2022
matz-e
suggested changes
Dec 14, 2022
Co-authored-by: Matthias Wolf <matthias.wolf@epfl.ch>
matz-e
previously approved these changes
Dec 14, 2022
Collaborator
|
To test your PR, use the following on BlueBrain5: unset MODULEPATH
. /gpfs/bbp.cscs.ch/ssd/apps/bsd/pulls/1781/config/modules.sh
module load unstablePlease test the following updated modules:
|
matz-e
approved these changes
Dec 14, 2022
iomaganaris
approved these changes
Dec 14, 2022
Collaborator
|
To test your PR, use the following on BlueBrain5: unset MODULEPATH
. /gpfs/bbp.cscs.ch/ssd/apps/bsd/pulls/1781/config/modules.sh
module load unstablePlease test the following updated modules:
|
heerener
pushed a commit
that referenced
this pull request
Jan 17, 2023
* Updated model-neocortex packages with latest 1.10 tag * add nmodl 0.5.a * remove coreneuron packages Co-authored-by: Ioannis Magkanaris <iomagkanaris@gmail.com> Co-authored-by: Matthias Wolf <matthias.wolf@epfl.ch>
heerener
pushed a commit
that referenced
this pull request
Jan 23, 2023
CoreNEURON: reduce memory usage in report initialization (#1776) Recipe changes to combine coreneuron into NEURON (#1777) * Bring coreneuron recipe options into neuron for coreneuron merge * remove dependency with coreneuron when neuron>=9.0 or develop * coreneuron variant is on by default in neuron * coreneuron mechanism library should always have different name than libcorenrnmech.so as it's now part of NEURON installation * do not add arch specific opt flags with +debug * Automatically bring coreneuron build_type=Debug when neuron+debug is used. This will simplify logic in blueconfig CI where we don't have to explicitly specify coreneuron dependency (especially as we have merged neuron and coreneuron) * Find "right" nrnivmodl-core binary for neurodamus building See relevant PR: neuronsimulator/nrn#2055 Deploy NEURON's upcoming 9.0a release (#1781) * Updated model-neocortex packages with latest 1.10 tag * add nmodl 0.5.a * remove coreneuron packages Co-authored-by: Ioannis Magkanaris <iomagkanaris@gmail.com> Co-authored-by: Matthias Wolf <matthias.wolf@epfl.ch> Update NEURON version (#1792) - Create NEURON version 9.0.a2 that includes bug fixes [Core]NEURON 8.2.2 (#1802) coreneuron: so long, and thanks for the fish. Coreneuron has been folded into neuRon and should not be referred to as a standalone package any more. Add py-sympy dependency at neuron package level newer spack doesn't seem to propogate python package dependencies (as PYTHONPATH) during build phase. neuron: omitted link flag for Caliper
heerener
pushed a commit
that referenced
this pull request
Jan 23, 2023
CoreNEURON: reduce memory usage in report initialization (#1776) Recipe changes to combine coreneuron into NEURON (#1777) * Bring coreneuron recipe options into neuron for coreneuron merge * remove dependency with coreneuron when neuron>=9.0 or develop * coreneuron variant is on by default in neuron * coreneuron mechanism library should always have different name than libcorenrnmech.so as it's now part of NEURON installation * do not add arch specific opt flags with +debug * Automatically bring coreneuron build_type=Debug when neuron+debug is used. This will simplify logic in blueconfig CI where we don't have to explicitly specify coreneuron dependency (especially as we have merged neuron and coreneuron) * Find "right" nrnivmodl-core binary for neurodamus building See relevant PR: neuronsimulator/nrn#2055 Deploy NEURON's upcoming 9.0a release (#1781) * Updated model-neocortex packages with latest 1.10 tag * add nmodl 0.5.a * remove coreneuron packages Co-authored-by: Ioannis Magkanaris <iomagkanaris@gmail.com> Co-authored-by: Matthias Wolf <matthias.wolf@epfl.ch> Update NEURON version (#1792) - Create NEURON version 9.0.a2 that includes bug fixes [Core]NEURON 8.2.2 (#1802) coreneuron: so long, and thanks for the fish. Coreneuron has been folded into neuRon and should not be referred to as a standalone package any more. Add py-sympy dependency at neuron package level newer spack doesn't seem to propogate python package dependencies (as PYTHONPATH) during build phase. neuron: omitted link flag for Caliper
matz-e
pushed a commit
that referenced
this pull request
Jan 25, 2023
CoreNEURON: reduce memory usage in report initialization (#1776) Recipe changes to combine coreneuron into NEURON (#1777) * Bring coreneuron recipe options into neuron for coreneuron merge * remove dependency with coreneuron when neuron>=9.0 or develop * coreneuron variant is on by default in neuron * coreneuron mechanism library should always have different name than libcorenrnmech.so as it's now part of NEURON installation * do not add arch specific opt flags with +debug * Automatically bring coreneuron build_type=Debug when neuron+debug is used. This will simplify logic in blueconfig CI where we don't have to explicitly specify coreneuron dependency (especially as we have merged neuron and coreneuron) * Find "right" nrnivmodl-core binary for neurodamus building See relevant PR: neuronsimulator/nrn#2055 Deploy NEURON's upcoming 9.0a release (#1781) * Updated model-neocortex packages with latest 1.10 tag * add nmodl 0.5.a * remove coreneuron packages Co-authored-by: Ioannis Magkanaris <iomagkanaris@gmail.com> Co-authored-by: Matthias Wolf <matthias.wolf@epfl.ch> Update NEURON version (#1792) - Create NEURON version 9.0.a2 that includes bug fixes [Core]NEURON 8.2.2 (#1802) coreneuron: so long, and thanks for the fish. Coreneuron has been folded into neuRon and should not be referred to as a standalone package any more. Add py-sympy dependency at neuron package level newer spack doesn't seem to propogate python package dependencies (as PYTHONPATH) during build phase. neuron: omitted link flag for Caliper
ferdonline
pushed a commit
to BlueBrain/neurodamus-models
that referenced
this pull request
Feb 14, 2024
Fix failure seen in BlueBrain/spack#1781
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also add knl variant in order to enable deployment of KNL modules. We will remove this variant when CMake of NEURON handles cross-compiling aspects where nocmodl should be compiled without ARCH specific optimization flags.