Skip to content
This repository was archived by the owner on Mar 25, 2025. It is now read-only.

Codegen for CVODE#1493

Merged
JCGoran merged 103 commits into
masterfrom
jelic/cvode_codegen_only
Oct 31, 2024
Merged

Codegen for CVODE#1493
JCGoran merged 103 commits into
masterfrom
jelic/cvode_codegen_only

Conversation

@JCGoran

@JCGoran JCGoran commented Oct 2, 2024

Copy link
Copy Markdown
Contributor

Actual codegen for CVODE. Requires #1467 (done), #1483 (done), #1484 (done)

@JCGoran JCGoran added the NEURON codegen Work toward NEURON code generation label Oct 2, 2024

@1uc 1uc left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! In terms of testing I suspect POINT_PROCESS and ARTIFICIAL_CELL might both behave in special ways, you can either include them now or fix them in separate PRs.

Comment thread src/codegen/codegen_neuron_cpp_visitor.cpp Outdated
Comment thread src/codegen/codegen_neuron_cpp_visitor.cpp Outdated
Comment thread src/codegen/codegen_neuron_cpp_visitor.cpp
Comment thread src/codegen/codegen_neuron_cpp_visitor.cpp
Comment thread src/codegen/codegen_neuron_cpp_visitor.cpp Outdated
Comment thread src/codegen/codegen_neuron_cpp_visitor.cpp Outdated
Comment thread src/codegen/codegen_neuron_cpp_visitor.cpp Outdated
Comment thread src/codegen/codegen_neuron_cpp_visitor.cpp Outdated
Comment thread test/usecases/cvode/test_cvode.py Outdated
Comment thread test/usecases/cvode/derivative.mod
@JCGoran JCGoran mentioned this pull request Oct 28, 2024
2 tasks
Goran Jelic-Cizmek added 3 commits October 28, 2024 13:27
Comment thread src/codegen/codegen_neuron_cpp_visitor.cpp Outdated
Goran Jelic-Cizmek added 2 commits October 28, 2024 14:56
It already exists in `CodegenCppVisitor`

@1uc 1uc left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done.

Comment thread src/codegen/codegen_neuron_cpp_visitor.hpp Outdated
Comment thread src/codegen/codegen_neuron_cpp_visitor.hpp Outdated
@JCGoran JCGoran merged commit 3df34b9 into master Oct 31, 2024
@JCGoran JCGoran deleted the jelic/cvode_codegen_only branch October 31, 2024 10:39
JCGoran added a commit to neuronsimulator/nrn that referenced this pull request Mar 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

NEURON codegen Work toward NEURON code generation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants