This repository was archived by the owner on Mar 25, 2025. It is now read-only.
Codegen for CVODE#1493
Merged
Merged
Conversation
added 23 commits
September 24, 2024 18:03
`DERIVATIVE` blocks can't have array variables in NOCMODL by default, so let's go with that.
Uses finite differences
added 6 commits
October 2, 2024 14:35
added 13 commits
October 21, 2024 23:03
1uc
reviewed
Oct 28, 2024
1uc
left a comment
Collaborator
There was a problem hiding this comment.
Nice work! In terms of testing I suspect POINT_PROCESS and ARTIFICIAL_CELL might both behave in special ways, you can either include them now or fix them in separate PRs.
added 3 commits
October 28, 2024 13:27
Must have semantics of type `cvodeieq` (see nrn/src/init.cpp)
1uc
reviewed
Oct 28, 2024
added 2 commits
October 28, 2024 14:56
It already exists in `CodegenCppVisitor`
1uc
approved these changes
Oct 29, 2024
added 2 commits
October 29, 2024 10:34
JCGoran
added a commit
to neuronsimulator/nrn
that referenced
this pull request
Mar 12, 2025
NMODL Repo SHA: BlueBrain/nmodl@3df34b9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actual codegen for CVODE. Requires #1467 (done), #1483 (done), #1484 (done)