This repository was archived by the owner on Mar 25, 2025. It is now read-only.
Add CvodeBlock and CvodeVisitor#1467
Merged
Merged
Conversation
DerivativeOriginalFunctionBlock and DerivativeVisitorDerivativeOriginalFunctionBlock and DerivativeOriginalVisitor
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Sep 24, 2024
1uc
reviewed
Sep 25, 2024
1uc
left a comment
Collaborator
There was a problem hiding this comment.
Two comments:
- The
DerivativeOriginalBlockis advertised as an unmodified copy. However, it's immediately during the process it's being modified. - There's no code demonstrating how this works, i.e. no tests or anything similar.
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Sep 25, 2024
added 2 commits
September 25, 2024 11:32
`DERIVATIVE` blocks can't have array variables in NOCMODL by default, so let's go with that.
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Sep 25, 2024
DerivativeOriginalFunctionBlock and DerivativeOriginalVisitorCvodeBlock and CvodeVisitor
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Sep 27, 2024
1uc
reviewed
Sep 30, 2024
added 10 commits
September 30, 2024 12:06
Uses finite differences
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Oct 14, 2024
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Oct 14, 2024
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Oct 15, 2024
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Oct 15, 2024
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Oct 16, 2024
1uc
reviewed
Oct 21, 2024
1uc
left a comment
Collaborator
There was a problem hiding this comment.
Looks quite good, a couple of last minor comments.
added 5 commits
October 21, 2024 16:02
Also use a set since we don't care about the actual index for the RHS
1uc
reviewed
Oct 24, 2024
1uc
approved these changes
Oct 25, 2024
JCGoran
added a commit
to neuronsimulator/nrn
that referenced
this pull request
Mar 12, 2025
NMODL Repo SHA: BlueBrain/nmodl@6b6a630
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1 of #1399.
Adds the CVODE block since NMODL solves the DERIVATIVE block in-place, and we lose information about it. Also adds a visitors which actually replaces statements of the form
x' = f(x)intoDx = f(x).