This repository was archived by the owner on Mar 25, 2025. It is now read-only.
CVODE codgen for NEURON#1399
Closed
JCGoran wants to merge 50 commits into
Closed
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1399 +/- ##
==========================================
- Coverage 86.65% 86.22% -0.44%
==========================================
Files 182 182
Lines 13626 13704 +78
==========================================
+ Hits 11808 11816 +8
- Misses 1818 1888 +70 ☔ View full report in Codecov by Sentry. |
0f3872e to
1eb8294
Compare
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Aug 15, 2024
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Aug 26, 2024
added 7 commits
August 26, 2024 14:41
Also do not declare NEURON symbol as extern inside of the namespace since it gets mangled, and we need the C-linked one from NEURON.
1eee28e to
9d09481
Compare
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Aug 26, 2024
This comment has been minimized.
This comment has been minimized.
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Aug 30, 2024
This comment has been minimized.
This comment has been minimized.
5137d2c to
fc63a84
Compare
This comment has been minimized.
This comment has been minimized.
added 7 commits
September 10, 2024 11:27
Information about the original form of the ODE system is irretrievably lost once the `SympySolverVisitor` or `NeuronSolveVisitor` run, so the solution is just to copy them over in some unused block right before we call those.
Still need to correct the codegen
f2617b4 to
96a63fd
Compare
added 27 commits
September 17, 2024 16:35
Also add debugging statements to logger
Contributor
Author
|
Closing in favor of #1493 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implementation works as follows:
DERIVATIVEblocks, and copy them intoDERIVATIVE_ORIGINAL_FUNCTIONandDERIVATIVE_ORIGINAL_JACOBIAN. This is done since thecnexp(and some other visitors) solve the ODEs in-place, so the information aboutf(x)(and consequently its Jacobian) is lost. Why two new constructs instead of one? Because NMODL cannot insert two identical blocks (it doesn't matter if they have a different name) in the symbol tableDERIVATIVE_ORIGINAL_FUNCTIONbasically replacesx' = f(x)withDx = f(x), whileDERIVATIVE_ORIGINAL_JACOBIANreplacesx' = f(x)withDx = Dx / (1 - dt * J(f)), whereJis the Jacobian of the transformation (computed analytically using SymPy)TODO: