This repository was archived by the owner on Mar 25, 2025. It is now read-only.
Add support for diffing expressions with indexed vars in differentiate2c#1483
Merged
Conversation
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Sep 30, 2024
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Sep 30, 2024
1uc
reviewed
Oct 1, 2024
1uc
approved these changes
Oct 1, 2024
1uc
left a comment
Collaborator
There was a problem hiding this comment.
one could still isolate it to make sure there's one notion of how to convert random stuff to symbols.
Contributor
Author
In principle yes, but I feel that it would undoubtedly involve a bunch of heuristics (much like what SymPy is actually doing under the hood anyway). The least error-prone idea is to just put |
Merged
added 2 commits
October 2, 2024 15:05
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Oct 2, 2024
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Oct 3, 2024
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Oct 3, 2024
JCGoran
added a commit
to neuronsimulator/nrn
that referenced
this pull request
Mar 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that the independent var we are diffing against should not be an indexed var (yet), but every other var is fair game.