Skip to content

Restore lost fork patches + fix 2.7.1 macOS/Win-ARM64 builds#480

Merged
BenJule merged 1 commit into
masterfrom
fix-2.7.1-platforms
Jun 6, 2026
Merged

Restore lost fork patches + fix 2.7.1 macOS/Win-ARM64 builds#480
BenJule merged 1 commit into
masterfrom
fix-2.7.1-platforms

Conversation

@BenJule

@BenJule BenJule commented Jun 6, 2026

Copy link
Copy Markdown
Owner

Closes #479

The 2.7.1 update (#476) used pure-2.7.1 versions for shared-feature files, which dropped fork-only patches 2.7.1 doesn't have. Nightly #27 surfaced the regressions. This restores them:

Patch Fixes
wxMediaCtrl3 BAMBUSTUDIO_NO_AVVIDEODECODER guard Windows-ARM64 LNK2001 (AVVideoDecoder)
zlib 1.2.13 → 1.3.1 macOS 26 SDK build (zError K&R)
MainFrame __WXGTK__ deferred geometry Wayland gtk_window_resize startup assertion
Preset parent-preset fallback no silent deletion of user presets
cd-nightly drop BambuStudio_dep_* ~800 MB internal deps leaked into release

Debian PR build verifies Linux compiles; macOS + Win-ARM64 verified by the nightly after merge.

@github-actions github-actions Bot added area: build Build system, CMake, scripts dependencies Dependency updates area: ui User interface / wxWidgets area: ci GitHub Actions, CI/CD area: slicing Slicing engine, toolpath generation labels Jun 6, 2026
@github-actions github-actions Bot added this to the v02.07.00-dev milestone Jun 6, 2026
@github-actions github-actions Bot added platform: linux Linux-specific issue platform: macos macOS-specific issue platform: windows Windows-specific issue labels Jun 6, 2026
The 2.7.1 update (#476) used pure-2.7.1 versions for shared-feature files,
dropping fork-only patches 2.7.1 does not provide. Nightly #27 surfaced the
build regressions. Restore them and harden the CD publish path:

- wxMediaCtrl3.cpp: restore #ifndef BAMBUSTUDIO_NO_AVVIDEODECODER guard
  (Win-ARM64 LNK2001: AVVideoDecoder excluded there, 2.7.1 uses it).
- deps/ZLIB 1.2.13 -> 1.3.1 (1.2.13 K&R decls break the macOS 26 SDK).
- MainFrame.cpp: restore __WXGTK__ deferred-geometry (Wayland startup assertion).
- Preset.cpp: restore parent-preset fallback (no silent user-preset deletion).
- cd-nightly.yml + cd-release-candidate.yml: drop BambuStudio_dep_* from the
  release (~800 MB; cd-release already did).
- cd-release-candidate.yml: apply the same signed-tag publish fix as #478
  (the local 'git tag -s' + git/refs API returned HTTP 422 'Object does not
  exist' — push the signed tag directly with a two-step API fallback).
@BenJule BenJule force-pushed the fix-2.7.1-platforms branch from 7bd032a to 6d4232d Compare June 6, 2026 03:42
BenJule added a commit that referenced this pull request Jun 6, 2026
Closes #481

The `Review dependency changes` job blocks all egress except
`api.github.com:443`, but `actions/checkout` needs `github.com:443` for
its git-fetch → checkout fails on every PR (#476, #480). Adds
`github.com:443` to the allowed-endpoints. Workflow-only change — no
build impact.
@BenJule BenJule merged commit 61ea7aa into master Jun 6, 2026
7 of 8 checks passed
@BenJule BenJule deleted the fix-2.7.1-platforms branch June 6, 2026 05:29
BenJule added a commit that referenced this pull request Jun 6, 2026
Closes #483

RC deps build failed on 5 platforms. Reverts the zlib 1.3.1 change from
#480 (broke the BUILD_SHARED_LIBS patch on Windows/Linux-ARM) and fixes
the *actual* macOS failure: Assimp's bundled zlib.
`ASSIMP_BUILD_ZLIB=OFF` on macOS/Linux → system zlib (matches
fix/10767).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: build Build system, CMake, scripts area: ci GitHub Actions, CI/CD area: slicing Slicing engine, toolpath generation area: ui User interface / wxWidgets dependencies Dependency updates platform: linux Linux-specific issue platform: macos macOS-specific issue platform: windows Windows-specific issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2.7.1: restore lost fork patches (Win-ARM64 / macOS / Wayland / preset safety)

1 participant