fix(deps): revert zlib 1.3.1 + Assimp system zlib (RC deps fix)#484
Merged
Conversation
The RC deps build failed on 5 platforms — two issues from the zlib change in #480: - zlib 1.2.13 -> 1.3.1 broke 0001-Respect-BUILD_SHARED_LIBS.patch ('patch does not apply: CMakeLists.txt:147') on Windows + Linux-ARM. Revert to 1.2.13 — the patch fits, and standalone zlib was never the macOS problem. - The real macOS failure is Assimp's BUNDLED zlib (contrib/zlib): its K&R declarations clash with the macOS 26 SDK. Set ASSIMP_BUILD_ZLIB=OFF on macOS/Linux so Assimp links the system zlib (kept ON for Windows). Matches the existing fix/10767-assimp-macos-zlib-build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #483
RC deps build failed on 5 platforms. Reverts the zlib 1.3.1 change from #480 (broke the BUILD_SHARED_LIBS patch on Windows/Linux-ARM) and fixes the actual macOS failure: Assimp's bundled zlib.
ASSIMP_BUILD_ZLIB=OFFon macOS/Linux → system zlib (matches fix/10767).