ci: allow github.com:443 in dependency-review egress#482
Merged
Conversation
The 'Review dependency changes' checkout failed to reach github.com even
with github.com:443 allow-listed ('domain not allowed: github.com'). The
list used a literal block (|) => newline-separated, which harden-runner
did not honour as separate endpoints. Switch to a folded block (>)
(whitespace-separated) and add github.com:443 — matching the working
detect_changes job in cd-nightly.
0c21c1a to
a5a6891
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #481
The
Review dependency changesjob blocks all egress exceptapi.github.com:443, butactions/checkoutneedsgithub.com:443for its git-fetch → checkout fails on every PR (#476, #480). Addsgithub.com:443to the allowed-endpoints. Workflow-only change — no build impact.