feat(reader-auth): send WP login reminder email to non-reader accounts by dkoo · Pull Request #3796 · Automattic/newspack-plugin

dkoo · 2025-03-05T00:25:21Z

All Submissions:

Have you followed the Newspack Contributing guideline?
Does your code follow the WordPress' coding standards and VIP Go coding standards?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

Addresses some persistent confusion expressed by publishers who are trying to use reader-based login and registration flows to log into their non-reader (admin, editor, author, etc.) accounts. In this scenario, we can send the user an email to remind them to log in via the regular WP login page instead of reader-facing UIs.

How to test the changes in this Pull Request:

Check out this branch.
Visit Newspack > Engagement > Reader Activation > Advanced Settings > Transactional Email Content and confirm there's a new "Non-reader account" email at the bottom of the list.

Edit this email and confirm it looks something like this:

In a new incognito session, attempt to register a reader account via the Registration block using an email address already associated with an admin, editor, or author user account. Confirm that you see the message that the account is already registered:

Check the email inbox associated with the email address and confirm that you got the reminder email as in step 3. Confirm that the "Continue to [Site Name]" button leads to the WP login form page.
In the incognito session, attempt to login and register via the "Sign In" modal. Confirm that you see the following when attempting to login or register, and that in either case you get the reminder email in the email address's inbox:

Logging in (note: we could show a message directing the user to check their email here instead, if desired):

Registering:

Update and save the email template in step 3, repeat steps 4-5, and confirm that the sent reminder email matches the updated content.
Try to register via the Sign In modal with an existing reader account email address and confirm that you see the following messages depending on whether the reader account has set a password:

Has a password:

No password:

Smoke test registering a new reader account and logging into an existing reader account using both password and OTP.

Other information:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your changes, as applicable?
Have you successfully ran tests with your changes locally?

adekbadek

publishers who are trying to use reader-based login and registration flows to log into their non-reader (admin, editor, author, etc.) accounts

I assume the reason for the email solution is because we don't want to enable fishing for admin email addresses. Just noting because I'd expect that noted somewhere, preferably in the code.

I think the reminder email content should be more explicit about using the /wp-admin link and point out that the user tried to use a login flow reserved for readers.

dkoo · 2025-03-21T22:55:56Z

Thanks for the feedback, @adekbadek! I've responded in the threads above.

dkoo · 2025-04-03T18:33:51Z

@adekbadek requesting another review on this when you have a chance!

adekbadek

Sorry for the late reply 🙈

Co-authored-by: Adam Cassis <adam@adamcassis.com>

github-actions · 2025-04-08T20:13:35Z

Hey @dkoo, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

miguelpeixe · 2025-04-22T21:39:13Z

 			return self::send_auth_form_response( new \WP_Error( 'unauthorized', wp_kses_post( __( 'Account not found. <a data-set-action="register" href="#register_modal">Create an account</a> instead?', 'newspack-plugin' ) ) ) );
 		}

+		if ( ! self::is_user_reader( $user ) ) {


This is not taking into account the account registration flow and will throw a fatal error if I attempt to register via the auth modal. Needs a ! $user check.

Fix at #3944

# [6.5.0-alpha.1](v6.4.4...v6.5.0-alpha.1) (2025-04-23) ### Bug Fixes * add white background to Newspack admin screens ([#3909](#3909)) ([4c8409e](4c8409e)) * allow guest contributors to have empty archives ([#3902](#3902)) ([af8bed9](af8bed9)) * **analytics:** migrate back-end GA4 events to front-end ([#3895](#3895)) ([7e18628](7e18628)) * **auth-form:** check user before is_user_reader() call ([#3944](#3944)) ([1cbb760](1cbb760)) * avoid warning for network event ([#3942](#3942)) ([60d0aa3](60d0aa3)) * **bylines:** avoid rerendering of editable area ([#3896](#3896)) ([9fdf659](9fdf659)) * **bylines:** custom edited state for modal ([#3919](#3919)) ([2a1a800](2a1a800)) * **bylines:** get CAP data from the plugin's store ([#3906](#3906)) ([0745113](0745113)) * **corrections:** Limit CPT to posts only ([#3927](#3927)) ([1d49c39](1d49c39)) * **corrections:** Use Corrections Archive template by default ([#3929](#3929)) ([c4c1925](c4c1925)) * **email-change:** ensure success and error messages persist after redirect ([#3913](#3913)) ([caf82a5](caf82a5)) * **email-change:** improve messaging for in-progress or expired change requests ([#3886](#3886)) ([02d2ea0](02d2ea0)) * **email-change:** typo in variable name ([#3941](#3941)) ([941dc21](941dc21)) * **google-login:** handle google oauth disabled state in the editor ([#3946](#3946)) ([0f9f7c6](0f9f7c6)) * hide campaigns menu when the Newspack Campaigns plugin is not activated ([#3922](#3922)) ([adcc21f](adcc21f)) * make front end not dependent on coauthors plus ([#3905](#3905)) ([dc96e5b](dc96e5b)) * **otp-input:** enhance OTP input handling for clipboard ([#3898](#3898)) ([a56328b](a56328b)) * reinstate the Add New Newsletter link in the admin menu ([#3926](#3926)) ([1c8c7d7](1c8c7d7)) * remove extra space above empty help text ([#3904](#3904)) ([6a4fe4f](6a4fe4f)) * remove import and route for Suppression ([#3894](#3894)) ([a2034e7](a2034e7)) * **setup-wizard:** prevent Yoast redirect ([#3940](#3940)) ([3461b5f](3461b5f)) ### Features * **auth:** OTP autocomplete integration ([#3888](#3888)) ([5a1d7a8](5a1d7a8)) * **bylines:** get post byline authors ([#3911](#3911)) ([17942a2](17942a2)) * **bylines:** useAuthorTokens() hook with user entity validation ([#3907](#3907)) ([3d1feee](3d1feee)) * **email-change:** allow old email to cancel email change only, not confirm ([#3912](#3912)) ([92413e3](92413e3)) * **ga4:** np_newsletter_subscribed event upon front-end signup ([#3938](#3938)) ([2295277](2295277)) * **ras-newsletter:** Newsletters list progressive disclosure ([#3887](#3887)) ([53f4eed](53f4eed)) * **reader-auth:** send WP login reminder email to non-reader accounts ([#3796](#3796)) ([d1af25e](d1af25e)), closes [#3823](#3823) * **scss:** export colors as module for JS consumption ([#3910](#3910)) ([81da8f0](81da8f0)) * **segments:** add filter for device segment ([#3880](#3880)) ([d465726](d465726)) * update colors and add all design system variables ([#3882](#3882)) ([6ee8e30](6ee8e30))

matticbot · 2025-04-23T17:57:30Z

🎉 This PR is included in version 6.5.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

# [6.6.0-alpha.1](v6.5.0...v6.6.0-alpha.1) (2025-05-08) ### Bug Fixes * add white background to Newspack admin screens ([#3909](#3909)) ([4c8409e](4c8409e)) * allow guest contributors to have empty archives ([#3902](#3902)) ([af8bed9](af8bed9)) * **analytics:** migrate back-end GA4 events to front-end ([#3895](#3895)) ([7e18628](7e18628)) * **auth-form:** check user before is_user_reader() call ([#3944](#3944)) ([1cbb760](1cbb760)) * avoid warning for network event ([#3942](#3942)) ([60d0aa3](60d0aa3)) * **bylines:** avoid rerendering of editable area ([#3896](#3896)) ([9fdf659](9fdf659)) * **bylines:** custom edited state for modal ([#3919](#3919)) ([2a1a800](2a1a800)) * **bylines:** get CAP data from the plugin's store ([#3906](#3906)) ([0745113](0745113)) * **corrections:** Limit CPT to posts only ([#3927](#3927)) ([1d49c39](1d49c39)) * **corrections:** Use Corrections Archive template by default ([#3929](#3929)) ([c4c1925](c4c1925)) * **email-change:** ensure success and error messages persist after redirect ([#3913](#3913)) ([caf82a5](caf82a5)) * **email-change:** improve messaging for in-progress or expired change requests ([#3886](#3886)) ([02d2ea0](02d2ea0)) * **email-change:** typo in variable name ([#3941](#3941)) ([941dc21](941dc21)) * **ga4:** ensure gate_post_id and newspack_popup_id are passed to activities ([#3956](#3956)) ([fadaa4d](fadaa4d)) * **google-login:** handle google oauth disabled state in the editor ([#3946](#3946)) ([0f9f7c6](0f9f7c6)) * hide campaigns menu when the Newspack Campaigns plugin is not activated ([#3922](#3922)) ([adcc21f](adcc21f)) * make front end not dependent on coauthors plus ([#3905](#3905)) ([dc96e5b](dc96e5b)) * **newsletters-wizard:** remove advertisers menu item ([#3948](#3948)) ([2fddbd6](2fddbd6)) * **otp-input:** enhance OTP input handling for clipboard ([#3898](#3898)) ([a56328b](a56328b)) * reinstate the Add New Newsletter link in the admin menu ([#3926](#3926)) ([1c8c7d7](1c8c7d7)) * remove extra space above empty help text ([#3904](#3904)) ([6a4fe4f](6a4fe4f)) * remove import and route for Suppression ([#3894](#3894)) ([a2034e7](a2034e7)) * **setup-wizard:** prevent Yoast redirect ([#3940](#3940)) ([3461b5f](3461b5f)) ### Features * **auth:** OTP autocomplete integration ([#3888](#3888)) ([5a1d7a8](5a1d7a8)) * **bylines:** get post byline authors ([#3911](#3911)) ([17942a2](17942a2)) * **bylines:** useAuthorTokens() hook with user entity validation ([#3907](#3907)) ([3d1feee](3d1feee)) * **email-change:** allow old email to cancel email change only, not confirm ([#3912](#3912)) ([92413e3](92413e3)) * **ga4:** np_newsletter_subscribed event upon front-end signup ([#3938](#3938)) ([2295277](2295277)) * **ras-newsletter:** Newsletters list progressive disclosure ([#3887](#3887)) ([53f4eed](53f4eed)) * **reader-auth:** send WP login reminder email to non-reader accounts ([#3796](#3796)) ([d1af25e](d1af25e)), closes [#3823](#3823) * **scss:** export colors as module for JS consumption ([#3910](#3910)) ([81da8f0](81da8f0)) * **segments:** add filter for device segment ([#3880](#3880)) ([d465726](d465726)) * update colors and add all design system variables ([#3882](#3882)) ([6ee8e30](6ee8e30))

matticbot · 2025-05-08T17:12:40Z

🎉 This PR is included in version 6.6.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

# [6.6.0](v6.5.1...v6.6.0) (2025-05-14) ### Bug Fixes * add white background to Newspack admin screens ([#3909](#3909)) ([4c8409e](4c8409e)) * allow guest contributors to have empty archives ([#3902](#3902)) ([af8bed9](af8bed9)) * **analytics:** migrate back-end GA4 events to front-end ([#3895](#3895)) ([7e18628](7e18628)) * **auth-form:** check user before is_user_reader() call ([#3944](#3944)) ([1cbb760](1cbb760)) * avoid warning for network event ([#3942](#3942)) ([60d0aa3](60d0aa3)) * **bylines:** avoid rerendering of editable area ([#3896](#3896)) ([9fdf659](9fdf659)) * **bylines:** custom edited state for modal ([#3919](#3919)) ([2a1a800](2a1a800)) * **bylines:** get CAP data from the plugin's store ([#3906](#3906)) ([0745113](0745113)) * **corrections:** Limit CPT to posts only ([#3927](#3927)) ([1d49c39](1d49c39)) * **corrections:** Use Corrections Archive template by default ([#3929](#3929)) ([c4c1925](c4c1925)) * **email-change:** ensure success and error messages persist after redirect ([#3913](#3913)) ([caf82a5](caf82a5)) * **email-change:** improve messaging for in-progress or expired change requests ([#3886](#3886)) ([02d2ea0](02d2ea0)) * **email-change:** typo in variable name ([#3941](#3941)) ([941dc21](941dc21)) * **ga4:** ensure gate_post_id and newspack_popup_id are passed to activities ([#3956](#3956)) ([fadaa4d](fadaa4d)) * **google-login:** handle google oauth disabled state in the editor ([#3946](#3946)) ([0f9f7c6](0f9f7c6)) * hide campaigns menu when the Newspack Campaigns plugin is not activated ([#3922](#3922)) ([adcc21f](adcc21f)) * make front end not dependent on coauthors plus ([#3905](#3905)) ([dc96e5b](dc96e5b)) * **newsletters-wizard:** remove advertisers menu item ([#3948](#3948)) ([2fddbd6](2fddbd6)) * **otp-input:** enhance OTP input handling for clipboard ([#3898](#3898)) ([a56328b](a56328b)) * reinstate the Add New Newsletter link in the admin menu ([#3926](#3926)) ([1c8c7d7](1c8c7d7)) * remove extra space above empty help text ([#3904](#3904)) ([6a4fe4f](6a4fe4f)) * remove import and route for Suppression ([#3894](#3894)) ([a2034e7](a2034e7)) * **setup-wizard:** prevent Yoast redirect ([#3940](#3940)) ([3461b5f](3461b5f)) ### Features * **auth:** OTP autocomplete integration ([#3888](#3888)) ([5a1d7a8](5a1d7a8)) * **bylines:** get post byline authors ([#3911](#3911)) ([17942a2](17942a2)) * **bylines:** useAuthorTokens() hook with user entity validation ([#3907](#3907)) ([3d1feee](3d1feee)) * **email-change:** allow old email to cancel email change only, not confirm ([#3912](#3912)) ([92413e3](92413e3)) * **email-change:** remove env constant requirement ([#3943](#3943)) ([f04e58f](f04e58f)) * **ga4:** np_newsletter_subscribed event upon front-end signup ([#3938](#3938)) ([2295277](2295277)) * **ras-newsletter:** Newsletters list progressive disclosure ([#3887](#3887)) ([53f4eed](53f4eed)) * **reader-auth:** send WP login reminder email to non-reader accounts ([#3796](#3796)) ([d1af25e](d1af25e)), closes [#3823](#3823) * **scss:** export colors as module for JS consumption ([#3910](#3910)) ([81da8f0](81da8f0)) * **segments:** add filter for device segment ([#3880](#3880)) ([d465726](d465726)) * update colors and add all design system variables ([#3882](#3882)) ([6ee8e30](6ee8e30))

matticbot · 2025-05-14T17:30:51Z

🎉 This PR is included in version 6.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

adekbadek and others added 3 commits March 4, 2025 15:38

fix: is-without-password condition

6a880cd

test: fix assertion

2306ed0

feat(reader-auth): send WP login reminder email to non-reader accounts

a5c49be

dkoo added the [Status] Needs Review The issue or pull request needs to be reviewed label Mar 5, 2025

dkoo self-assigned this Mar 5, 2025

dkoo requested a review from a team as a code owner March 5, 2025 00:25

fix: standardize existing account messaging

9e506ab

adekbadek mentioned this pull request Mar 6, 2025

fix: is-without-password condition #3794

Closed

6 tasks

Merge branch 'trunk' into fix/non-reader-login-reminder

365ec41

adekbadek changed the base branch from fix/ras-sign-in to trunk March 21, 2025 10:53

adekbadek requested changes Mar 21, 2025

View reviewed changes

Comment thread includes/templates/reader-activation-emails/non-reader.php Outdated

Comment thread includes/reader-activation/class-reader-activation.php Outdated

adekbadek added [Status] Needs Changes or Feedback The issue or pull request needs action from the original creator and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Mar 21, 2025

leogermani and others added 4 commits March 21, 2025 16:49

feat: add custom check for media visibility (#3823)

f1f203a

fix: template placeholders in email html

8a827ac

docs: add comment explaining new behavior

458121d

fix: clearer non-reader reminder message

8f96cc4

dkoo requested a review from adekbadek March 21, 2025 22:55

adekbadek requested changes Apr 7, 2025

View reviewed changes

Comment thread includes/templates/reader-activation-emails/non-reader.php Outdated

Comment thread includes/reader-activation/class-reader-activation.php Outdated

dkoo and others added 4 commits April 7, 2025 13:23

Merge branch 'trunk' into fix/non-reader-login-reminder

b7256f4

fix: translate hidden unstyled email text

07336c8

Update includes/reader-activation/class-reader-activation.php

f47d115

Co-authored-by: Adam Cassis <adam@adamcassis.com>

fix: missing category after IA merge

b875c48

adekbadek approved these changes Apr 8, 2025

View reviewed changes

github-actions Bot added the [Status] Approved The pull request has been reviewed and is ready to merge label Apr 8, 2025

dkoo merged commit d1af25e into trunk Apr 8, 2025

dkoo deleted the fix/non-reader-login-reminder branch April 8, 2025 20:13

github-actions Bot added the needs-changelog label Apr 8, 2025

dkoo mentioned this pull request Apr 21, 2025

fix(auth-modal): only send non-reader reminder if existing user account found #3937

Closed

6 tasks

miguelpeixe reviewed Apr 22, 2025

View reviewed changes

miguelpeixe mentioned this pull request Apr 22, 2025

fix(auth-form): check user before is_user_reader() call #3944

Merged

6 tasks

dkoo mentioned this pull request Apr 22, 2025

fix(auth-modal): prevent fatal due to nonexistent user #3945

Closed

6 tasks

matticbot added the released on @alpha label Apr 23, 2025

leogermani removed the needs-changelog label Apr 25, 2025

matticbot added the released label May 14, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(reader-auth): send WP login reminder email to non-reader accounts#3796

feat(reader-auth): send WP login reminder email to non-reader accounts#3796
dkoo merged 13 commits into
trunkfrom
fix/non-reader-login-reminder

dkoo commented Mar 5, 2025 •

edited by adekbadek

Loading

Uh oh!

adekbadek left a comment

Uh oh!

Uh oh!

Uh oh!

dkoo commented Mar 21, 2025

Uh oh!

dkoo commented Apr 3, 2025

Uh oh!

adekbadek left a comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Apr 8, 2025

Uh oh!

miguelpeixe Apr 22, 2025

Uh oh!

miguelpeixe Apr 22, 2025

Uh oh!

matticbot commented Apr 23, 2025

Uh oh!

matticbot commented May 8, 2025

Uh oh!

matticbot commented May 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

dkoo commented Mar 5, 2025 • edited by adekbadek Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

All Submissions:

Changes proposed in this Pull Request:

How to test the changes in this Pull Request:

Other information:

Uh oh!

adekbadek left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dkoo commented Mar 21, 2025

Uh oh!

dkoo commented Apr 3, 2025

Uh oh!

adekbadek left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Apr 8, 2025

Uh oh!

miguelpeixe Apr 22, 2025

Choose a reason for hiding this comment

Uh oh!

miguelpeixe Apr 22, 2025

Choose a reason for hiding this comment

Uh oh!

matticbot commented Apr 23, 2025

Uh oh!

matticbot commented May 8, 2025

Uh oh!

matticbot commented May 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dkoo commented Mar 5, 2025 •

edited by adekbadek

Loading