Likes: Bust iframe cache to facilitate string fix#8228
Conversation
jeherve
left a comment
There was a problem hiding this comment.
Thanks!
Let's merge this as soon as D8423-code gets committed.
| */ | ||
| function jetpack_likes_master_iframe() { | ||
| $version = '20170629'; | ||
| $version = '20171122v2'; |
There was a problem hiding this comment.
I don't remember running into v2 appended to date in rest of the codebase. Is there some specific reason for this, and could we just use 20171123 instead?
There was a problem hiding this comment.
Actually I think we can also use JETPACK__VERSION here to avoid the need to bump this manually in the future. Not sure if it would cause issues for Post Likes though. /cc @pento
There was a problem hiding this comment.
could we just use 20171123 instead?
At this point, sure, we're onto that date. I did v2 as I seemed to cache a bad variant I tested with under 20171122.
|
One thing I noticed while testing is that with new translations some longer strings are cropped due to fixed
We can work around this by changing the width here to |
We need to pull down new translations for comment likes.
dc1753e to
e1371b6
Compare
I am a little confused so, sounds good, let's do that if you would. I didn't see the issue on my test site:
|
Will do it. 👍 It only occurs when you have |
* Changelog 5.6: create base for changelog. * Update changelog with 5.5.1 info. * Changelog: add #7930 and #8238 * Changelog: add #8076 * Changelog: add #8100 * Changelog: add #8117 * Changelog: add #8141 * Changelog: add #8143 * Changelog: add #8147 * Changelog: add #8149 * Changelog: add #8153 * Changelog: add #8173 * Changelog: add #8184 * Changelog: add #8196 * Changelog: add #8199 * Changelog: add #8093 * Changelog: add #8171 * Changelog: add #8182 * Changelog: add #8202, #8222 * Changelog: add #8228 * Changelog: add #8240 * Changelog: add #8251 * remove AL card change
We need to pull down new translations for comment likes.
Fixes #7958
Changes proposed in this Pull Request:
From the backend [when cache is busted]:
ifs inlikes-rest.js.Testing instructions:
Proposed changelog entry for your changes:
Fixed comment likes localization bugs.