Related Posts: Define array before foreach loop#8147
Merged
oskosk merged 1 commit intoAutomattic:masterfrom Nov 13, 2017
Umangvaghela:issue-8030
Merged
Related Posts: Define array before foreach loop#8147oskosk merged 1 commit intoAutomattic:masterfrom Umangvaghela:issue-8030
oskosk merged 1 commit intoAutomattic:masterfrom
Umangvaghela:issue-8030
Conversation
Contributor
Author
|
Sir , When you get a time so please review it and give your feedback if i miss something. Thanks |
Member
|
Thanks for the PR. Quick remark: you do not need to ping specific people to get a review on your PRs. They will all be reviewed! |
zinigor
approved these changes
Nov 13, 2017
Contributor
zinigor
left a comment
There was a problem hiding this comment.
Definitely makes sense to define the array outside of the foreach loop :) Thank you!
oskosk
approved these changes
Nov 13, 2017
Contributor
oskosk
left a comment
There was a problem hiding this comment.
Thanks for the fix @Umangvaghela . LGTM!
oskosk
pushed a commit
that referenced
this pull request
Nov 28, 2017
* Changelog 5.6: create base for changelog. * Update changelog with 5.5.1 info. * Changelog: add #7930 and #8238 * Changelog: add #8076 * Changelog: add #8100 * Changelog: add #8117 * Changelog: add #8141 * Changelog: add #8143 * Changelog: add #8147 * Changelog: add #8149 * Changelog: add #8153 * Changelog: add #8173 * Changelog: add #8184 * Changelog: add #8196 * Changelog: add #8199 * Changelog: add #8093 * Changelog: add #8171 * Changelog: add #8182 * Changelog: add #8202, #8222 * Changelog: add #8228 * Changelog: add #8240 * Changelog: add #8251 * remove AL card change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #8030
The excluded_post_ids array is getting reset each time in the foreach loop, so it is good to define excluded_post_ids array before foreach loop then we overcome the issue.
Thanks