Update DN to use shortened rewards challenge IDs and specifiers by rickyrombo · Pull Request #9803 · AudiusProject/apps

rickyrombo · 2024-09-19T23:01:07Z

Description

Shortens the final "disbursement ID" to enable single transaction challenge rewards claiming. We need to hit a target of < 22 bytes per disbursement ID in order for all 4 submit attestation instructions (including their SECP instruction pair) + the evaluate instruction to fit into a single transaction.

Note: the use of hashIds here locks us in a bit more to hashIds
Note: changing these IDs and specifiers effectively makes these rewards reclaimable on the program side, as their disbursement accounts will be different. However, I'm migrating the disbursements table as well so DNs should not attest to previously disbursed challenges.

DO NOT MERGE: Client first needs to be upgraded to use these new IDs/specifiers! See #9801

Migrates old challenge ID and specifiers to new format w/ 1-2 character challenge IDs and hash encoded user/track IDs
Updates all challenges to use the new IDs and specifiers in indexing
Updates all configs to use the new IDs

How Has This Been Tested?

Tested against #9801 locally after pasting one of each possible type of user_challenge into the db from prod to test the migration

RELEASE PLAN

Let Add client support for single transaction reward claiming #9801 sit for a bit, then force upgrade to its client version before releasing this to DN. Anti abuse needs to be updated prior as well

changeset-bot · 2024-09-19T23:01:11Z

⚠️ No Changeset found

Latest commit: cefb18c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

…ent-ids

dharit-tan

noice

sliptype · 2024-09-20T19:59:26Z

packages/discovery-provider/ddl/migrations/0095_shorten_challenge_ids.sql

+DROP FUNCTION if exists hashids.decode(text, text);
+DROP FUNCTION if exists hashids.decode(text);
+
+-- constent shuffle


Suggested change

-- constent shuffle

-- consistent shuffle

although this is copied from elsewhere maybe

sliptype · 2024-09-20T20:00:21Z

packages/discovery-provider/ddl/migrations/0095_shorten_challenge_ids.sql

wow this file is intense

yeah it's mostly a copy paste of the hashids function sql file... I think there's probably a better way to do this... @stereosteve any thoughts?

not intense anymore!

isaacsolo · 2024-09-23T17:17:05Z

packages/discovery-provider/ddl/migrations/0095_shorten_challenge_ids.sql

@@ -0,0 +1,863 @@
+--


maybe an issue this isn't all in one transaction?

yeah good point!

gitguardian · 2024-09-24T01:14:25Z

⚠️ GitGuardian has uncovered 11 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
9412812	Triggered	Generic Password	`bdc5a7b`	packages/discovery-provider/ddl/docker-compose.yml	View secret
9412812	Triggered	Generic Password	`f10cbde`	cmd/core/infra/docker-compose.yml	View secret
9412812	Triggered	Generic Password	`f10cbde`	core/infra/docker-compose.yml	View secret
11648676	Triggered	Generic High Entropy Secret	`64f2a9f`	dev-tools/templates/devnet.yaml	View secret
11648676	Triggered	Generic High Entropy Secret	`f10cbde`	cmd/core/infra/dev_config/prod-sandbox.env	View secret
11648676	Triggered	Generic High Entropy Secret	`f10cbde`	cmd/core/infra/dev_config/sandbox-one.env	View secret
11648676	Triggered	Generic High Entropy Secret	`f10cbde`	cmd/core/infra/dev_config/stage-sandbox.env	View secret
11648676	Triggered	Generic High Entropy Secret	`f10cbde`	cmd/core/infra/dev_config/dev-sandbox.env	View secret
11648679	Triggered	Generic High Entropy Secret	`f10cbde`	cmd/core/infra/dev_config/standalone-console.env	View secret
11648680	Triggered	Generic High Entropy Secret	`64f2a9f`	dev-tools/templates/devnet.yaml	View secret
13858032	Triggered	Generic Private Key	`64f2a9f`	dev-tools/tls/devnet-key.pem	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

…ent-ids

schottra · 2024-09-24T15:17:05Z

packages/discovery-provider/integration_tests/challenges/test_connect_verified_challenge.py

    with db.scoped_session() as session:
        bus = ChallengeEventBus(redis_conn)
-        session.query(Challenge).filter(Challenge.id == "connect-verified").update(
+        session.query(Challenge).filter(Challenge.id == "v").update(


Similar suggestion to changes in the other PR: Using some constants here to make the code more readable would be appreciated.

…ent-ids

…mpletion

…rs (#9803)" This reverts commit abf3634.

…rs (#9803)" (#10099)

…ers (#9803)" (#10099) This reverts commit 127070e.

[127070e] Revert "Update DN to use shortened rewards challenge IDs and specifiers (#9803)" (#10099) Marcus Pasell [14fba3b] Fix typo in migration (#10097) Marcus Pasell [4732864] Fix migration for challenge shortening (#10094) Marcus Pasell [95b738c] Validate comment mentions (#10088) Isaac Solo [abf3634] Update DN to use shortened rewards challenge IDs and specifiers (#9803) Marcus Pasell [f423dd0] [C-5189] Fix react and reply comment count (#10075) Isaac Solo [e4b1895] [PAY-3518] Get new blasts after inbox settings change (#10074) Steve Perkins

[6240380] Fix comment notification data (#10123) Dylan Jeffers [8c9b00b] [QA-1737] Center user links in collection and user cards (#10122) Dylan Jeffers [109abfa] [C-5197] Fix native comment show more/less collapse (#10121) Dylan Jeffers [c971230] [C-5212] Open comment drawer from empty state (#10117) Sebastian Klingler [528102b] Fix discovery comment notifications (#10119) Dylan Jeffers [9fe6c66] [PAY-3522] Hides keyboard when opening purchase drawer from a DM (#10116) Randy Schott [69e73dd] Re-land changes to fix RN on xcode 16 (#10108) Randy Schott [906dc0b] [QA-1773] Fix corner overflow on GiantTrackTile (#10110) Andrew Mendelsohn [7f97ca2] [C-5209] Missing $ on downloads button (#10111) Andrew Mendelsohn [b3e1982] Drop Android InputAccessoryView (#10107) Dylan Jeffers [9bd3d6c] [C-5189] Fix mobile web skeletons (#10106) JD Francis [ee775d1] Fix mobile cursor position (#10104) Dylan Jeffers [761524e] Various comment reply fixes (muting/reporting) (#10096) JD Francis [98e7bd5] Add CommentDrawerContext to manage drawer state with navigation (#10103) Sebastian Klingler [e488758] [C-5203] Fix comment unpin (#10102) Dylan Jeffers [e8cdd08] Update mobile versions to 119 (#10101) Dylan Jeffers [966246f] [C-5137] Set android cursor position when replying/editing (#10091) Sebastian Klingler [127070e] Revert "Update DN to use shortened rewards challenge IDs and specifiers (#9803)" (#10099) Marcus Pasell [a921f74] [C-5112] Dismiss keyboard when pressing in comment drawer (#10093) Sebastian Klingler [d65ce1f] Improve mobile composer input render perf (#10095) Raymond Jacobson [2b0c76c] [PAY-3525] Fix text overflow (#10072) Farid Salau [ddd3f94] Fix chat header too long on mobile (#10089) Reed [42553e6] [PAY-3507] Skeleton for profile dms button (#10090) Andrew Mendelsohn [abf3634] Update DN to use shortened rewards challenge IDs and specifiers (#9803) Marcus Pasell [4b293d8] [C-5193] Add cancel button to comment replies and edits (#10080) Kyle Shanks [c5fd316] [C-5191] Add background color to comment cancel accessory view (#10078) Kyle Shanks [2f3b7ab] [PAY-3456] Fix chat last message sometimes wrong (#10084) Reed [0ac87a0] [PAY-3519] Fix mobile ChatBlastSubHeader opacity (#10079) Reed [9f3804b] Fix android animated icons (#10085) Dylan Jeffers [c0eca98] [PAY-3526] Hide scroll on message inbox (#10083) Farid Salau [f580ff7] [PAY-3509] Show InboxUnavailableModal instead of disabled button (#10081) Andrew Mendelsohn [3ae1af1] [PAY-3521] Fix offset calculation for Blast CTA (#10076) Andrew Mendelsohn [814fa37] Highlight user mentions when editing comments on web (#10077) Kyle Shanks [3144eac] [PAY-3424] Restrict imports from SDK 'dist' folder in client code (#10043) Randy Schott [8aa7242] [PAY-3523] Fix bug where share to DM persists in input (#10070) Raymond Jacobson [9812ee2] Update dapp-store build artifacts audius-infra [bfd21d8] Fix mobile lint (#10071) Raymond Jacobson [55c22f4] [PAY-3466] Improve composer input responsiveness on mobile (#10066) Raymond Jacobson [3c0ce0f] [QA-1762] Fix desktop app support on MacOS Sequoia (#10059) Raymond Jacobson [af09710] [C-5167] Improve mobile comments perf (#10067) Sebastian Klingler [29e9b01] [C-5178] Show newlines in comments (#10065) Isaac Solo [61e8734] Fix comment unauthed state (#10061) JD Francis [d355040] Fix lint (#10064) Andrew Mendelsohn [7023824] [PAY-3520] Fix error on blast analytics (#10063) Andrew Mendelsohn [4588410] [C-5166] [C-5108] [C-5156] Address comment QA issues (#10047) Sebastian Klingler [7494a1a] [PAY-3437] Add names to chats sentry reports (#10049) Reed [856d223] [PAY-3347] Analytics for create chat blast funnel (#10053) Andrew Mendelsohn [6401b5c] [PAY-3483] Update 'ChatListBlastItem' UI on smaller screens (#10057) Farid Salau [058e233] [C-5172] Fix comments timezone (#10052) Isaac Solo [7ce770c] [C-5155] Add cancel accessory to mobile ComposerInput for comments (#10058) Kyle Shanks [f992ddb] [C-5173] Fix sort by top comments out of date (#10055) JD Francis [bf6b4a8] [C-5184] Add border to Harmony PopoverMenu (#10050) Kyle Shanks [c1a5488] [C-5161 C-5151] Improve desktop track page responsiveness (#10040) Dylan Jeffers [5de96ce] [C-5141] Generate comment id in onMutate (#10031) Dylan Jeffers [db3f11a] [⚠️] Separate SDK and legacy libs (#9972) Raymond Jacobson [e01490c] Fix withdrawals not showing coinflow modal (#10051) Marcus Pasell [1cce513] Remove follows you badge from comment settings (#10024) Isaac Solo [cb76182] [C-5165] Update comment notifications to open the comment drawer (#10039) Dylan Jeffers [7e7acc9] [QA-1761] Fix mobile profile page username spacing (#10038) Dylan Jeffers [59a1d97] [C-5040] Enable animated mobile icons (#10037) Dylan Jeffers [4d09265] [C-5164] Add max height to mobile ComposerInput (#10044) Kyle Shanks [7d7008c] [C-5153] Update ComposerInput to not render the display layer unless there is highlighted text (#10042) Kyle Shanks [e72e207] Upgrade mobile version to 1.1.118 (#10035) Dylan Jeffers

…and specifiers (#9803)" (#10099) (#10158)

[d49bb52] Add more guards to the migration for idempotency (#10259) Marcus Pasell [263569e] Include specifiers for Audio Match in migration (#10258) Marcus Pasell [7a5772e] Don't rollback the migration (#10256) Marcus Pasell [e9c3e94] [C-5310] Fix comment notifications with explicit type (#10242) Dylan Jeffers [737bec0] Fix validations for unreact comment (#10246) Isaac Solo [a2803dd] [PAY-3469] Reapply "Update DN to use shortened rewards challenge IDs and specifiers (#9803)" (#10099) (#10158) Marcus Pasell [f5e01e0] Revert "Add X-Forwarded-Proto to nginx config to fix resolve endpoint (#10239)" (#10251) Marcus Pasell [0d445df] Use msgpack between servers. (#10244) Steve Perkins

* origin/main: (78 commits) Remove SEARCH_V2 feature flag (#10264) Fix eth-bridge, consolidate Makefile, remove cruft (#10212) [C-5309] Reset comment form text on location change (#10263) [PAY-3516] Remove is_stream_gated and is_download_gated (#10146) [PAY-3545] Add cover attribution and song ownership to track upload (#10184) Audius Protocol v0.7.22 Add more guards to the migration for idempotency (#10259) Include specifiers for Audio Match in migration (#10258) Don't rollback the migration (#10256) [C-5314] Add load states for comment display names & avatars (#10255) [C-5310] Fix comment notifications with explicit type (#10242) Fix mobile harmony button xs size (#10243) Bump max audio size to 500mb (#10252) Upgrade mobile version to 1.1.121 (#10254) Fix validations for unreact comment (#10246) [PAY-3469] Reapply "Update DN to use shortened rewards challenge IDs and specifiers (#9803)" (#10099) (#10158) Fix purchases with external wallet and wallet adapter (#10087) Make Text component respect theme typography (#10086) Revert "Add X-Forwarded-Proto to nginx config to fix resolve endpoint (#10239)" (#10251) Not hardcoded file limit error message (#10247) ...

…rs (#9803)" (#10099)

[127070e] Revert "Update DN to use shortened rewards challenge IDs and specifiers (#9803)" (#10099) Marcus Pasell [14fba3b] Fix typo in migration (#10097) Marcus Pasell [4732864] Fix migration for challenge shortening (#10094) Marcus Pasell [95b738c] Validate comment mentions (#10088) Isaac Solo [abf3634] Update DN to use shortened rewards challenge IDs and specifiers (#9803) Marcus Pasell [f423dd0] [C-5189] Fix react and reply comment count (#10075) Isaac Solo [e4b1895] [PAY-3518] Get new blasts after inbox settings change (#10074) Steve Perkins

[6240380] Fix comment notification data (#10123) Dylan Jeffers [8c9b00b] [QA-1737] Center user links in collection and user cards (#10122) Dylan Jeffers [109abfa] [C-5197] Fix native comment show more/less collapse (#10121) Dylan Jeffers [c971230] [C-5212] Open comment drawer from empty state (#10117) Sebastian Klingler [528102b] Fix discovery comment notifications (#10119) Dylan Jeffers [9fe6c66] [PAY-3522] Hides keyboard when opening purchase drawer from a DM (#10116) Randy Schott [69e73dd] Re-land changes to fix RN on xcode 16 (#10108) Randy Schott [906dc0b] [QA-1773] Fix corner overflow on GiantTrackTile (#10110) Andrew Mendelsohn [7f97ca2] [C-5209] Missing $ on downloads button (#10111) Andrew Mendelsohn [b3e1982] Drop Android InputAccessoryView (#10107) Dylan Jeffers [9bd3d6c] [C-5189] Fix mobile web skeletons (#10106) JD Francis [ee775d1] Fix mobile cursor position (#10104) Dylan Jeffers [761524e] Various comment reply fixes (muting/reporting) (#10096) JD Francis [98e7bd5] Add CommentDrawerContext to manage drawer state with navigation (#10103) Sebastian Klingler [e488758] [C-5203] Fix comment unpin (#10102) Dylan Jeffers [e8cdd08] Update mobile versions to 119 (#10101) Dylan Jeffers [966246f] [C-5137] Set android cursor position when replying/editing (#10091) Sebastian Klingler [127070e] Revert "Update DN to use shortened rewards challenge IDs and specifiers (#9803)" (#10099) Marcus Pasell [a921f74] [C-5112] Dismiss keyboard when pressing in comment drawer (#10093) Sebastian Klingler [d65ce1f] Improve mobile composer input render perf (#10095) Raymond Jacobson [2b0c76c] [PAY-3525] Fix text overflow (#10072) Farid Salau [ddd3f94] Fix chat header too long on mobile (#10089) Reed [42553e6] [PAY-3507] Skeleton for profile dms button (#10090) Andrew Mendelsohn [abf3634] Update DN to use shortened rewards challenge IDs and specifiers (#9803) Marcus Pasell [4b293d8] [C-5193] Add cancel button to comment replies and edits (#10080) Kyle Shanks [c5fd316] [C-5191] Add background color to comment cancel accessory view (#10078) Kyle Shanks [2f3b7ab] [PAY-3456] Fix chat last message sometimes wrong (#10084) Reed [0ac87a0] [PAY-3519] Fix mobile ChatBlastSubHeader opacity (#10079) Reed [9f3804b] Fix android animated icons (#10085) Dylan Jeffers [c0eca98] [PAY-3526] Hide scroll on message inbox (#10083) Farid Salau [f580ff7] [PAY-3509] Show InboxUnavailableModal instead of disabled button (#10081) Andrew Mendelsohn [3ae1af1] [PAY-3521] Fix offset calculation for Blast CTA (#10076) Andrew Mendelsohn [814fa37] Highlight user mentions when editing comments on web (#10077) Kyle Shanks [3144eac] [PAY-3424] Restrict imports from SDK 'dist' folder in client code (#10043) Randy Schott [8aa7242] [PAY-3523] Fix bug where share to DM persists in input (#10070) Raymond Jacobson [9812ee2] Update dapp-store build artifacts audius-infra [bfd21d8] Fix mobile lint (#10071) Raymond Jacobson [55c22f4] [PAY-3466] Improve composer input responsiveness on mobile (#10066) Raymond Jacobson [3c0ce0f] [QA-1762] Fix desktop app support on MacOS Sequoia (#10059) Raymond Jacobson [af09710] [C-5167] Improve mobile comments perf (#10067) Sebastian Klingler [29e9b01] [C-5178] Show newlines in comments (#10065) Isaac Solo [61e8734] Fix comment unauthed state (#10061) JD Francis [d355040] Fix lint (#10064) Andrew Mendelsohn [7023824] [PAY-3520] Fix error on blast analytics (#10063) Andrew Mendelsohn [4588410] [C-5166] [C-5108] [C-5156] Address comment QA issues (#10047) Sebastian Klingler [7494a1a] [PAY-3437] Add names to chats sentry reports (#10049) Reed [856d223] [PAY-3347] Analytics for create chat blast funnel (#10053) Andrew Mendelsohn [6401b5c] [PAY-3483] Update 'ChatListBlastItem' UI on smaller screens (#10057) Farid Salau [058e233] [C-5172] Fix comments timezone (#10052) Isaac Solo [7ce770c] [C-5155] Add cancel accessory to mobile ComposerInput for comments (#10058) Kyle Shanks [f992ddb] [C-5173] Fix sort by top comments out of date (#10055) JD Francis [bf6b4a8] [C-5184] Add border to Harmony PopoverMenu (#10050) Kyle Shanks [c1a5488] [C-5161 C-5151] Improve desktop track page responsiveness (#10040) Dylan Jeffers [5de96ce] [C-5141] Generate comment id in onMutate (#10031) Dylan Jeffers [db3f11a] [⚠️] Separate SDK and legacy libs (#9972) Raymond Jacobson [e01490c] Fix withdrawals not showing coinflow modal (#10051) Marcus Pasell [1cce513] Remove follows you badge from comment settings (#10024) Isaac Solo [cb76182] [C-5165] Update comment notifications to open the comment drawer (#10039) Dylan Jeffers [7e7acc9] [QA-1761] Fix mobile profile page username spacing (#10038) Dylan Jeffers [59a1d97] [C-5040] Enable animated mobile icons (#10037) Dylan Jeffers [4d09265] [C-5164] Add max height to mobile ComposerInput (#10044) Kyle Shanks [7d7008c] [C-5153] Update ComposerInput to not render the display layer unless there is highlighted text (#10042) Kyle Shanks [e72e207] Upgrade mobile version to 1.1.118 (#10035) Dylan Jeffers

…and specifiers (#9803)" (#10099) (#10158)

[d49bb52] Add more guards to the migration for idempotency (#10259) Marcus Pasell [263569e] Include specifiers for Audio Match in migration (#10258) Marcus Pasell [7a5772e] Don't rollback the migration (#10256) Marcus Pasell [e9c3e94] [C-5310] Fix comment notifications with explicit type (#10242) Dylan Jeffers [737bec0] Fix validations for unreact comment (#10246) Isaac Solo [a2803dd] [PAY-3469] Reapply "Update DN to use shortened rewards challenge IDs and specifiers (#9803)" (#10099) (#10158) Marcus Pasell [f5e01e0] Revert "Add X-Forwarded-Proto to nginx config to fix resolve endpoint (#10239)" (#10251) Marcus Pasell [0d445df] Use msgpack between servers. (#10244) Steve Perkins

[2c174f7] Update dapp-store build artifacts audius-infra [980b3a3] Upgrade react to 18.3.1 (#10315) Dylan Jeffers [6a8368d] [PAY-3564][PAY-3567][PAY-3566] Rights attribution enhancements (#10307) Farid Salau [d59b743] Add fast crypto patch (#10313) Dylan Jeffers [ae6d881] [C-5342] Upgrade react-native to 0.75 (#10301) Dylan Jeffers [9cf8e42] Use skeletons for track and collection screens (#10310) Andrew Mendelsohn [0d9359b] Fix react-native patch (#10309) Dylan Jeffers [2bf8d52] [QA-1807] Fix Profile Page: Add entry to totalTileHeight map of 140 for grid lineup variant (#10308) Marcus Pasell [5a8730a] Add react-native patch to fix animation error (#10306) Dylan Jeffers [dacd66a] Fix fastlane version number check (#10296) Dylan Jeffers [0915236] [C-5360] Bottom bar screens deferred loading perf improvement (#10305) Andrew Mendelsohn [4fe0ff1] Trim whitespace in discovery node block list (#10303) Sebastian Klingler [cf7cb61] [C-5301] Update track and collectino unfurl string order (#10300) Kyle Shanks [61dc74d] [C-5305] Fix profile page tile text overflowing (#10298) JD Francis [dbee776] Add reply comment animation to web (#10292) Kyle Shanks [0667d35] [PAY-3560] Add cover attribution and publishing rights to RN (#10272) Farid Salau [6806bff] [C-5347] Speed up CollectionScreen transition and first render (#10288) Andrew Mendelsohn [6745685] Make is_stream_gated and is_download_gated nullable in upload schema (#10293) Sebastian Klingler [e3eec4b] [C-5430] Make mobile CTA preferred over sign up CTA (mobile web) (#10281) JD Francis [d569acc] Cleanup TrackScreen snappiness (#10284) Reed [a0ff433] [C-5294] Fix mobile bio description links positioning (#10287) Sebastian Klingler [2e24795] Make track description text selectable on web (#10260) Sebastian Klingler [cd2cda2] [C-5283] Fix comment count bugs + add tests (#10275) JD Francis [27df795] Undo temp hack used during account endpoint migration (#10285) Randy Schott [db1979d] [PAY-3572] Wait for recovery transaction to finalize before polling balance change (#10283) Randy Schott [575515d] [C-5061] Add fade in animation to comments (#10276) Kyle Shanks [182cb49] Upgrade cocoapods to 1.15.2 (#10278) Dylan Jeffers [1c01b35] Fix track updates missing userId (#10280) Randy Schott [6912333] [QA-1794] Reset padding for Safari buttons (#10279) Sebastian Klingler [a20d6b8] Update ios mobile app icons (#10273) Dylan Jeffers [018ad17] [PAY-3414] Remove UserStateManager and switch to loading account from v1 endpoint (#9673) Randy Schott [c812dae] [C-5338] Increase comment page size from 5->15 (#10253) JD Francis [63bb78d] [PAY-3562] Remove sanity checks code (#10261) Raymond Jacobson [8a307c8] [C-5317] Make TrackScreen FAST (#10267) Andrew Mendelsohn [24dfcfa] [C-5311] Upgrade react-native to 0.74 (#10245) Dylan Jeffers [6f1c0fa] [QA-1797] Fix double $ (#10270) Raymond Jacobson [ab3fcf2] [C-5308] Fix react crash in UserGeneratedText (#10266) Sebastian Klingler [2ea69d0] Blur on submit for comments but not DMs (#10265) Isaac Solo [d407b4f] Remove SEARCH_V2 feature flag (#10264) Reed [5e4c963] [C-5309] Reset comment form text on location change (#10263) Kyle Shanks [c23e92d] [PAY-3545] Add cover attribution and song ownership to track upload (#10184) Farid Salau [b0fe062] [C-5314] Add load states for comment display names & avatars (#10255) JD Francis [05dc945] Fix mobile harmony button xs size (#10243) Dylan Jeffers [2ffb5cd] Bump max audio size to 500mb (#10252) Raymond Jacobson [4337866] Upgrade mobile version to 1.1.121 (#10254) Dylan Jeffers [a2803dd] [PAY-3469] Reapply "Update DN to use shortened rewards challenge IDs and specifiers (#9803)" (#10099) (#10158) Marcus Pasell [c805724] Make Text component respect theme typography (#10086) Marcus Pasell [af1cca1] Not hardcoded file limit error message (#10247) JD Francis [1bbba4b] [C-5306] Update UserGeneratedText Links to show url on fetch fail (#10248) Kyle Shanks [da3cc8e] [QA-1789] Fix more by artist width (#10241) Andrew Mendelsohn [2ab68ed] [C-5310] Fix comment notification deep links (#10240) Dylan Jeffers

Update DN to use shortened rewards challenge IDs and specifiers

7ed0a19

rickyrombo requested review from dharit-tan, isaacsolo, schottra and sliptype September 19, 2024 23:01

rickyrombo assigned raymondjacobson Sep 19, 2024

pull-request-size bot added the size/XL label Sep 19, 2024

Merge remote-tracking branch 'origin/main' into mjp-shorter-disbursem…

bdc5a7b

…ent-ids

dharit-tan approved these changes Sep 20, 2024

View reviewed changes

sliptype approved these changes Sep 20, 2024

View reviewed changes

isaacsolo reviewed Sep 23, 2024

View reviewed changes

rickyrombo added 8 commits September 23, 2024 17:42

rename profile-completion to p in notifs and tests

d54fc6f

update track-upload to u in tests and notifications

d780ce2

update referral challenges for tests and notifs

a7d5090

update connect-verified to v for notifs and tests

e2ddf54

update mobile-install to m for notifs and tests

5e89a9a

update listen-streak to l for notifs and tests

83ad2c5

update send-first-tip to ft for notifs and tests

b43943e

update first-playlist to fp for notifs and tests

2c435db

pull-request-size bot removed the size/XL label Sep 24, 2024

Merge remote-tracking branch 'origin/main' into mjp-shorter-disbursem…

64f2a9f

…ent-ids

pull-request-size bot added the size/XXL label Sep 24, 2024

schottra approved these changes Sep 24, 2024

View reviewed changes

rickyrombo added 5 commits October 14, 2024 18:43

Merge remote-tracking branch 'origin/main' into mjp-shorter-disbursem…

f10cbde

…ent-ids

bad conflict resolution

fed6b70

move hashids to preflight

dfee20b

make new 'utils' folder for dependency-less functions etc

3917796

Update challenges test to use hashids

50024d3

rickyrombo added 3 commits October 15, 2024 16:31

Hashids in challenge tests

b4ee85f

handcraft instruction data to use new challenge id 'p' for profile co…

23f2e95

…mpletion

typo somehow

cefb18c

rickyrombo merged commit abf3634 into main Oct 16, 2024

rickyrombo deleted the mjp-shorter-disbursement-ids branch October 16, 2024 21:36

rickyrombo mentioned this pull request Oct 16, 2024

Fix migration for challenge shortening #10094

Merged

rickyrombo added a commit that referenced this pull request Oct 17, 2024

Revert "Update DN to use shortened rewards challenge IDs and specifie…

dd5aea6

…rs (#9803)" This reverts commit abf3634.

rickyrombo mentioned this pull request Oct 17, 2024

Revert "Update DN to use shortened rewards challenge IDs and specifiers (#9803)" #10099

Merged

rickyrombo added a commit that referenced this pull request Oct 17, 2024

Revert "Update DN to use shortened rewards challenge IDs and specifie…

127070e

…rs (#9803)" (#10099)

rickyrombo added a commit that referenced this pull request Oct 17, 2024

Reapply "Update DN to use shortened rewards challenge IDs and specifi…

505c995

…ers (#9803)" (#10099) This reverts commit 127070e.

rickyrombo added a commit that referenced this pull request Oct 28, 2024

[PAY-3469] Reapply "Update DN to use shortened rewards challenge IDs …

a2803dd

…and specifiers (#9803)" (#10099) (#10158)

samgutentag pushed a commit that referenced this pull request Nov 1, 2024

Update DN to use shortened rewards challenge IDs and specifiers (#9803)

0cdebef

samgutentag pushed a commit that referenced this pull request Nov 1, 2024

Revert "Update DN to use shortened rewards challenge IDs and specifie…

c9530ec

…rs (#9803)" (#10099)

samgutentag pushed a commit that referenced this pull request Nov 1, 2024

[PAY-3469] Reapply "Update DN to use shortened rewards challenge IDs …

5d548c4

…and specifiers (#9803)" (#10099) (#10158)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update DN to use shortened rewards challenge IDs and specifiers#9803

Update DN to use shortened rewards challenge IDs and specifiers#9803
rickyrombo merged 19 commits intomainfrom
mjp-shorter-disbursement-ids

rickyrombo commented Sep 19, 2024 •

edited

Loading

Uh oh!

changeset-bot bot commented Sep 19, 2024 •

edited

Loading

Uh oh!

dharit-tan left a comment

Uh oh!

sliptype Sep 20, 2024

Uh oh!

sliptype Sep 20, 2024

Uh oh!

rickyrombo Sep 23, 2024

Uh oh!

rickyrombo Oct 15, 2024

Uh oh!

isaacsolo Sep 23, 2024

Uh oh!

rickyrombo Sep 23, 2024

Uh oh!

gitguardian bot commented Sep 24, 2024 •

edited

Loading

Uh oh!

schottra Sep 24, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

rickyrombo commented Sep 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How Has This Been Tested?

RELEASE PLAN

Uh oh!

changeset-bot bot commented Sep 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

dharit-tan left a comment

Choose a reason for hiding this comment

Uh oh!

sliptype Sep 20, 2024

Choose a reason for hiding this comment

Uh oh!

sliptype Sep 20, 2024

Choose a reason for hiding this comment

Uh oh!

rickyrombo Sep 23, 2024

Choose a reason for hiding this comment

Uh oh!

rickyrombo Oct 15, 2024

Choose a reason for hiding this comment

Uh oh!

isaacsolo Sep 23, 2024

Choose a reason for hiding this comment

Uh oh!

rickyrombo Sep 23, 2024

Choose a reason for hiding this comment

Uh oh!

gitguardian bot commented Sep 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ GitGuardian has uncovered 11 secrets following the scan of your pull request.

Uh oh!

schottra Sep 24, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

rickyrombo commented Sep 19, 2024 •

edited

Loading

changeset-bot bot commented Sep 19, 2024 •

edited

Loading

gitguardian bot commented Sep 24, 2024 •

edited

Loading