Skip to content

Use msgpack between servers.#10244

Merged
stereosteve merged 2 commits intomainfrom
comms-msgpack
Oct 28, 2024
Merged

Use msgpack between servers.#10244
stereosteve merged 2 commits intomainfrom
comms-msgpack

Conversation

@stereosteve
Copy link
Contributor

Description

  • Sweeper can request + receive msgpack in addition to JSON
  • Other server looks for ?msgpack=t query param and will send msgpack with Content-Type: application/msgpack in response header
  • JSON will still work on both sides while servers upgrade

TODO:

  • After 0.7.21 is on all nodes... push POST request can send msgpack too.
  • Also after 0.7.21 is on all nodes... reset rpc_cursor to 10/23 to ensure no missed messages

@changeset-bot
Copy link

changeset-bot bot commented Oct 28, 2024

⚠️ No Changeset found

Latest commit: 6ad253d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@stereosteve stereosteve merged commit 0d445df into main Oct 28, 2024
@stereosteve stereosteve deleted the comms-msgpack branch October 28, 2024 15:16
stereosteve added a commit that referenced this pull request Oct 28, 2024
audius-infra pushed a commit that referenced this pull request Oct 29, 2024
[d49bb52] Add more guards to the migration for idempotency (#10259) Marcus Pasell
[263569e] Include specifiers for Audio Match in migration (#10258) Marcus Pasell
[7a5772e] Don't rollback the migration (#10256) Marcus Pasell
[e9c3e94] [C-5310] Fix comment notifications with explicit type (#10242) Dylan Jeffers
[737bec0] Fix validations for unreact comment (#10246) Isaac Solo
[a2803dd] [PAY-3469] Reapply "Update DN to use shortened rewards challenge IDs and specifiers (#9803)" (#10099) (#10158) Marcus Pasell
[f5e01e0] Revert "Add X-Forwarded-Proto to nginx config to fix resolve endpoint (#10239)" (#10251) Marcus Pasell
[0d445df] Use msgpack between servers. (#10244) Steve Perkins
samgutentag pushed a commit that referenced this pull request Nov 1, 2024
samgutentag pushed a commit that referenced this pull request Nov 1, 2024
[d49bb52] Add more guards to the migration for idempotency (#10259) Marcus Pasell
[263569e] Include specifiers for Audio Match in migration (#10258) Marcus Pasell
[7a5772e] Don't rollback the migration (#10256) Marcus Pasell
[e9c3e94] [C-5310] Fix comment notifications with explicit type (#10242) Dylan Jeffers
[737bec0] Fix validations for unreact comment (#10246) Isaac Solo
[a2803dd] [PAY-3469] Reapply "Update DN to use shortened rewards challenge IDs and specifiers (#9803)" (#10099) (#10158) Marcus Pasell
[f5e01e0] Revert "Add X-Forwarded-Proto to nginx config to fix resolve endpoint (#10239)" (#10251) Marcus Pasell
[0d445df] Use msgpack between servers. (#10244) Steve Perkins
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants