Skip to content

Validate comment mentions#10088

Merged
isaacsolo merged 2 commits intomainfrom
is-null-comment-mention
Oct 16, 2024
Merged

Validate comment mentions#10088
isaacsolo merged 2 commits intomainfrom
is-null-comment-mention

Conversation

@isaacsolo
Copy link

@isaacsolo isaacsolo commented Oct 16, 2024 •
edited
Loading

Description

Error in indexing blocks (psycopg2.errors.NotNullViolation) null value in column \"user_id\" of relation \"comment_mentions\" violates not-null constraint\nDETAIL:  Failing row contains (448837086, null, 2024-10-16 20:43:09, 2024-10-16 20:43:09, f, 0xcb3eba85a4287a349f6f589a4d6becdf48bb2afc74c803207e375021908eb7..., 0xfacf003400b139e932071b3e2cc9c4d254e8af0bd9ae078ea203d6e3f2a4fe

coming from


{
  "cid": "",
  "data": {
    "entity_type": "Track",
    "user_id": 283281549,
    "track_id": 1549671167,
    "body": "@sebastian2724 https://staging.audius.co/Rufus/middle-finger-type-beat-571",
    "parent_comment_id": 4683648,
    "mentions": [
      null
    ],
    "current_sort": "top",
    "new_id": 489940277,
    "entity_id": 1549671167,
    "comment_id": 489940277
  }
}

should check if all mentions are ints.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

Unblocked stage.

@changeset-bot
Copy link

changeset-bot bot commented Oct 16, 2024

⚠️ No Changeset found

Latest commit: 8b1baab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@isaacsolo isaacsolo enabled auto-merge (squash) October 16, 2024 21:16
@isaacsolo isaacsolo requested a review from sliptype October 16, 2024 21:19
@isaacsolo isaacsolo merged commit 95b738c into main Oct 16, 2024
@isaacsolo isaacsolo deleted the is-null-comment-mention branch October 16, 2024 21:53
audius-infra pushed a commit that referenced this pull request Oct 17, 2024
Audius Protocol v0.7.14
b56ffd1 
[127070e] Revert "Update DN to use shortened rewards challenge IDs and specifiers (#9803)" (#10099) Marcus Pasell
[14fba3b] Fix typo in migration (#10097) Marcus Pasell
[4732864] Fix migration for challenge shortening (#10094) Marcus Pasell
[95b738c] Validate comment mentions (#10088) Isaac Solo
[abf3634] Update DN to use shortened rewards challenge IDs and specifiers (#9803) Marcus Pasell
[f423dd0] [C-5189] Fix react and reply comment count (#10075) Isaac Solo
[e4b1895] [PAY-3518] Get new blasts after inbox settings change (#10074) Steve Perkins
samgutentag pushed a commit that referenced this pull request Nov 1, 2024
@samgutentag
Validate comment mentions (#10088)
0b2b9aa
samgutentag pushed a commit that referenced this pull request Nov 1, 2024
@samgutentag
Audius Protocol v0.7.14
c36b051 
[127070e] Revert "Update DN to use shortened rewards challenge IDs and specifiers (#9803)" (#10099) Marcus Pasell
[14fba3b] Fix typo in migration (#10097) Marcus Pasell
[4732864] Fix migration for challenge shortening (#10094) Marcus Pasell
[95b738c] Validate comment mentions (#10088) Isaac Solo
[abf3634] Update DN to use shortened rewards challenge IDs and specifiers (#9803) Marcus Pasell
[f423dd0] [C-5189] Fix react and reply comment count (#10075) Isaac Solo
[e4b1895] [PAY-3518] Get new blasts after inbox settings change (#10074) Steve Perkins
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dylanjeffers dylanjeffers Awaiting requested review from dylanjeffers

1 more reviewer

@sliptype sliptype sliptype approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@isaacsolo @sliptype