[QA-1807] Fix Profile Page: Add entry to totalTileHeight map of 140 for grid lineup variant#10308
Merged
rickyrombo merged 1 commit intomainfrom Nov 1, 2024
Merged
Conversation
|
faridsalau
approved these changes
Nov 1, 2024
Collaborator
|
Preview this change https://demo.audius.co/mjp-default-grid-lineup-tile-height |
DejayJD
approved these changes
Nov 1, 2024
audius-infra
pushed a commit
that referenced
this pull request
Nov 2, 2024
[2c174f7] Update dapp-store build artifacts audius-infra [980b3a3] Upgrade react to 18.3.1 (#10315) Dylan Jeffers [6a8368d] [PAY-3564][PAY-3567][PAY-3566] Rights attribution enhancements (#10307) Farid Salau [d59b743] Add fast crypto patch (#10313) Dylan Jeffers [ae6d881] [C-5342] Upgrade react-native to 0.75 (#10301) Dylan Jeffers [9cf8e42] Use skeletons for track and collection screens (#10310) Andrew Mendelsohn [0d9359b] Fix react-native patch (#10309) Dylan Jeffers [2bf8d52] [QA-1807] Fix Profile Page: Add entry to totalTileHeight map of 140 for grid lineup variant (#10308) Marcus Pasell [5a8730a] Add react-native patch to fix animation error (#10306) Dylan Jeffers [dacd66a] Fix fastlane version number check (#10296) Dylan Jeffers [0915236] [C-5360] Bottom bar screens deferred loading perf improvement (#10305) Andrew Mendelsohn [4fe0ff1] Trim whitespace in discovery node block list (#10303) Sebastian Klingler [cf7cb61] [C-5301] Update track and collectino unfurl string order (#10300) Kyle Shanks [61dc74d] [C-5305] Fix profile page tile text overflowing (#10298) JD Francis [dbee776] Add reply comment animation to web (#10292) Kyle Shanks [0667d35] [PAY-3560] Add cover attribution and publishing rights to RN (#10272) Farid Salau [6806bff] [C-5347] Speed up CollectionScreen transition and first render (#10288) Andrew Mendelsohn [6745685] Make is_stream_gated and is_download_gated nullable in upload schema (#10293) Sebastian Klingler [e3eec4b] [C-5430] Make mobile CTA preferred over sign up CTA (mobile web) (#10281) JD Francis [d569acc] Cleanup TrackScreen snappiness (#10284) Reed [a0ff433] [C-5294] Fix mobile bio description links positioning (#10287) Sebastian Klingler [2e24795] Make track description text selectable on web (#10260) Sebastian Klingler [cd2cda2] [C-5283] Fix comment count bugs + add tests (#10275) JD Francis [27df795] Undo temp hack used during account endpoint migration (#10285) Randy Schott [db1979d] [PAY-3572] Wait for recovery transaction to finalize before polling balance change (#10283) Randy Schott [575515d] [C-5061] Add fade in animation to comments (#10276) Kyle Shanks [182cb49] Upgrade cocoapods to 1.15.2 (#10278) Dylan Jeffers [1c01b35] Fix track updates missing userId (#10280) Randy Schott [6912333] [QA-1794] Reset padding for Safari buttons (#10279) Sebastian Klingler [a20d6b8] Update ios mobile app icons (#10273) Dylan Jeffers [018ad17] [PAY-3414] Remove UserStateManager and switch to loading account from v1 endpoint (#9673) Randy Schott [c812dae] [C-5338] Increase comment page size from 5->15 (#10253) JD Francis [63bb78d] [PAY-3562] Remove sanity checks code (#10261) Raymond Jacobson [8a307c8] [C-5317] Make TrackScreen FAST (#10267) Andrew Mendelsohn [24dfcfa] [C-5311] Upgrade react-native to 0.74 (#10245) Dylan Jeffers [6f1c0fa] [QA-1797] Fix double $ (#10270) Raymond Jacobson [ab3fcf2] [C-5308] Fix react crash in UserGeneratedText (#10266) Sebastian Klingler [2ea69d0] Blur on submit for comments but not DMs (#10265) Isaac Solo [d407b4f] Remove SEARCH_V2 feature flag (#10264) Reed [5e4c963] [C-5309] Reset comment form text on location change (#10263) Kyle Shanks [c23e92d] [PAY-3545] Add cover attribution and song ownership to track upload (#10184) Farid Salau [b0fe062] [C-5314] Add load states for comment display names & avatars (#10255) JD Francis [05dc945] Fix mobile harmony button xs size (#10243) Dylan Jeffers [2ffb5cd] Bump max audio size to 500mb (#10252) Raymond Jacobson [4337866] Upgrade mobile version to 1.1.121 (#10254) Dylan Jeffers [a2803dd] [PAY-3469] Reapply "Update DN to use shortened rewards challenge IDs and specifiers (#9803)" (#10099) (#10158) Marcus Pasell [c805724] Make Text component respect theme typography (#10086) Marcus Pasell [af1cca1] Not hardcoded file limit error message (#10247) JD Francis [1bbba4b] [C-5306] Update UserGeneratedText Links to show url on fetch fail (#10248) Kyle Shanks [da3cc8e] [QA-1789] Fix more by artist width (#10241) Andrew Mendelsohn [2ab68ed] [C-5310] Fix comment notification deep links (#10240) Dylan Jeffers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Profile page was broken in #10298 because the
totalTileHeightobject doesn't have a value for thegridvariant.This value is used to determine how many tracks to load based on how many fit on the screen at a time, so that we can load "pages" of tracks as they are visually needed.
Because the entry was missing, the math for that was returning
NaN, and then theLineupProviderwas throwing up an errorRangeError: Invalid array lengthwhen trying to render the skeleton tiles (I think) based on the count that was supposed to be loading