Skip to content

develop to v2.3.0-candidate after v2.2.11#1777

Merged
pratikspatil024 merged 25 commits intov2.3.0-candidatefrom
develop-to-2.3.0
Sep 18, 2025
Merged

develop to v2.3.0-candidate after v2.2.11#1777
pratikspatil024 merged 25 commits intov2.3.0-candidatefrom
develop-to-2.3.0

Conversation

@pratikspatil024
Copy link
Copy Markdown
Member

Description

Please provide a detailed description of what was done in this PR

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Nodes audience

In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on amoy
  • I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

kamuikatsurgi and others added 25 commits September 9, 2025 10:26
* fix: blockchain, span_store, finality data races

* chore: unit test and nits

* fix: lint
* proper error handling for blockchain instantiation

* nil check on ethstats

* nil check over ourTD
…ne (#1757)

* purge whitelisted entries, bypass validation for incorrect milestone

* small log change

* small log change
* chore: bump kurtosis-pos

* chore: change state sync test
* Periodically check canonical chain with latest milestone

Handle the edge case where a milestone arrives in the middle of chain import, where the imported chain is on a wrong fork.

* Address CR comment
* feat: witness rpc endpoints

* fix: lint

* chore: RPCMarshalWitness

* chore: move endpoints behind a flag

* chore: make docs
When a milestone doesn't match a local block, we should return an hash mismatch error, so the milestone would be kept for future evaluation.
…entry (#1764)

* eth/downloader/whitelist: remove redundant read lock

* eth/downloader/whitelist: move metrics reporting to separate function for simplicity

* eth/downloader/whitelist: check for fork correctness after chain validation

* eth/downloader/whitelist: small comment changes

* eth/downloader/whitelist: use checkpoint as well for fork correctness

* eth/downloader/whitelist: check already validated blocks

* eth/downloader/whitelist: consider last known valid block for calculating limit

* eth/downloader/whitelist: fix build errors

* eth/downloader/whitelist: parameterize max fork correctness limit

* eth/downloader/whitelist: add fork correctness tests

* eth/downloader/whitelist: remove debug logs

* eth/downloader/whitelist: cache whole fork instead of just first block, update tests

* eth/downloader/whitelist: fix potential uint64 underflow

* eth/downloader/whitelist: debug logs for better observability

* eth/downloader/whitelist: use built-in map clear function

* eth, internal/cli: add feature flag to disable blind fork validation

* fix flag name

* eth/downloader/whitelist: set empty size if flag is disabled
* remove minimum gas enforce while crearting accesslist

* unit tests

* ci fix
Backport master to develop
This commit fixes a bug where when heimdall is down, its status isn't correctly reflected in span store. The fix will make FetchStatus and GetLatestSpan non-blocking, which would allow the status of heimdall to be properly updated in span store.
@sonarqubecloud
Copy link
Copy Markdown

@pratikspatil024 pratikspatil024 requested a review from a team September 18, 2025 05:26
@pratikspatil024 pratikspatil024 merged commit ef62ee6 into v2.3.0-candidate Sep 18, 2025
12 of 13 checks passed
@pratikspatil024 pratikspatil024 deleted the develop-to-2.3.0 branch September 18, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants