[bugfix] Update heimdall status correctly#1775
Merged
pratikspatil024 merged 1 commit intodevelopfrom Sep 18, 2025
Merged
Conversation
This commit fixes a bug where when heimdall is down, its status isn't correctly reflected in span store. The fix will make FetchStatus and GetLatestSpan non-blocking, which would allow the status of heimdall to be properly updated in span store.
5788c7a to
0f83b03
Compare
|
pratikspatil024
approved these changes
Sep 18, 2025
kamuikatsurgi
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This commit fixes a bug where when heimdall is down, its status isn't correctly reflected in span store, resulting bor to continue sync/mine blocks. The fix will make
FetchStatusandGetLatestSpannon-blocking, which would allow the status of heimdall to be properly updated in span store, and makewaitUntilHeimdallIsSyncedwait when heimdall is down.Changes
Testing