Conversation
* proper error handling for blockchain instantiation * nil check on ethstats * nil check over ourTD
…ne (#1757) * purge whitelisted entries, bypass validation for incorrect milestone * small log change * small log change
kamuikatsurgi
approved these changes
Sep 11, 2025
* Periodically check canonical chain with latest milestone Handle the edge case where a milestone arrives in the middle of chain import, where the imported chain is on a wrong fork. * Address CR comment
When a milestone doesn't match a local block, we should return an hash mismatch error, so the milestone would be kept for future evaluation.
…entry (#1764) * eth/downloader/whitelist: remove redundant read lock * eth/downloader/whitelist: move metrics reporting to separate function for simplicity * eth/downloader/whitelist: check for fork correctness after chain validation * eth/downloader/whitelist: small comment changes * eth/downloader/whitelist: use checkpoint as well for fork correctness * eth/downloader/whitelist: check already validated blocks * eth/downloader/whitelist: consider last known valid block for calculating limit * eth/downloader/whitelist: fix build errors * eth/downloader/whitelist: parameterize max fork correctness limit * eth/downloader/whitelist: add fork correctness tests * eth/downloader/whitelist: remove debug logs * eth/downloader/whitelist: cache whole fork instead of just first block, update tests * eth/downloader/whitelist: fix potential uint64 underflow * eth/downloader/whitelist: debug logs for better observability * eth/downloader/whitelist: use built-in map clear function * eth, internal/cli: add feature flag to disable blind fork validation * fix flag name * eth/downloader/whitelist: set empty size if flag is disabled
|
manav2401
approved these changes
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please provide a detailed description of what was done in this PR
Changes
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Nodes audience
In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)
Checklist
Cross repository changes
Testing
Manual tests
Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it
Additional comments
Please post additional comments in this section if you have them, otherwise delete it